From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67656C2D0A3 for ; Tue, 3 Nov 2020 21:53:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09A73207BB for ; Tue, 3 Nov 2020 21:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604440424; bh=vYNjNsP1G2vZoouKPMCZ7fRCdGXUHmDmCr/9+CYnFOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tEc1k5u9n06Y3u+MaAI4kyhyMK9Yhn8BGP96q79vKoiBxuMV7dJj1Fezau9PVoFjB 9a2/VloF/M7Y7vnwJY1pqJfV5pvtUkp+FKWzmury38X0YpjTa7SNKouAG2Ck8NU/Wm 4izifRb3+45I5NbMhCWX2ISWGpb1K8mIz9zlnrHM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731145AbgKCUqI (ORCPT ); Tue, 3 Nov 2020 15:46:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:35036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729851AbgKCUqE (ORCPT ); Tue, 3 Nov 2020 15:46:04 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C731D223FD; Tue, 3 Nov 2020 20:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436364; bh=vYNjNsP1G2vZoouKPMCZ7fRCdGXUHmDmCr/9+CYnFOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q9ZvLbOYSlWC3gHId4iaYwgvxxsTCGEHiKi2zCBay7j1ug1pt6taIfyKnZY+3uH+1 RKDb8CqWutQhugZp7otvPbVv4LxkK6GQD2pX0oqRiIAgoF5KGAQmo9ZklZDWbDxJfv pcrwAR1LEt38WViHGoaaITrZrrC+L2fNeVZROf9U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Himanshu Madhani , Arun Easi , Nilesh Javali , "Martin K. Petersen" Subject: [PATCH 5.9 217/391] scsi: qla2xxx: Fix MPI reset needed message Date: Tue, 3 Nov 2020 21:34:28 +0100 Message-Id: <20201103203401.576798835@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arun Easi commit 7a6cdbd5e87515ebf6231b762ad903c7cff87b9c upstream. When printing the message: "MPI Heartbeat stop. MPI reset is not needed.." ..the wrong register was checked leading to always printing that MPI reset is not needed, even when it is needed. Fix the MPI reset message. Link: https://lore.kernel.org/r/20200929102152.32278-4-njavali@marvell.com Fixes: cbb01c2f2f63 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling") Cc: stable@vger.kernel.org Reviewed-by: Himanshu Madhani Signed-off-by: Arun Easi Signed-off-by: Nilesh Javali Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_isr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -767,7 +767,7 @@ qla27xx_handle_8200_aen(scsi_qla_host_t ql_log(ql_log_warn, vha, 0x02f0, "MPI Heartbeat stop. MPI reset is%s needed. " "MB0[%xh] MB1[%xh] MB2[%xh] MB3[%xh]\n", - mb[0] & BIT_8 ? "" : " not", + mb[1] & BIT_8 ? "" : " not", mb[0], mb[1], mb[2], mb[3]); if ((mb[1] & BIT_8) == 0)