From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2540AC00A89 for ; Thu, 5 Nov 2020 09:47:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C649C21556 for ; Thu, 5 Nov 2020 09:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726874AbgKEJrY (ORCPT ); Thu, 5 Nov 2020 04:47:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:34712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726152AbgKEJrY (ORCPT ); Thu, 5 Nov 2020 04:47:24 -0500 Received: from localhost (searspoint.nvidia.com [216.228.112.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A6012080D; Thu, 5 Nov 2020 09:47:22 +0000 (UTC) Date: Thu, 5 Nov 2020 11:47:19 +0200 From: Leon Romanovsky To: Dan Williams Cc: Dave Ertman , alsa-devel@alsa-project.org, Takashi Iwai , Mark Brown , linux-rdma , Jason Gunthorpe , Doug Ledford , Netdev , David Miller , Jakub Kicinski , Greg KH , Ranjani Sridharan , Pierre-Louis Bossart , Fred Oh , Parav Pandit , "Saleem, Shiraz" , "Patil, Kiran" , Linux Kernel Mailing List Subject: Re: [PATCH v3 01/10] Add auxiliary bus support Message-ID: <20201105094719.GQ5429@unreal> References: <20201023003338.1285642-1-david.m.ertman@intel.com> <20201023003338.1285642-2-david.m.ertman@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote: > Some doc fixups, and minor code feedback. Otherwise looks good to me. > > On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman wrote: > > <...> > > > > +config AUXILIARY_BUS > > + bool > > tristate? Unless you need non-exported symbols, might as well let this > be a module. I asked it to be "bool", because bus as a module is an invitation for a disaster. For example if I compile-in mlx5 which is based on this bus, and won't add auxiliary_bus as a module to initramfs, the system won't boot. <...> > > Per above SPDX is v2 only, so... Isn't it default for the Linux kernel? > > MODULE_LICENSE("GPL v2"); Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B1FC388F2 for ; Fri, 6 Nov 2020 08:45:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB2C720936 for ; Fri, 6 Nov 2020 08:45:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="r9rIzSJa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB2C720936 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D792D16A0; Fri, 6 Nov 2020 09:45:00 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D792D16A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604652351; bh=EOR9QDti6PjBdGlGEXLUW3DrtDi/OSl4ifFUzgwBtf4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=r9rIzSJaepTGDw/aZ8mzjp8/CFfHG8uxP3ISwmwZdcVgIK44p0DST57SMYX7CGwKp i37noRtw5D6tBKz1uab4cQHCpkI0X+BR4XJqm6Vcy/HSQEaupaLRHc971NjKZlaZot tJ3cLBHZmvWXp6Gn2QXqtpR9yLlVnXrzA71dtKKY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EA9A2F804B4; Fri, 6 Nov 2020 09:43:20 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 72728F80171; Thu, 5 Nov 2020 10:47:34 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 27ADEF800EC for ; Thu, 5 Nov 2020 10:47:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 27ADEF800EC Received: from localhost (searspoint.nvidia.com [216.228.112.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A6012080D; Thu, 5 Nov 2020 09:47:22 +0000 (UTC) Date: Thu, 5 Nov 2020 11:47:19 +0200 From: Leon Romanovsky To: Dan Williams Subject: Re: [PATCH v3 01/10] Add auxiliary bus support Message-ID: <20201105094719.GQ5429@unreal> References: <20201023003338.1285642-1-david.m.ertman@intel.com> <20201023003338.1285642-2-david.m.ertman@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Fri, 06 Nov 2020 09:43:15 +0100 Cc: alsa-devel@alsa-project.org, Parav Pandit , Greg KH , Takashi Iwai , Netdev , Ranjani Sridharan , Pierre-Louis Bossart , Fred Oh , linux-rdma , Doug Ledford , Mark Brown , Jason Gunthorpe , Jakub Kicinski , Dave Ertman , "Saleem, Shiraz" , David Miller , Linux Kernel Mailing List , "Patil, Kiran" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote: > Some doc fixups, and minor code feedback. Otherwise looks good to me. > > On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman wrote: > > <...> > > > > +config AUXILIARY_BUS > > + bool > > tristate? Unless you need non-exported symbols, might as well let this > be a module. I asked it to be "bool", because bus as a module is an invitation for a disaster. For example if I compile-in mlx5 which is based on this bus, and won't add auxiliary_bus as a module to initramfs, the system won't boot. <...> > > Per above SPDX is v2 only, so... Isn't it default for the Linux kernel? > > MODULE_LICENSE("GPL v2"); Thanks