All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: wenxu@ucloud.cn
Cc: marcelo.leitner@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next 2/2] net/sched: act_frag: add implict packet fragment support.
Date: Thu, 5 Nov 2020 14:19:20 -0800	[thread overview]
Message-ID: <20201105141920.1c4a30ad@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1604572893-16156-2-git-send-email-wenxu@ucloud.cn>

On Thu,  5 Nov 2020 18:41:33 +0800 wenxu@ucloud.cn wrote:
> From: wenxu <wenxu@ucloud.cn>
> 
> Currently kernel tc subsystem can do conntrack in act_ct. But when several
> fragment packets go through the act_ct, function tcf_ct_handle_fragments
> will defrag the packets to a big one. But the last action will redirect
> mirred to a device which maybe lead the reassembly big packet over the mtu
> of target device.
> 
> This patch add support for a xmit hook to mirred, that gets executed before
> xmiting the packet. Then, when act_ct gets loaded, it configs that hook.
> The frag xmit hook maybe reused by other modules.
> 
> Signed-off-by: wenxu <wenxu@ucloud.cn>

CHECK: Please don't use multiple blank lines
#53: FILE: include/net/act_api.h:258:
+
+

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#186: 
new file mode 100644

WARNING: line length of 95 exceeds 80 columns
#224: FILE: net/sched/act_frag.c:34:
+		__vlan_hwaccel_put_tag(skb, data->vlan_proto, data->vlan_tci & ~VLAN_CFI_MASK);

WARNING: line length of 81 exceeds 80 columns
#314: FILE: net/sched/act_frag.c:124:
+				     netdev_name(skb->dev), ntohs(skb->protocol),

  parent reply	other threads:[~2020-11-05 22:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 10:41 [PATCH v3 net-next 1/2] net/sched: act_mirred: refactor the handle of xmit wenxu
2020-11-05 10:41 ` [PATCH v3 net-next 2/2] net/sched: act_frag: add implict packet fragment support wenxu
2020-11-05 11:03   ` Davide Caratti
2020-11-05 22:19   ` Jakub Kicinski [this message]
2020-11-06  8:56   ` Marcelo Ricardo Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201105141920.1c4a30ad@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=wenxu@ucloud.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.