From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E4EAC388F7 for ; Fri, 6 Nov 2020 01:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C680F206DC for ; Fri, 6 Nov 2020 01:50:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=fossix-org.20150623.gappssmtp.com header.i=@fossix-org.20150623.gappssmtp.com header.b="dJSDIAQ4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732832AbgKFBu5 (ORCPT ); Thu, 5 Nov 2020 20:50:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732772AbgKFBu5 (ORCPT ); Thu, 5 Nov 2020 20:50:57 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA4F5C0613CF for ; Thu, 5 Nov 2020 17:50:56 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id i26so2711659pgl.5 for ; Thu, 05 Nov 2020 17:50:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fossix-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Bj6mkx33Lq/FHGsQAOAgb5U1Gocj2AWp9p/LUe5BWp8=; b=dJSDIAQ4jjGcjcwaGzD4ZlAgYa8IwO3UwpSqFuY5q1tqQ8YRaMwCROu6Z1Fi/kSKWZ kh5MDjJCfnikopT+pSVxRZ3lKpXCRX2qct8rM7z28kMJQjReAIjgBQTyT3QqiLZhD/XS m3jDBk611UGuEwdMjMTbPRB4DrujBFJp1reelkTeOSqLS0l0aFYuFBAZgRhYWjhVO7/x GPD9q6yOyriLPW70UHANSIxeF2KNx7HFXcRrNfGBKZZCX7GjjElp3zk4ZRGW9zr6hiLw 3EzeuWvXWtCB1szarGWa2rtkTqoXroG2SymZzt4DooAVwIGgH05sm5cR2WLt1WGLmdeI hZPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Bj6mkx33Lq/FHGsQAOAgb5U1Gocj2AWp9p/LUe5BWp8=; b=Lot0tfO5BJuNBGIUqFwkcz3cgJsBy4kvbclyD6BeE2zJqGA2alzp7NEHlJkub+absk bfuWBpeLRk7G3uXx6oR9ahr42JtriFy4fApcsiqEczR9FE8S9wlPRolPjVdHtGmSACKR eetnmWNOZFlcwl4i5xOEndt7FK91Re2KxiryvIeiPgY17oqgZ1+Ke7dqxBalX/j11Msr CbiVX87VRdXdc+7wD4BP4ERqmbt1rdXLPwWgy5u1H4PwnteXUU7R/AecESiZX3xJ44E3 qclv3svjLFXmW2IWVAh6b/AoZ9gSB6Jtq+hmv6vcr5FkIuFjJZ+Xn3BkdWN2WQ8BmEid /78g== X-Gm-Message-State: AOAM532DZP7/KRXPJckbJ5zDCV9DOMDiiK9X8sgofAP8jFWi7V42iCP1 6xZ5SVrDkB9xYuwO5Vm0hNmEGeZ0w/as0g== X-Google-Smtp-Source: ABdhPJxFllSk+4bISm4qJozdEm6dyBslXlrnbGUbz/i9CXI3UfQKVNdIX6iL6/tDtNeNJMYIYT7Epg== X-Received: by 2002:a62:5e06:0:b029:164:a9ca:b07e with SMTP id s6-20020a625e060000b0290164a9cab07emr4710392pfb.36.1604627456277; Thu, 05 Nov 2020 17:50:56 -0800 (PST) Received: from santosiv.in.ibm.com.com ([103.21.79.4]) by smtp.gmail.com with ESMTPSA id v3sm3357050pju.38.2020.11.05.17.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 17:50:55 -0800 (PST) From: Santosh Sivaraj To: Linux Kernel , linuxppc-dev Cc: Christophe Leroy , Santosh Sivaraj , Thomas Gleixner , Andrew Morton , Petr Mladek Subject: [PATCH v2] kernel/watchdog: Fix watchdog_allowed_mask not used warning Date: Fri, 6 Nov 2020 07:20:25 +0530 Message-Id: <20201106015025.1281561-1-santosh@fossix.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Define watchdog_allowed_mask only when SOFTLOCKUP_DETECTOR is enabled. Fixes: 7feeb9cd4f5b ("watchdog/sysctl: Clean up sysctl variable name space") Cc: Thomas Gleixner Cc: Andrew Morton Reviewed-by: Petr Mladek Signed-off-by: Santosh Sivaraj --- v2: Added Petr's reviewed-by from [1] and add fixes tag as suggested by Christophe. [1]: https://lkml.org/lkml/2020/8/20/1030 kernel/watchdog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 5abb5b22ad13..71109065bd8e 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -44,8 +44,6 @@ int __read_mostly soft_watchdog_user_enabled = 1; int __read_mostly watchdog_thresh = 10; static int __read_mostly nmi_watchdog_available; -static struct cpumask watchdog_allowed_mask __read_mostly; - struct cpumask watchdog_cpumask __read_mostly; unsigned long *watchdog_cpumask_bits = cpumask_bits(&watchdog_cpumask); @@ -162,6 +160,8 @@ static void lockup_detector_update_enable(void) int __read_mostly sysctl_softlockup_all_cpu_backtrace; #endif +static struct cpumask watchdog_allowed_mask __read_mostly; + /* Global variables, exported for sysctl */ unsigned int __read_mostly softlockup_panic = CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC_VALUE; -- 2.26.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9403C388F7 for ; Fri, 6 Nov 2020 01:52:51 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B5B5206FB for ; Fri, 6 Nov 2020 01:52:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=fossix-org.20150623.gappssmtp.com header.i=@fossix-org.20150623.gappssmtp.com header.b="dJSDIAQ4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B5B5206FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fossix.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CS3LS05C9zDrBB for ; Fri, 6 Nov 2020 12:52:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=fossix.org (client-ip=2607:f8b0:4864:20::541; helo=mail-pg1-x541.google.com; envelope-from=santosh@fossix.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=fossix.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=fossix-org.20150623.gappssmtp.com header.i=@fossix-org.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=dJSDIAQ4; dkim-atps=neutral Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CS3JS408rzDr9K for ; Fri, 6 Nov 2020 12:51:00 +1100 (AEDT) Received: by mail-pg1-x541.google.com with SMTP id z24so2717997pgk.3 for ; Thu, 05 Nov 2020 17:51:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fossix-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Bj6mkx33Lq/FHGsQAOAgb5U1Gocj2AWp9p/LUe5BWp8=; b=dJSDIAQ4jjGcjcwaGzD4ZlAgYa8IwO3UwpSqFuY5q1tqQ8YRaMwCROu6Z1Fi/kSKWZ kh5MDjJCfnikopT+pSVxRZ3lKpXCRX2qct8rM7z28kMJQjReAIjgBQTyT3QqiLZhD/XS m3jDBk611UGuEwdMjMTbPRB4DrujBFJp1reelkTeOSqLS0l0aFYuFBAZgRhYWjhVO7/x GPD9q6yOyriLPW70UHANSIxeF2KNx7HFXcRrNfGBKZZCX7GjjElp3zk4ZRGW9zr6hiLw 3EzeuWvXWtCB1szarGWa2rtkTqoXroG2SymZzt4DooAVwIGgH05sm5cR2WLt1WGLmdeI hZPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Bj6mkx33Lq/FHGsQAOAgb5U1Gocj2AWp9p/LUe5BWp8=; b=mm/mqk6XPeBQuiSXthYlH5nYj5VbeJ2MEig+0FYcQmkv0ELGL4OS4+72EM8s9882Vf yZRE80/4b2IV0tRA0JvtohRINDs5HMmK04a8CU2w4Ps8OG6vGGc+SLKWU+9DBqUAtOlP MxhWdLk+vs4X3PYieKsV2aBIavp6jPHpFjrw3LEx2paVmgVIEV7on56+wYpb3HqyitjH QHfd2UlG7EVEOzLAWF4HKTgHxDLni/df4S7XCdTlHtcJVEv4lH5wH2j7i38YFKhJNrvb MQahml20Q1Onof2PtHxqQudoSF/kflgattBMyFbA8efu+9QCFdaXRK4H6Tv4RpSiFfls 96ig== X-Gm-Message-State: AOAM532ALOmj1dIMOcLfVQ+Yk26xYhclvSHgOUAdkjnnBM2zixRoFwud iEgwo/Tfgb4EcFBreMnyHiWgbw== X-Google-Smtp-Source: ABdhPJxFllSk+4bISm4qJozdEm6dyBslXlrnbGUbz/i9CXI3UfQKVNdIX6iL6/tDtNeNJMYIYT7Epg== X-Received: by 2002:a62:5e06:0:b029:164:a9ca:b07e with SMTP id s6-20020a625e060000b0290164a9cab07emr4710392pfb.36.1604627456277; Thu, 05 Nov 2020 17:50:56 -0800 (PST) Received: from santosiv.in.ibm.com.com ([103.21.79.4]) by smtp.gmail.com with ESMTPSA id v3sm3357050pju.38.2020.11.05.17.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 17:50:55 -0800 (PST) From: Santosh Sivaraj To: Linux Kernel , linuxppc-dev Subject: [PATCH v2] kernel/watchdog: Fix watchdog_allowed_mask not used warning Date: Fri, 6 Nov 2020 07:20:25 +0530 Message-Id: <20201106015025.1281561-1-santosh@fossix.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Morton , Petr Mladek , Santosh Sivaraj , Thomas Gleixner Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Define watchdog_allowed_mask only when SOFTLOCKUP_DETECTOR is enabled. Fixes: 7feeb9cd4f5b ("watchdog/sysctl: Clean up sysctl variable name space") Cc: Thomas Gleixner Cc: Andrew Morton Reviewed-by: Petr Mladek Signed-off-by: Santosh Sivaraj --- v2: Added Petr's reviewed-by from [1] and add fixes tag as suggested by Christophe. [1]: https://lkml.org/lkml/2020/8/20/1030 kernel/watchdog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 5abb5b22ad13..71109065bd8e 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -44,8 +44,6 @@ int __read_mostly soft_watchdog_user_enabled = 1; int __read_mostly watchdog_thresh = 10; static int __read_mostly nmi_watchdog_available; -static struct cpumask watchdog_allowed_mask __read_mostly; - struct cpumask watchdog_cpumask __read_mostly; unsigned long *watchdog_cpumask_bits = cpumask_bits(&watchdog_cpumask); @@ -162,6 +160,8 @@ static void lockup_detector_update_enable(void) int __read_mostly sysctl_softlockup_all_cpu_backtrace; #endif +static struct cpumask watchdog_allowed_mask __read_mostly; + /* Global variables, exported for sysctl */ unsigned int __read_mostly softlockup_panic = CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC_VALUE; -- 2.26.2