From: Jakub Kicinski <kuba@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, bbhatt@codeaurora.org,
willemdebruijn.kernel@gmail.com, jhugo@codeaurora.org,
hemantk@codeaurora.org
Subject: Re: [PATCH v10 1/2] bus: mhi: Add mhi_queue_is_full function
Date: Fri, 6 Nov 2020 08:04:45 -0800 [thread overview]
Message-ID: <20201106080445.00588690@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201106051353.GA3473@work>
On Fri, 6 Nov 2020 10:43:53 +0530 Manivannan Sadhasivam wrote:
> On Thu, Nov 05, 2020 at 04:57:08PM -0800, Jakub Kicinski wrote:
> > On Tue, 3 Nov 2020 18:23:53 +0100 Loic Poulain wrote:
> > > This function can be used by client driver to determine whether it's
> > > possible to queue new elements in a channel ring.
> > >
> > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> >
> > Applied.
>
> Oops. I should've mentioned this (my bad) that we should use an immutable
> branch to take this change. Because, there are changes going to get merged
> into the MHI tree which will introduce merge conflicts. And moreover, we
> planned to have an immutable branch to handle a similar case with ath11k.
Damn, sorry.
> Since you've applied now, what would you propose?
Do you need mhi_queue_is_full() in other branches, or are you just
concerned about the conflicts?
I'm assuming the concern is just about the mhi/core patch, or would
you need to refactor something in the net driver as well?
next prev parent reply other threads:[~2020-11-06 16:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 17:23 [PATCH v10 1/2] bus: mhi: Add mhi_queue_is_full function Loic Poulain
2020-11-03 17:23 ` [PATCH v10 2/2] net: Add mhi-net driver Loic Poulain
2020-11-06 0:57 ` Jakub Kicinski
2020-11-06 0:57 ` [PATCH v10 1/2] bus: mhi: Add mhi_queue_is_full function Jakub Kicinski
2020-11-06 5:13 ` Manivannan Sadhasivam
2020-11-06 16:04 ` Jakub Kicinski [this message]
2020-11-06 16:28 ` Manivannan Sadhasivam
2020-11-06 16:39 ` Jakub Kicinski
2020-11-10 18:44 ` Kalle Valo
2020-11-10 18:44 ` Kalle Valo
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106080445.00588690@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=bbhatt@codeaurora.org \
--cc=davem@davemloft.net \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.