From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D937FC2D0A3 for ; Fri, 6 Nov 2020 08:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E42F208B3 for ; Fri, 6 Nov 2020 08:58:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YBGGYWCY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726592AbgKFI6Q (ORCPT ); Fri, 6 Nov 2020 03:58:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbgKFI6P (ORCPT ); Fri, 6 Nov 2020 03:58:15 -0500 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E51B8C0613CF for ; Fri, 6 Nov 2020 00:58:13 -0800 (PST) Received: by mail-pf1-x442.google.com with SMTP id y7so692732pfq.11 for ; Fri, 06 Nov 2020 00:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ht7beKQxIAbpTk+2MJgr9NYeCh/cHuggGDrae3UpH/0=; b=YBGGYWCYtBr/7OVDKg9RemOUh0t1O1mOFQv6yrW1AhI0RpUC/Xr4s7t/ll71+nsh08 K6qdCN9M/Sb7lAfHvtwDpyrzJEpxXRwe/DQOlCw7eJ07GdQOf1az3u5dbNjY0FYz+QSk aJ8PmUIYSEnIf1106wDb93KkUrS5jzkW4vno0rCSNJ4ctXAJyov1SA06oK05eqJ1YKAm /1lmuzwYr8QrhpzeBmVeTNaBQPiLWWyetykD6XJq2YeMlzdT23q//evi86RtIZ1OzzPO v396v/RotM0Pi5CYnPvKb2JPiG/NfJD1z6EZwaipAfsyZaRXpoT1VATdZNJsJaLipeX9 mmkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ht7beKQxIAbpTk+2MJgr9NYeCh/cHuggGDrae3UpH/0=; b=otKGNKMNDzSrsZ9W2JYiBOlE5fkt1lZxzSvNMNMo/6rxcs1QfGlPvaNM01yyTirE1G +JCntr2IdyDxLK8+ArD9fYYwFlAavYP+S1n+IHs6aHucKXdXoYMTFb86/Bj0SM+S96Gm pZ4PkJ7DIuSv09vPAcaIg0snda0fTFeidGiixBkGLb+I1Y7Jh0Iwnwf5nzKnsfhvRMHZ BLmGaBq+Zh6VZzfBm+g1/2Y63NQ1gq4xkogwnLrQMv7qgHIY1k7KMh0vcMshxTbmDBOx DeQGex+s8rU7OOOIHmFdTam9LI9oD/qKsLoSHk+r8GyFULRPrzUQiQfmfH5ozq0XPDGT BNpw== X-Gm-Message-State: AOAM530XyKJWnlxqtDPP3FSWw33C9iIcm/E5jwMuk/QCGXrreHdQV34Q NwpEkRiAMm0YZDHHIEsOFtVS9w== X-Google-Smtp-Source: ABdhPJxVsk4tykFJuEalPMZNi9h0aaWjzDL5DOmhzvK58wHu2Wa5avcxVDnO2k+RgOKRqLLoUIKdVg== X-Received: by 2002:a17:90b:4a10:: with SMTP id kk16mr1431011pjb.77.1604653093346; Fri, 06 Nov 2020 00:58:13 -0800 (PST) Received: from localhost ([122.172.12.172]) by smtp.gmail.com with ESMTPSA id z21sm1221365pfa.158.2020.11.06.00.58.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Nov 2020 00:58:12 -0800 (PST) Date: Fri, 6 Nov 2020 14:28:10 +0530 From: Viresh Kumar To: "H. Nikolaus Schaller" Cc: Andreas Kemnade , vireshk@kernel.org, nm@ti.com, ulf.hansson@linaro.org, stephan@gerhold.net, khilman@kernel.org, sboyd@kernel.org, linux-pm@vger.kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Discussions about the Letux Kernel Subject: Re: [Letux-kernel] [REGRESSION] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER Message-ID: <20201106085810.ubo3cikbg33x76lt@vireshk-i7> References: <20201106001018.02200778@aktux> <20201106041441.uuz5vrtqeyn6ijdv@vireshk-i7> <8728D936-6583-407F-96CF-92AE95AAECDF@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8728D936-6583-407F-96CF-92AE95AAECDF@goldelico.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06-11-20, 09:44, H. Nikolaus Schaller wrote: > > > Am 06.11.2020 um 05:14 schrieb Viresh Kumar : > > > > On 06-11-20, 00:10, Andreas Kemnade wrote: > >> Hi, > >> > >> On the GTA04 (DM3730, devicetree omap3-gta04*) I get my console flooded > >> up with the following: > >> [ 24.517211] cpu cpu0: multiple regulators are not supported > >> [ 24.523040] cpufreq: __target_index: Failed to change cpu frequency: -22 > >> [ 24.537231] ------------[ cut here ]------------ > >> [ 24.542083] WARNING: CPU: 0 PID: 5 at drivers/opp/core.c:678 dev_pm_opp_set_rate+0x23c/0x494 > >> [ 24.551086] Modules linked in: usb_f_ecm g_ether usb_f_rndis u_ether libcomposite configfs phy_twl4030_usb omap2430 musb_hdrc overlay > >> [ 24.563842] CPU: 0 PID: 5 Comm: kworker/0:0 Tainted: G W 5.9.0-rc1-00008-g629238068eb9 #14 > >> [ 24.573852] Hardware name: Generic OMAP36xx (Flattened Device Tree) > >> [ 24.580413] Workqueue: events dbs_work_handler > >> [ 24.585083] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > >> [ 24.593200] [] (show_stack) from [] (dump_stack+0x8c/0xac) > >> [ 24.600769] [] (dump_stack) from [] (__warn+0xcc/0xe4) > >> [ 24.608001] [] (__warn) from [] (warn_slowpath_fmt+0x74/0xa0) > >> [ 24.615844] [] (warn_slowpath_fmt) from [] (dev_pm_opp_set_rate+0x23c/0x494) > >> [ 24.625061] [] (dev_pm_opp_set_rate) from [] (set_target+0x2c/0x4c) > >> [ 24.633453] [] (set_target) from [] (__cpufreq_driver_target+0x190/0x22c) > >> [ 24.642395] [] (__cpufreq_driver_target) from [] (od_dbs_update+0xcc/0x158) > >> [ 24.651489] [] (od_dbs_update) from [] (dbs_work_handler+0x2c/0x54) > >> [ 24.659881] [] (dbs_work_handler) from [] (process_one_work+0x210/0x358) > >> [ 24.668731] [] (process_one_work) from [] (worker_thread+0x22c/0x2d0) > >> [ 24.677307] [] (worker_thread) from [] (kthread+0x140/0x14c) > >> [ 24.685058] [] (kthread) from [] (ret_from_fork+0x14/0x2c) > >> [ 24.692626] Exception stack(0xde4b7fb0 to 0xde4b7ff8) > >> [ 24.697906] 7fa0: 00000000 00000000 00000000 00000000 > >> [ 24.706481] 7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > >> [ 24.715057] 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > >> [ 24.722198] ---[ end trace 038b3f231fae6f81 ]--- > >> > >> endlessly after the $subject commit. Any hints? > > > > The fix for this has been in linux-next for a couple of days and it > > made it to linus/master yesterday. > > > > 47efcbcb340ic opp: Fix early exit from dev_pm_opp_register_set_opp_helper() I think I may have accidentally pasted the wrong commit here. This is the one which must have fixed it for you. commit 1f6620f87006 ("opp: Don't always remove static OPPs in _of_add_opp_table_v1()") > Seems to fix our problems on gta04 (OMAP3). > Otherwise we would have found that v5.10-rc3 magically solves it :) I assume you just ran linus's/master, otherwise the patch I shared earlier won't have fixed the issue :) > Interestingly it did not affect OMAP5. Based on the DT I saw for omap5, it does use OPPv1 and so it shouldn't have worked as well. It may be worth checking why it didn't get affected earlier. You can see the populated OPPs for a platform with this: ls /sys/kernel/debug/opp/cpu*/* You shall see some difference with and without this patch. Or it may be the case that you are adding dynamic OPPs with dev_pm_opp_add() and so even after removing the static ones, it worked (though I wasn't able to find that in the code). -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58927C2D0A3 for ; Fri, 6 Nov 2020 08:59:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFFEB208B3 for ; Fri, 6 Nov 2020 08:59:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n54Ohfrf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YBGGYWCY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFFEB208B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aqcxzWGhMhCTy3KgSGXYd3Jdgjgz0YBo9MQy5cmm7xk=; b=n54Ohfrf4UBfFp3SAs4Ipd6pD fBIUcEY3r4vWhx1HqN6t8TVnrKF6T+w7p3YUVAjuyM5vY/eppl96iE4MhdEDKKV8liK/Kh6zXwHX4 bvXgIZCTvgqwBaYGnPQZ6jEqr55w52G82mHwBy/8h9vKLJ6/8yi5Bo9j5l6Y7q5u1X9jl5hjgRU3d upyxtWEyJkLmpCzAE/qQfp8CjGWqGIOwxrJIx5dQWqdupV3b0VxMnHuLj9Ghs7UUC/7TBQCyRWixm +EFnOCbwxaOA/wPBFeFfqnmD9aXHrZbRi9XvizRIg1bDByd01G6979EpYjdrXlbFiXnOH9PaXjrdh w0piAgjDA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaxZa-00047u-C2; Fri, 06 Nov 2020 08:58:18 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaxZX-000477-H0 for linux-arm-kernel@lists.infradead.org; Fri, 06 Nov 2020 08:58:16 +0000 Received: by mail-pg1-x544.google.com with SMTP id 62so417942pgg.12 for ; Fri, 06 Nov 2020 00:58:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ht7beKQxIAbpTk+2MJgr9NYeCh/cHuggGDrae3UpH/0=; b=YBGGYWCYtBr/7OVDKg9RemOUh0t1O1mOFQv6yrW1AhI0RpUC/Xr4s7t/ll71+nsh08 K6qdCN9M/Sb7lAfHvtwDpyrzJEpxXRwe/DQOlCw7eJ07GdQOf1az3u5dbNjY0FYz+QSk aJ8PmUIYSEnIf1106wDb93KkUrS5jzkW4vno0rCSNJ4ctXAJyov1SA06oK05eqJ1YKAm /1lmuzwYr8QrhpzeBmVeTNaBQPiLWWyetykD6XJq2YeMlzdT23q//evi86RtIZ1OzzPO v396v/RotM0Pi5CYnPvKb2JPiG/NfJD1z6EZwaipAfsyZaRXpoT1VATdZNJsJaLipeX9 mmkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ht7beKQxIAbpTk+2MJgr9NYeCh/cHuggGDrae3UpH/0=; b=WQzgNHj7v4u6173qKmjmUn3bEZKETeaCMov0sxbWBtJ+RGmDYCGGSpcTFLpSd98Leu chJ9oNBPlddsY9Qthi0c6JoHp/G1CFcMeNvvUGg9HSrfX7ZRb2W+pLDlUo9fxLQ7OLIV lhfXkamWT+/803863oMUfDS+OswA6ao1t649lKnpaNrNFTyoNhWOOWUwYg/wIygWh+dv 1VJJ2+W1AqfjW+3N7vEcVWtdKy5J8TgcO+vHusgYMzXtYZOUxfgR++R4NDio012baxDl dY3MW/1bOuu7DhqPnJvzXglWrQ6F1NSDdYbUGppo3TlWMYskaqXvO4a9MlVQSJEJlySb C5jg== X-Gm-Message-State: AOAM530eVf2++srjxUcJFfnEzWWuW49z5ZD0qu06cqwqpVTpaWHIOOkX MK+ynqjSKgLWttCN0hUxogfuFw== X-Google-Smtp-Source: ABdhPJxVsk4tykFJuEalPMZNi9h0aaWjzDL5DOmhzvK58wHu2Wa5avcxVDnO2k+RgOKRqLLoUIKdVg== X-Received: by 2002:a17:90b:4a10:: with SMTP id kk16mr1431011pjb.77.1604653093346; Fri, 06 Nov 2020 00:58:13 -0800 (PST) Received: from localhost ([122.172.12.172]) by smtp.gmail.com with ESMTPSA id z21sm1221365pfa.158.2020.11.06.00.58.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Nov 2020 00:58:12 -0800 (PST) Date: Fri, 6 Nov 2020 14:28:10 +0530 From: Viresh Kumar To: "H. Nikolaus Schaller" Subject: Re: [Letux-kernel] [REGRESSION] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER Message-ID: <20201106085810.ubo3cikbg33x76lt@vireshk-i7> References: <20201106001018.02200778@aktux> <20201106041441.uuz5vrtqeyn6ijdv@vireshk-i7> <8728D936-6583-407F-96CF-92AE95AAECDF@goldelico.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8728D936-6583-407F-96CF-92AE95AAECDF@goldelico.com> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_035815_588629_12BA6D4B X-CRM114-Status: GOOD ( 22.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, ulf.hansson@linaro.org, Discussions about the Letux Kernel , stephan@gerhold.net, khilman@kernel.org, sboyd@kernel.org, vireshk@kernel.org, linux-pm@vger.kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, Andreas Kemnade , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06-11-20, 09:44, H. Nikolaus Schaller wrote: > > > Am 06.11.2020 um 05:14 schrieb Viresh Kumar : > > > > On 06-11-20, 00:10, Andreas Kemnade wrote: > >> Hi, > >> > >> On the GTA04 (DM3730, devicetree omap3-gta04*) I get my console flooded > >> up with the following: > >> [ 24.517211] cpu cpu0: multiple regulators are not supported > >> [ 24.523040] cpufreq: __target_index: Failed to change cpu frequency: -22 > >> [ 24.537231] ------------[ cut here ]------------ > >> [ 24.542083] WARNING: CPU: 0 PID: 5 at drivers/opp/core.c:678 dev_pm_opp_set_rate+0x23c/0x494 > >> [ 24.551086] Modules linked in: usb_f_ecm g_ether usb_f_rndis u_ether libcomposite configfs phy_twl4030_usb omap2430 musb_hdrc overlay > >> [ 24.563842] CPU: 0 PID: 5 Comm: kworker/0:0 Tainted: G W 5.9.0-rc1-00008-g629238068eb9 #14 > >> [ 24.573852] Hardware name: Generic OMAP36xx (Flattened Device Tree) > >> [ 24.580413] Workqueue: events dbs_work_handler > >> [ 24.585083] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > >> [ 24.593200] [] (show_stack) from [] (dump_stack+0x8c/0xac) > >> [ 24.600769] [] (dump_stack) from [] (__warn+0xcc/0xe4) > >> [ 24.608001] [] (__warn) from [] (warn_slowpath_fmt+0x74/0xa0) > >> [ 24.615844] [] (warn_slowpath_fmt) from [] (dev_pm_opp_set_rate+0x23c/0x494) > >> [ 24.625061] [] (dev_pm_opp_set_rate) from [] (set_target+0x2c/0x4c) > >> [ 24.633453] [] (set_target) from [] (__cpufreq_driver_target+0x190/0x22c) > >> [ 24.642395] [] (__cpufreq_driver_target) from [] (od_dbs_update+0xcc/0x158) > >> [ 24.651489] [] (od_dbs_update) from [] (dbs_work_handler+0x2c/0x54) > >> [ 24.659881] [] (dbs_work_handler) from [] (process_one_work+0x210/0x358) > >> [ 24.668731] [] (process_one_work) from [] (worker_thread+0x22c/0x2d0) > >> [ 24.677307] [] (worker_thread) from [] (kthread+0x140/0x14c) > >> [ 24.685058] [] (kthread) from [] (ret_from_fork+0x14/0x2c) > >> [ 24.692626] Exception stack(0xde4b7fb0 to 0xde4b7ff8) > >> [ 24.697906] 7fa0: 00000000 00000000 00000000 00000000 > >> [ 24.706481] 7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > >> [ 24.715057] 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > >> [ 24.722198] ---[ end trace 038b3f231fae6f81 ]--- > >> > >> endlessly after the $subject commit. Any hints? > > > > The fix for this has been in linux-next for a couple of days and it > > made it to linus/master yesterday. > > > > 47efcbcb340ic opp: Fix early exit from dev_pm_opp_register_set_opp_helper() I think I may have accidentally pasted the wrong commit here. This is the one which must have fixed it for you. commit 1f6620f87006 ("opp: Don't always remove static OPPs in _of_add_opp_table_v1()") > Seems to fix our problems on gta04 (OMAP3). > Otherwise we would have found that v5.10-rc3 magically solves it :) I assume you just ran linus's/master, otherwise the patch I shared earlier won't have fixed the issue :) > Interestingly it did not affect OMAP5. Based on the DT I saw for omap5, it does use OPPv1 and so it shouldn't have worked as well. It may be worth checking why it didn't get affected earlier. You can see the populated OPPs for a platform with this: ls /sys/kernel/debug/opp/cpu*/* You shall see some difference with and without this patch. Or it may be the case that you are adding dynamic OPPs with dev_pm_opp_add() and so even after removing the static ones, it worked (though I wasn't able to find that in the code). -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel