From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCA0FC55ABD for ; Fri, 6 Nov 2020 17:02:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D4E120720 for ; Fri, 6 Nov 2020 17:02:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727881AbgKFRCe (ORCPT ); Fri, 6 Nov 2020 12:02:34 -0500 Received: from outbound-smtp25.blacknight.com ([81.17.249.193]:42762 "EHLO outbound-smtp25.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbgKFRCc (ORCPT ); Fri, 6 Nov 2020 12:02:32 -0500 Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp25.blacknight.com (Postfix) with ESMTPS id 1FF2ACAAA1 for ; Fri, 6 Nov 2020 17:02:30 +0000 (GMT) Received: (qmail 10694 invoked from network); 6 Nov 2020 17:02:29 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.22.4]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 6 Nov 2020 17:02:29 -0000 Date: Fri, 6 Nov 2020 17:02:27 +0000 From: Mel Gorman To: Vincent Guittot Cc: Phil Auld , Peter Puhov , linux-kernel , Robert Foley , Ingo Molnar , Peter Zijlstra , Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Jirka Hladky Subject: Re: [PATCH v1] sched/fair: update_pick_idlest() Select group with lowest group_util when idle_cpus are equal Message-ID: <20201106170227.GG3371@techsingularity.net> References: <20200714125941.4174-1-peter.puhov@linaro.org> <20201102105043.GB3371@techsingularity.net> <20201102144418.GB154641@lorien.usersys.redhat.com> <20201104094205.GI3306@suse.de> <20201106120303.GE3371@techsingularity.net> <20201106160010.GF3371@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 06, 2020 at 05:06:59PM +0100, Vincent Guittot wrote: > > > > While it was clear-cut for 5.9, it's less clear-cut for 5.10-rc2 although > > > > the gitsource shows some severe differences depending on the machine that > > > > is worth being extremely cautious about. I would still prefer a revert > > > > but I'm also extremely biased and I know there are other patches in the > > > > > > This one from Julia can also impact > > > > > > > Which one? I'm guessing "[PATCH v2] sched/fair: check for idle core" > > Yes, Sorry I sent my answer before adding the link > Grand, that's added to the mix on top to see how both patches measure up versus a revert. No guarantee I'll have full results by Monday. As usual, the test grid is loaded up to the eyeballs. -- Mel Gorman SUSE Labs