All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Lokesh Gidra <lokeshgidra@google.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	James Morris <jmorris@namei.org>,
	Stephen Smalley <stephen.smalley.work@gmail.com>,
	Casey Schaufler <casey@schaufler-ca.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Paul Moore <paul@paul-moore.com>,
	Eric Paris <eparis@parisplace.org>,
	Daniel Colascione <dancol@dancol.org>,
	Kees Cook <keescook@chromium.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	KP Singh <kpsingh@google.com>,
	David Howells <dhowells@redhat.com>,
	Thomas Cedeno <thomascedeno@google.com>,
	Anders Roxell <anders.roxell@linaro.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	Matthew Garrett <matthewgarrett@google.com>,
	Aaron Goidel <acgoide@tycho.nsa.gov>,
	Randy Dunlap <rdunlap@infradead.org>,
	"Joel Fernandes (Google)" <joel@joelfernandes.org>,
	YueHaibing <yuehaibing@huawei.com>,
	Christian Brauner <christian.brauner@ubuntu.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Alexey Budankov <alexey.budankov@linux.intel.com>,
	Adrian Reber <areber@redhat.com>,
	Aleksa Sarai <cyphar@cyphar.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
	kaleshsingh@google.com, calin@google.com, surenb@google.com,
	nnk@google.com, jeffv@google.com, kernel-team@android.com,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	hch@infradead.org, Daniel Colascione <dancol@google.com>
Subject: Re: [PATCH v12 2/4] fs: add LSM-supporting anon-inode interface
Date: Fri, 6 Nov 2020 09:46:47 -0800	[thread overview]
Message-ID: <20201106174647.GC845@sol.localdomain> (raw)
In-Reply-To: <20201106155626.3395468-3-lokeshgidra@google.com>

On Fri, Nov 06, 2020 at 07:56:24AM -0800, Lokesh Gidra wrote:
> +/**
> + * Like anon_inode_getfd(), but creates a new !S_PRIVATE anon inode rather than
> + * reuse the singleton anon inode, and call the anon_init_security_anon() LSM
> + * hook. This allows the inode to have its own security context and for a LSM

"call the anon_init_security_anon() LSM hook" =>
"calls the inode_init_security_anon() LSM hook".

Otherwise this patch looks okay.  Feel free to add:

Reviewed-by: Eric Biggers <ebiggers@google.com>

- Eric

  reply	other threads:[~2020-11-06 17:46 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06 15:56 [PATCH v12 0/4] SELinux support for anonymous inodes and UFFD Lokesh Gidra
2020-11-06 15:56 ` Lokesh Gidra
2020-11-06 15:56 ` [PATCH v12 1/4] security: add inode_init_security_anon() LSM hook Lokesh Gidra
2020-11-06 15:56   ` Lokesh Gidra
2020-11-06 17:45   ` Eric Biggers
2020-11-06 15:56 ` [PATCH v12 2/4] fs: add LSM-supporting anon-inode interface Lokesh Gidra
2020-11-06 15:56   ` Lokesh Gidra
2020-11-06 17:46   ` Eric Biggers [this message]
2020-11-06 15:56 ` [PATCH v12 3/4] selinux: teach SELinux about anonymous inodes Lokesh Gidra
2020-11-06 15:56   ` Lokesh Gidra
2020-11-10  3:12   ` Paul Moore
2020-11-10  3:12     ` Paul Moore
2020-11-10 18:24     ` Lokesh Gidra
2020-11-10 18:24       ` Lokesh Gidra
2020-11-11  2:13       ` Paul Moore
2020-11-11  2:13         ` Paul Moore
2020-11-11  3:30         ` Lokesh Gidra
2020-11-11  3:30           ` Lokesh Gidra
2020-11-13  0:12           ` Paul Moore
2020-11-13  0:12             ` Paul Moore
2020-11-18 22:39             ` Lokesh Gidra
2020-11-18 22:39               ` Lokesh Gidra
2020-11-22 23:14               ` Paul Moore
2020-11-22 23:14                 ` Paul Moore
2020-11-23 19:20                 ` Lokesh Gidra
2020-11-23 19:20                   ` Lokesh Gidra
2020-11-23 22:42                   ` Paul Moore
2020-11-23 22:42                     ` Paul Moore
2020-11-24 20:44                     ` Lokesh Gidra
2020-11-24 20:44                       ` Lokesh Gidra
2020-11-25  1:52                       ` Paul Moore
2020-11-25  1:52                         ` Paul Moore
2020-11-06 15:56 ` [PATCH v12 4/4] userfaultfd: use secure anon inodes for userfaultfd Lokesh Gidra
2020-11-06 15:56   ` Lokesh Gidra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201106174647.GC845@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=aarcange@redhat.com \
    --cc=acgoide@tycho.nsa.gov \
    --cc=akpm@linux-foundation.org \
    --cc=alexey.budankov@linux.intel.com \
    --cc=anders.roxell@linaro.org \
    --cc=areber@redhat.com \
    --cc=ast@kernel.org \
    --cc=calin@google.com \
    --cc=casey@schaufler-ca.com \
    --cc=christian.brauner@ubuntu.com \
    --cc=cyphar@cyphar.com \
    --cc=dancol@dancol.org \
    --cc=dancol@google.com \
    --cc=dhowells@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=eparis@parisplace.org \
    --cc=hch@infradead.org \
    --cc=jeffv@google.com \
    --cc=jmorris@namei.org \
    --cc=joel@joelfernandes.org \
    --cc=kaleshsingh@google.com \
    --cc=keescook@chromium.org \
    --cc=kernel-team@android.com \
    --cc=kpsingh@google.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=lokeshgidra@google.com \
    --cc=matthewgarrett@google.com \
    --cc=nnk@google.com \
    --cc=paul@paul-moore.com \
    --cc=rdunlap@infradead.org \
    --cc=samitolvanen@google.com \
    --cc=selinux@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=stephen.smalley.work@gmail.com \
    --cc=surenb@google.com \
    --cc=thomascedeno@google.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.