From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EA27C2D0A3 for ; Fri, 6 Nov 2020 18:13:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA4C8205CA for ; Fri, 6 Nov 2020 18:13:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727159AbgKFSNN (ORCPT ); Fri, 6 Nov 2020 13:13:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:38476 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbgKFSNN (ORCPT ); Fri, 6 Nov 2020 13:13:13 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F0A7AABA2; Fri, 6 Nov 2020 18:13:11 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 83983DA6E3; Fri, 6 Nov 2020 19:11:32 +0100 (CET) Date: Fri, 6 Nov 2020 19:11:32 +0100 From: David Sterba To: Nikolay Borisov Cc: Qu Wenruo , linux-btrfs@vger.kernel.org, David Sterba Subject: Re: [PATCH 04/32] btrfs: extent_io: extract the btree page submission code into its own helper function Message-ID: <20201106181132.GR6756@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov , Qu Wenruo , linux-btrfs@vger.kernel.org, David Sterba References: <20201103133108.148112-1-wqu@suse.com> <20201103133108.148112-5-wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Nov 05, 2020 at 12:47:32PM +0200, Nikolay Borisov wrote: > > > On 3.11.20 г. 15:30 ч., Qu Wenruo wrote: > > In btree_write_cache_pages() we have a btree page submission routine > > buried deeply into a nested loop. > > > > This patch will extract that part of code into a helper function, > > submit_btree_page(), to do the same work. > > > > Also, since submit_btree_page() now can return >0 for successfull extent > > buffer submission, remove the "ASSERT(ret <= 0);" line. > > > > Signed-off-by: Qu Wenruo > > Signed-off-by: David Sterba > > --- > > fs/btrfs/extent_io.c | 116 +++++++++++++++++++++++++------------------ > > 1 file changed, 69 insertions(+), 47 deletions(-) > > > > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c > > index 9cbce0b74db7..ac396d8937b9 100644 > > --- a/fs/btrfs/extent_io.c > > +++ b/fs/btrfs/extent_io.c > > @@ -3935,10 +3935,75 @@ static noinline_for_stack int write_one_eb(struct extent_buffer *eb, > > return ret; > > } > > > > +/* > > + * A helper to submit a btree page. > > + * > > + * This function is not always submitting the page, as we only submit the full > > + * extent buffer in a batch. This is confusing, it's submitting conditionally eb pages, so the main object is eb not the pages, so it should be probably submit_eb_page.