From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2979C388F2 for ; Fri, 6 Nov 2020 19:26:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27D3D2151B for ; Fri, 6 Nov 2020 19:26:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xfZsl5/d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728160AbgKFT0B (ORCPT ); Fri, 6 Nov 2020 14:26:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728127AbgKFT0A (ORCPT ); Fri, 6 Nov 2020 14:26:00 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2D05C0613CF for ; Fri, 6 Nov 2020 11:25:59 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id 33so2452531wrl.7 for ; Fri, 06 Nov 2020 11:25:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=oQqOi+A4tLPYWRL1oJ0iRRtcnq5xRUgXBaCx3oxm6Mc=; b=xfZsl5/dkWztOXLjW8Z1+VZJ10XJyXN1acAI6i1GV1PP4DtP+z0n39q2Gce/Jy6Sb3 P6A5m+SX7xW7DxPo6yFSIy6BhqyDaf3qtGPqZxLo9Fo81KP2ZgSXFm93fox3FA3Duv6D BdeldgklgzhHhjdgDlhjorxFLqRo31JDhEr9hBkw1rKgTCH0Z3Z4n6gSGxvwGupzGMEb 8/pa8dLZP0bxFrs6u6r2AXcNGnVtmCeSbQ5B5hQZMB7+Q9ItIkhyaalzVKc8rFr+2mJ8 uxNDxpVx4uLgmjyzDg90XRByqSn2c/+0MRT8RkG+7AnsYILl7tfkGL4FpL99jCL0UByH qpOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=oQqOi+A4tLPYWRL1oJ0iRRtcnq5xRUgXBaCx3oxm6Mc=; b=mslqDQbBg3RXxR6o/vMfw/fyBMSi2kRHGRk+33/8Y3CygOBDHwM0ApYjmIn7rKqJKH CgqaCXoALpP0ZrkoGltPDNhop/yQ1Ux3f4G6QG2V/tmQJASQMHuVGErNSTtY/jcf4ADv AXe2RtirVaMB4yfuk/rPUbYvrcPY9EfvN7qr742y8e0iGVjibhQUgC3RLbrrJYISl+LG HMDC0l+U8eBvCMM+zxVwoCyMolK2el7dSg8hKY+UoyfCozh73xZC02HidrZ2sE7uafWT Ou9BqTRQ/rlf+n781ibo1SKO5F9M6DSI3nqKsOyuha98PjailPVkS54I9k0T4PQ/q3k0 i8Fg== X-Gm-Message-State: AOAM533IlfSIQreAl1m11l9fKaW7bCIR4a1t8WBpfxn0srYMyUeUzEqs ZE5XJmgoADizsfgpLC9z7UnlWw== X-Google-Smtp-Source: ABdhPJwe9QX4YmziR+H+zBejdrT0V/r/zN9gfGoV6udLJS1x0zOF7QsEqCXySIOmnZgHt7Yg4+jtrw== X-Received: by 2002:adf:e551:: with SMTP id z17mr4420567wrm.374.1604690758694; Fri, 06 Nov 2020 11:25:58 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g23sm3725133wmh.21.2020.11.06.11.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 11:25:58 -0800 (PST) Date: Fri, 6 Nov 2020 19:25:56 +0000 From: Lee Jones To: Lyude Paul Cc: linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , David Francis , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Message-ID: <20201106192556.GO2063125@dell> References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-15-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 06 Nov 2020, Lyude Paul wrote: > On Thu, 2020-11-05 at 14:45 +0000, Lee Jones wrote: > > The stack is too full. > > > > Fixes the following W=1 kernel build warning(s): > > > >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function > > ‘sideband_msg_req_encode_decode’: > >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:161:1: warning: the frame > > size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Lyude Paul > > Cc: David Francis > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Lee Jones > > --- > >  .../drm/selftests/test-drm_dp_mst_helper.c    | 29 ++++++++++++------- > >  1 file changed, 18 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > > b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > > index 1d696ec001cff..0a539456f6864 100644 > > --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > > +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > > @@ -120,44 +120,51 @@ sideband_msg_req_equal(const struct > > drm_dp_sideband_msg_req_body *in, > >  static bool > >  sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) > >  { > > -       struct drm_dp_sideband_msg_req_body out = {0}; > > +       struct drm_dp_sideband_msg_req_body *out; > >         struct drm_printer p = drm_err_printer(PREFIX_STR); > >         struct drm_dp_sideband_msg_tx txmsg; > >         int i, ret; > > +       bool result = true; > > + > > +       out = kzalloc(sizeof(*out), GFP_KERNEL); > > > > You're missing a NULL check here You're right. School-boy error! Will fix. > >         drm_dp_encode_sideband_req(in, &txmsg); Wow, what are all these? What mailer are you using? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2011C2D0A3 for ; Fri, 6 Nov 2020 19:26:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2A97206FA for ; Fri, 6 Nov 2020 19:26:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xfZsl5/d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2A97206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 215AE6E0DE; Fri, 6 Nov 2020 19:26:01 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1AE5C6E0DE for ; Fri, 6 Nov 2020 19:26:00 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id y12so2466754wrp.6 for ; Fri, 06 Nov 2020 11:26:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=oQqOi+A4tLPYWRL1oJ0iRRtcnq5xRUgXBaCx3oxm6Mc=; b=xfZsl5/dkWztOXLjW8Z1+VZJ10XJyXN1acAI6i1GV1PP4DtP+z0n39q2Gce/Jy6Sb3 P6A5m+SX7xW7DxPo6yFSIy6BhqyDaf3qtGPqZxLo9Fo81KP2ZgSXFm93fox3FA3Duv6D BdeldgklgzhHhjdgDlhjorxFLqRo31JDhEr9hBkw1rKgTCH0Z3Z4n6gSGxvwGupzGMEb 8/pa8dLZP0bxFrs6u6r2AXcNGnVtmCeSbQ5B5hQZMB7+Q9ItIkhyaalzVKc8rFr+2mJ8 uxNDxpVx4uLgmjyzDg90XRByqSn2c/+0MRT8RkG+7AnsYILl7tfkGL4FpL99jCL0UByH qpOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=oQqOi+A4tLPYWRL1oJ0iRRtcnq5xRUgXBaCx3oxm6Mc=; b=jLEbiuhGTC44nOyd9RKXNsnKxQF3erzLk5DSZ6UO9wD/ORPpfruZvBY1Xfy83az9Qi OLBWusXUy86fBXRr2W+z6+4eV8mkcCvNdif8KF7MHQmUuI7NA5yRuJVzcYLe0JYJKM/o 33yUIOMFvgGFilAhzWtyL4E+wRcoFH2EAHX8PrmUM8fPITLOQRHaezGtzWZT/HhbdFv5 N5wGFOHfEfeurdsTF5U+M4gR2IwQ/XYJu9z3kKSWppkmUsOGRlI0/nIp0DDpX70+XYor Q/Z0z6ledtJWl226DGXZHs8QdtQzvBCvxwvOcIKW2xOsPkZKJ+Cl2+keXNMW6fokeOt1 2CBw== X-Gm-Message-State: AOAM530yDr3WE7iw5FI9E6psC7gxc7FCcBMMkHvvOViBcVl4dcRdjWrR HFnEg/tOL7H+fhsx+gNy1wjBeQ== X-Google-Smtp-Source: ABdhPJwe9QX4YmziR+H+zBejdrT0V/r/zN9gfGoV6udLJS1x0zOF7QsEqCXySIOmnZgHt7Yg4+jtrw== X-Received: by 2002:adf:e551:: with SMTP id z17mr4420567wrm.374.1604690758694; Fri, 06 Nov 2020 11:25:58 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g23sm3725133wmh.21.2020.11.06.11.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 11:25:58 -0800 (PST) Date: Fri, 6 Nov 2020 19:25:56 +0000 From: Lee Jones To: Lyude Paul Subject: Re: [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Message-ID: <20201106192556.GO2063125@dell> References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-15-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , David Francis , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCAwNiBOb3YgMjAyMCwgTHl1ZGUgUGF1bCB3cm90ZToKCj4gT24gVGh1LCAyMDIwLTEx LTA1IGF0IDE0OjQ1ICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBUaGUgc3RhY2sgaXMgdG9v IGZ1bGwuCj4gPiAKPiA+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3YXJu aW5nKHMpOgo+ID4gCj4gPiDCoGRyaXZlcnMvZ3B1L2RybS9zZWxmdGVzdHMvdGVzdC1kcm1fZHBf bXN0X2hlbHBlci5jOiBJbiBmdW5jdGlvbgo+ID4g4oCYc2lkZWJhbmRfbXNnX3JlcV9lbmNvZGVf ZGVjb2Rl4oCZOgo+ID4gwqBkcml2ZXJzL2dwdS9kcm0vc2VsZnRlc3RzL3Rlc3QtZHJtX2RwX21z dF9oZWxwZXIuYzoxNjE6MTogd2FybmluZzogdGhlIGZyYW1lCj4gPiBzaXplIG9mIDExNzYgYnl0 ZXMgaXMgbGFyZ2VyIHRoYW4gMTAyNCBieXRlcyBbLVdmcmFtZS1sYXJnZXItdGhhbj1dCj4gPiAK PiA+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gPiBDYzogRGFuaWVsIFZl dHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+ID4gQ2M6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5j b20+Cj4gPiBDYzogRGF2aWQgRnJhbmNpcyA8RGF2aWQuRnJhbmNpc0BhbWQuY29tPgo+ID4gQ2M6 IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IFNpZ25lZC1vZmYtYnk6IExlZSBK b25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gPiAtLS0KPiA+IMKgLi4uL2RybS9zZWxmdGVz dHMvdGVzdC1kcm1fZHBfbXN0X2hlbHBlci5jwqDCoMKgIHwgMjkgKysrKysrKysrKysrLS0tLS0t LQo+ID4gwqAxIGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0p Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc2VsZnRlc3RzL3Rlc3QtZHJt X2RwX21zdF9oZWxwZXIuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vc2VsZnRlc3RzL3Rlc3QtZHJt X2RwX21zdF9oZWxwZXIuYwo+ID4gaW5kZXggMWQ2OTZlYzAwMWNmZi4uMGE1Mzk0NTZmNjg2NCAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zZWxmdGVzdHMvdGVzdC1kcm1fZHBfbXN0 X2hlbHBlci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vc2VsZnRlc3RzL3Rlc3QtZHJtX2Rw X21zdF9oZWxwZXIuYwo+ID4gQEAgLTEyMCw0NCArMTIwLDUxIEBAIHNpZGViYW5kX21zZ19yZXFf ZXF1YWwoY29uc3Qgc3RydWN0Cj4gPiBkcm1fZHBfc2lkZWJhbmRfbXNnX3JlcV9ib2R5ICppbiwK PiA+IMKgc3RhdGljIGJvb2wKPiA+IMKgc2lkZWJhbmRfbXNnX3JlcV9lbmNvZGVfZGVjb2RlKHN0 cnVjdCBkcm1fZHBfc2lkZWJhbmRfbXNnX3JlcV9ib2R5ICppbikKPiA+IMKgewo+ID4gLcKgwqDC oMKgwqDCoMKgc3RydWN0IGRybV9kcF9zaWRlYmFuZF9tc2dfcmVxX2JvZHkgb3V0ID0gezB9Owo+ ID4gK8KgwqDCoMKgwqDCoMKgc3RydWN0IGRybV9kcF9zaWRlYmFuZF9tc2dfcmVxX2JvZHkgKm91 dDsKPiA+IMKgwqDCoMKgwqDCoMKgwqBzdHJ1Y3QgZHJtX3ByaW50ZXIgcCA9IGRybV9lcnJfcHJp bnRlcihQUkVGSVhfU1RSKTsKPiA+IMKgwqDCoMKgwqDCoMKgwqBzdHJ1Y3QgZHJtX2RwX3NpZGVi YW5kX21zZ190eCB0eG1zZzsKPiA+IMKgwqDCoMKgwqDCoMKgwqBpbnQgaSwgcmV0Owo+ID4gK8Kg wqDCoMKgwqDCoMKgYm9vbCByZXN1bHQgPSB0cnVlOwo+ID4gKwo+ID4gK8KgwqDCoMKgwqDCoMKg b3V0ID0ga3phbGxvYyhzaXplb2YoKm91dCksIEdGUF9LRVJORUwpOwo+ID4gCj4gCj4gWW91J3Jl IG1pc3NpbmcgYSBOVUxMIGNoZWNrIGhlcmUKCllvdSdyZSByaWdodC4gIFNjaG9vbC1ib3kgZXJy b3IhICBXaWxsIGZpeC4KCj4gPiDCoMKgwqDCoMKgwqDCoMKgZHJtX2RwX2VuY29kZV9zaWRlYmFu ZF9yZXEoaW4sICZ0eG1zZyk7CgpXb3csIHdoYXQgYXJlIGFsbCB0aGVzZT8KCldoYXQgbWFpbGVy IGFyZSB5b3UgdXNpbmc/CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmlj YWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBz b2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwg QmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK