From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57685C388F7 for ; Sat, 7 Nov 2020 17:55:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C03421D81 for ; Sat, 7 Nov 2020 17:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604771743; bh=2X+pYmAeqUgWo45AdrivHzYI75Ndi9ovxTDr2Ai1aBU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=lMd+vtJDEI4woT0opC8861otRGTsCrqEQoumvDk+roZbkuXKNkAeoEGcao/krr68D PXL8ZJsQxQnXgZy9QIo/cGpo7Oql2meDKG2i2OV2/DfWsUG6TI6Ae2UxKqbdUaHhP/ WekrHioH/A0X0756J3+7p+jKjKmeCpZY3qfEFFkQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728433AbgKGRzm (ORCPT ); Sat, 7 Nov 2020 12:55:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:35212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbgKGRzm (ORCPT ); Sat, 7 Nov 2020 12:55:42 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B8D8A20885; Sat, 7 Nov 2020 17:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604771742; bh=2X+pYmAeqUgWo45AdrivHzYI75Ndi9ovxTDr2Ai1aBU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=seWan8beRUqqF0fDQau/dE5NhL2vJid6y/uv9DZL4vmCvuK1uN9cLq3nhq79hLaDE pZO0d92KZIOkFNZRUoolz5j3TtFKdfPPK2hBZV53tudz0ngHcKZjp4F0G48yWqFVlU Uqt/UPmcCbUEIK+9Rq19wUjxFoKACHR1Y915j/B4= Date: Sat, 7 Nov 2020 09:55:40 -0800 From: Jakub Kicinski To: Karsten Graul Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-s390@vger.kernel.org, hca@linux.ibm.com, raspl@linux.ibm.com Subject: Re: [PATCH net-next v3 15/15] net/smc: Add support for obtaining system information Message-ID: <20201107095540.0f45b572@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201107125958.16384-16-kgraul@linux.ibm.com> References: <20201107125958.16384-1-kgraul@linux.ibm.com> <20201107125958.16384-16-kgraul@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 7 Nov 2020 13:59:58 +0100 Karsten Graul wrote: > From: Guvenc Gulce > > Add new netlink command to obtain system information > of the smc module. > > Signed-off-by: Guvenc Gulce > Signed-off-by: Karsten Graul Checkpatch says: CHECK: Please don't use multiple blank lines #62: FILE: include/uapi/linux/smc_diag.h:140: + WARNING: line length of 84 exceeds 80 columns #172: FILE: net/smc/smc_diag.c:687: + smcd_dev = list_first_entry_or_null(&dev_list->list, struct smcd_dev, list);