From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3A83C55ABD for ; Sun, 8 Nov 2020 17:08:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DDE2206D4 for ; Sun, 8 Nov 2020 17:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604855334; bh=XGNxpA2FyNjdWXq+9xcFrh6PaAG1cJlxPgvu5XIJb24=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=sE+jTC7DRXP3Gn2QJb/9Q+q3F9qo09MvqBvWzs31s+ZtERDbSx8DqOgKwh8YXEHnF 4x8/73oOgLFx4f2H3mTVBGga9X0Iq/kETR7lg+rHHoDVoyh+dvzqBoNkq7GcRrysmH o98pKIe712QJWMO7+MewZFvtL2AcT5Lp414gAS0o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728802AbgKHRIx (ORCPT ); Sun, 8 Nov 2020 12:08:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:44754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727844AbgKHRIx (ORCPT ); Sun, 8 Nov 2020 12:08:53 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A67E20731; Sun, 8 Nov 2020 17:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604855333; bh=XGNxpA2FyNjdWXq+9xcFrh6PaAG1cJlxPgvu5XIJb24=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oa20N8mkNs7f9Xm45y7H9Vixmx2C/ABTScFL3wsr663k51arnokgdZH/r/5OwlWqe PTvSV+EFk8DiqypoYFj8RV/ou4AjnyzSGbsY5Y5lEipdFEe5NNq/PDCU1lES3eGny1 TUkkQcZSBrw0jeKmdAOPEl1xNmmpI7laCgxrA0iE= Date: Sun, 8 Nov 2020 17:08:48 +0000 From: Jonathan Cameron To: Bartosz Golaszewski Cc: Lars-Peter Clausen , Peter Meerwald-Stadler , Michal Simek , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v2 0/4] iio: adc: xilinx: use even more devres Message-ID: <20201108170848.131f7746@archlinux> In-Reply-To: <20201102142228.14949-1-brgl@bgdev.pl> References: <20201102142228.14949-1-brgl@bgdev.pl> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Nov 2020 15:22:24 +0100 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This is a follow-up to commit 750628c79bb1 ("iio: adc: xilinx-xadc: use > devm_krealloc()"). I noticed we can use even more devres helpers and entirely > drop the remove() callback. Given the generic nature of the additions to device.h I'm going to let this one sit a little longer for review. Remind me in a few weeks time if I seem to have lost it. Also, do a quick sanity check on whether I am fine to drop the platform_set_drvdata in the final patch. Thanks, Jonathan > > v1 -> v2: > - squash three patches adding more devres calls into one for easier review > - don't insist on the 80 characters limit > - add a new helper: devm_krealloc_array() and use it > > Bartosz Golaszewski (4): > device: provide devm_krealloc_array() > iio: adc: xilinx: use helper variable for &pdev->dev > iio: adc: xilinx: use devm_krealloc_array() instead of kfree() + > kcalloc() > iio: adc: xilinx: use more devres helpers and remove remove() > > drivers/iio/adc/xilinx-xadc-core.c | 151 +++++++++++++---------------- > include/linux/device.h | 11 +++ > 2 files changed, 80 insertions(+), 82 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42ECAC388F9 for ; Sun, 8 Nov 2020 17:10:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8550206D4 for ; Sun, 8 Nov 2020 17:10:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Lw4GSUeA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oa20N8mk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8550206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T7QtKqdFCbaETrxbT7F7UbTrW0QxrU/SMSffoIcbexU=; b=Lw4GSUeAmluHxMM6VEMN/2YSY 3GimlHbh8DJKfobw0pFgOgmvVl4nStYoqMA4+syz4RAWV+GNK5dVqVFG3SHpNwwiwCWIcJ19eLqDE slfXLsbefro5/1O3KjuokLyPisIo7uZNk8vtf9UP1YjxwsNZRHOBE4SlsH1E9tT/xMEbgPn1G+FCT vvZQV+KhAoI3jm0j6s72GiIKlitnvmtc5D5IBQYUVUhmGCPuVoMMjxQ136xDuQFrhSCce43NrI0vu QreIG4k5XFQpv2p3nVdhC4mPNG0qKK0DOHmUl3tf9IJrsNE4BdoMRmIr6NK4yfju2MlbqE79V2Ubv 8IWQp6epw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kboBU-0002tK-3c; Sun, 08 Nov 2020 17:08:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kboBR-0002sX-P6 for linux-arm-kernel@lists.infradead.org; Sun, 08 Nov 2020 17:08:54 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A67E20731; Sun, 8 Nov 2020 17:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604855333; bh=XGNxpA2FyNjdWXq+9xcFrh6PaAG1cJlxPgvu5XIJb24=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oa20N8mkNs7f9Xm45y7H9Vixmx2C/ABTScFL3wsr663k51arnokgdZH/r/5OwlWqe PTvSV+EFk8DiqypoYFj8RV/ou4AjnyzSGbsY5Y5lEipdFEe5NNq/PDCU1lES3eGny1 TUkkQcZSBrw0jeKmdAOPEl1xNmmpI7laCgxrA0iE= Date: Sun, 8 Nov 2020 17:08:48 +0000 From: Jonathan Cameron To: Bartosz Golaszewski Subject: Re: [PATCH v2 0/4] iio: adc: xilinx: use even more devres Message-ID: <20201108170848.131f7746@archlinux> In-Reply-To: <20201102142228.14949-1-brgl@bgdev.pl> References: <20201102142228.14949-1-brgl@bgdev.pl> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201108_120853_889806_F8BF4A9F X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Simek , Bartosz Golaszewski , Peter Meerwald-Stadler , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2 Nov 2020 15:22:24 +0100 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This is a follow-up to commit 750628c79bb1 ("iio: adc: xilinx-xadc: use > devm_krealloc()"). I noticed we can use even more devres helpers and entirely > drop the remove() callback. Given the generic nature of the additions to device.h I'm going to let this one sit a little longer for review. Remind me in a few weeks time if I seem to have lost it. Also, do a quick sanity check on whether I am fine to drop the platform_set_drvdata in the final patch. Thanks, Jonathan > > v1 -> v2: > - squash three patches adding more devres calls into one for easier review > - don't insist on the 80 characters limit > - add a new helper: devm_krealloc_array() and use it > > Bartosz Golaszewski (4): > device: provide devm_krealloc_array() > iio: adc: xilinx: use helper variable for &pdev->dev > iio: adc: xilinx: use devm_krealloc_array() instead of kfree() + > kcalloc() > iio: adc: xilinx: use more devres helpers and remove remove() > > drivers/iio/adc/xilinx-xadc-core.c | 151 +++++++++++++---------------- > include/linux/device.h | 11 +++ > 2 files changed, 80 insertions(+), 82 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel