From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D00C2D0A3 for ; Mon, 9 Nov 2020 09:42:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65D7C20789 for ; Mon, 9 Nov 2020 09:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728979AbgKIJmt (ORCPT ); Mon, 9 Nov 2020 04:42:49 -0500 Received: from foss.arm.com ([217.140.110.172]:36208 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726176AbgKIJms (ORCPT ); Mon, 9 Nov 2020 04:42:48 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4C0661042; Mon, 9 Nov 2020 01:42:48 -0800 (PST) Received: from e113632-lin.cambridge.arm.com (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 93EC03F718; Mon, 9 Nov 2020 01:42:46 -0800 (PST) From: Valentin Schneider To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Thomas Gleixner , Marc Zyngier , Lorenzo Pieralisi , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Florian Fainelli , Ray Jui , Scott Branden Subject: [PATCH 0/5] genirq: Get rid of handle_percpu_devid_fasteoi_ipi() Date: Mon, 9 Nov 2020 09:41:16 +0000 Message-Id: <20201109094121.29975-1-valentin.schneider@arm.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi folks, While hacking on the GIC flow handlers, I grew increasingly suspicious of handle_percpu_devid_fasteoi_ipi() and thus did a bit of digging. AFAICT it isn't actually needed and handle_percpu_devid_irq() would suffice. Argumentation is in patch 1. Tested on my Juno (GICv2) and eMAG (GICv3). Whichever way this goes I owe Marc some pastries, given I either - Missed something and created some noise - Turned my brain off back when reviewing this flow handler so maybe just start with pinging me what you want... Valentin Schneider (5): irqchip/gic, gic-v3: Make SGIs use handle_percpu_devid_irq() irqchip/armada-370-xp: Make IPIs use handle_percpu_devid_irq() irqchip/bcm2836: Make IPIs use handle_percpu_devid_irq() irqchip/hip04: Make IPIs use handle_percpu_devid_irq() Revert "genirq: Add fasteoi IPI flow" drivers/irqchip/irq-armada-370-xp.c | 2 +- drivers/irqchip/irq-bcm2836.c | 2 +- drivers/irqchip/irq-gic-v3.c | 6 ------ drivers/irqchip/irq-gic.c | 8 +------- drivers/irqchip/irq-hip04.c | 6 +----- include/linux/irq.h | 1 - kernel/irq/chip.c | 27 --------------------------- 7 files changed, 4 insertions(+), 48 deletions(-) -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 897B7C2D0A3 for ; Mon, 9 Nov 2020 09:43:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DF6920719 for ; Mon, 9 Nov 2020 09:43:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NGbngM18" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DF6920719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=k+/rNCLUzGLSiQz2QrCuHO2qr50aWFxxN2Nyqmt8R8k=; b=NGbngM18Li82rfy7ZeBqqCCltS I7FnVr+jNRwBqJoDJqVrsOhqVzOVpEBOl+6zbwHS3UWgWWjdD76hH4KMslX9jK/gqkQvbDdt+PivC atyboz87jaNmPS1P6sEgs163JHxVs3nve+GE5gtgAlsSTAljgrHn3IpWmsgdTIAsodWMmqOkr3riH qWgOlnLLL2fim+O/CvbolWn67GZe3CWvO0pILghNCffZur5lqx4ShEU6NBoQ67wNs76PuXEHTy4d0 5IvTHmtQEnHoAnhLclnZ6rSWj7bHeWEaDYgl62hGkzRDDVk0PzMGhaQm2oOR/ngFDvMaFVmTKbTiX uyEMjmDg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc3hM-0007cz-Q7; Mon, 09 Nov 2020 09:42:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc3hK-0007bq-F6 for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 09:42:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4C0661042; Mon, 9 Nov 2020 01:42:48 -0800 (PST) Received: from e113632-lin.cambridge.arm.com (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 93EC03F718; Mon, 9 Nov 2020 01:42:46 -0800 (PST) From: Valentin Schneider To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/5] genirq: Get rid of handle_percpu_devid_fasteoi_ipi() Date: Mon, 9 Nov 2020 09:41:16 +0000 Message-Id: <20201109094121.29975-1-valentin.schneider@arm.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_044250_600436_35CE253B X-CRM114-Status: GOOD ( 12.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Lorenzo Pieralisi , Jason Cooper , Scott Branden , Marc Zyngier , Gregory Clement , Florian Fainelli , Ray Jui , Thomas Gleixner , Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi folks, While hacking on the GIC flow handlers, I grew increasingly suspicious of handle_percpu_devid_fasteoi_ipi() and thus did a bit of digging. AFAICT it isn't actually needed and handle_percpu_devid_irq() would suffice. Argumentation is in patch 1. Tested on my Juno (GICv2) and eMAG (GICv3). Whichever way this goes I owe Marc some pastries, given I either - Missed something and created some noise - Turned my brain off back when reviewing this flow handler so maybe just start with pinging me what you want... Valentin Schneider (5): irqchip/gic, gic-v3: Make SGIs use handle_percpu_devid_irq() irqchip/armada-370-xp: Make IPIs use handle_percpu_devid_irq() irqchip/bcm2836: Make IPIs use handle_percpu_devid_irq() irqchip/hip04: Make IPIs use handle_percpu_devid_irq() Revert "genirq: Add fasteoi IPI flow" drivers/irqchip/irq-armada-370-xp.c | 2 +- drivers/irqchip/irq-bcm2836.c | 2 +- drivers/irqchip/irq-gic-v3.c | 6 ------ drivers/irqchip/irq-gic.c | 8 +------- drivers/irqchip/irq-hip04.c | 6 +----- include/linux/irq.h | 1 - kernel/irq/chip.c | 27 --------------------------- 7 files changed, 4 insertions(+), 48 deletions(-) -- 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel