From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1220C388F7 for ; Mon, 9 Nov 2020 11:45:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7423420731 for ; Mon, 9 Nov 2020 11:45:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604922340; bh=Sq0xvvrUlIfUwrgwd92TUa8sP2wVyduYHpqVBUexjyY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fJpfi0XyoJb2K4v3sj4BEDUR23iCp7JW6rFpykIam+/74q5tnJJIwSlt4SgHCXAHg SAsWAssWAob3wHgaVMRLQSZIJ8OI7LSkPeaVASIe7lU4Ugr++hM87rGzFVWNl+Kl0a 2Idhuba/3hovfEWdZX5rBI4q5/KhNWOPFMwPwAbE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729470AbgKILpj (ORCPT ); Mon, 9 Nov 2020 06:45:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:34988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729159AbgKILpj (ORCPT ); Mon, 9 Nov 2020 06:45:39 -0500 Received: from localhost (unknown [122.171.147.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B028220789; Mon, 9 Nov 2020 11:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604922338; bh=Sq0xvvrUlIfUwrgwd92TUa8sP2wVyduYHpqVBUexjyY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cLqQqk/p1pbkgyb4xv019WYnwbtfrM4irwnMHcsw5NTxs5WOLNWgc31fOIxprnAVz SaQ5GKwKM53UGzS3a5TM8BEVpa2YjoO+aoglUHxGw+TqT9uxVtrPOtNdwMxq+SkvYA EkjF3VJ8SPvcINWwwSK3G9vpXyvqAqm12IhyulEo= Date: Mon, 9 Nov 2020 17:15:34 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: nm@ti.com, ssantosh@kernel.org, robh+dt@kernel.org, vigneshr@ti.com, dan.j.williams@intel.com, t-kristo@ti.com, lokeshvutla@ti.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback Message-ID: <20201109114534.GH3171@vkoul-mobl> References: <20200930091412.8020-1-peter.ujfalusi@ti.com> <20200930091412.8020-2-peter.ujfalusi@ti.com> <20201007054404.GR2968@vkoul-mobl> <20201007155533.GZ2968@vkoul-mobl> <45adb88b-1ef8-1fbf-08c1-9afc6ea4c6f0@ti.com> <20201028055531.GH3550@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hey Peter, On 28-10-20, 11:56, Peter Ujfalusi wrote: > Hi Vinod, > > On 28/10/2020 7.55, Vinod Koul wrote: > > >> To summarize: > >> In of_dma_route_allocate() the router does not yet know the channel we > >> are going to get. > >> In of_dma_xlate() the DMA driver does not yet know if the channel will > >> use router or not. > >> I need to tell the router the event number it has to send, which is > >> based on the channel number I got. > > > > Sounds reasonable, btw why not pass this information in xlate. Router > > will have a different xlate rather than non router right, or is it same. > > Yes, the router's have their separate xlate, but in that xlate we do not > yet have a channel. I don't know what is the event I need to send from > the router to trigger the channel. > > > If this information is anyway available in DT might be better to get it > > and use from DT > > Without a channel number I can not do anything. > It is close to a chicken and egg problem. We get 'channel' in xlate, so wont that help? I think I am still missing something here :( -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F46FC388F7 for ; Mon, 9 Nov 2020 11:47:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6823206ED for ; Mon, 9 Nov 2020 11:47:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gPfrRmlW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cLqQqk/p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6823206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lDXvrRj0GKbCtNBc1fnp+bfE2yv5SlvkYolBvLWP0YY=; b=gPfrRmlWZy6MLNRVt+kdYcKG9 hP84vGBOWM15KRLUzTSUo+9nOwXrnUenJTlSl9BGcJ4By2ROJre+ynE6UXvXzRh/aMc2LPJeoI9fH /TQn9wM1D+t4BHkvDE7QaC4h/mV7uWBQiPTg3b9jHUdL/wguFyP2hJumvQaBTIJzcPkWEASvBG9Zy MJ9erSAs2e+Q2tpczHEdDqHG192fpf2u4SiSDfyj2KLKxVDYQgWW9L64ZHGLaMV2wflXz9cK2P1fa wZN45s1fexZp3ooH3q4KJGQj2+G8Ke1I/3AutgosMLwr1jmKbAsTE+TxbDRHRKDSVtlZ4klTwqNw2 wXPq4qYNQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc5dK-00033K-KK; Mon, 09 Nov 2020 11:46:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc5cD-0002ZQ-AA for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 11:46:00 +0000 Received: from localhost (unknown [122.171.147.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B028220789; Mon, 9 Nov 2020 11:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604922338; bh=Sq0xvvrUlIfUwrgwd92TUa8sP2wVyduYHpqVBUexjyY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cLqQqk/p1pbkgyb4xv019WYnwbtfrM4irwnMHcsw5NTxs5WOLNWgc31fOIxprnAVz SaQ5GKwKM53UGzS3a5TM8BEVpa2YjoO+aoglUHxGw+TqT9uxVtrPOtNdwMxq+SkvYA EkjF3VJ8SPvcINWwwSK3G9vpXyvqAqm12IhyulEo= Date: Mon, 9 Nov 2020 17:15:34 +0530 From: Vinod Koul To: Peter Ujfalusi Subject: Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback Message-ID: <20201109114534.GH3171@vkoul-mobl> References: <20200930091412.8020-1-peter.ujfalusi@ti.com> <20200930091412.8020-2-peter.ujfalusi@ti.com> <20201007054404.GR2968@vkoul-mobl> <20201007155533.GZ2968@vkoul-mobl> <45adb88b-1ef8-1fbf-08c1-9afc6ea4c6f0@ti.com> <20201028055531.GH3550@vkoul-mobl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_064541_471204_430FD976 X-CRM114-Status: GOOD ( 21.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, vigneshr@ti.com, lokeshvutla@ti.com, linux-kernel@vger.kernel.org, t-kristo@ti.com, robh+dt@kernel.org, ssantosh@kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Peter, On 28-10-20, 11:56, Peter Ujfalusi wrote: > Hi Vinod, > > On 28/10/2020 7.55, Vinod Koul wrote: > > >> To summarize: > >> In of_dma_route_allocate() the router does not yet know the channel we > >> are going to get. > >> In of_dma_xlate() the DMA driver does not yet know if the channel will > >> use router or not. > >> I need to tell the router the event number it has to send, which is > >> based on the channel number I got. > > > > Sounds reasonable, btw why not pass this information in xlate. Router > > will have a different xlate rather than non router right, or is it same. > > Yes, the router's have their separate xlate, but in that xlate we do not > yet have a channel. I don't know what is the event I need to send from > the router to trigger the channel. > > > If this information is anyway available in DT might be better to get it > > and use from DT > > Without a channel number I can not do anything. > It is close to a chicken and egg problem. We get 'channel' in xlate, so wont that help? I think I am still missing something here :( -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel