From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A12C388F7 for ; Mon, 9 Nov 2020 13:42:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F1D32068D for ; Mon, 9 Nov 2020 13:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604929366; bh=RtdrrOHxuxtK9Z64h9hB+apj90RlM8+bja2u1N6Vhok=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yoNyCduQYfvmUN2dlGMtOcEThG1soaaaCc6NvZU1a7P/aAKi3L5LDKwlsu8O8iFPZ sxnknXt/pmDDdtn//a1hNyM1GPM65AjAywhWF3RY8OC+7iB/v5vwsWISW3keAFt/nO BpZpLuwLe7O2DIQo6ToTJEPr0JMcaGYHb0clzZ7E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387947AbgKINmp (ORCPT ); Mon, 9 Nov 2020 08:42:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:54884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730343AbgKINAl (ORCPT ); Mon, 9 Nov 2020 08:00:41 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D51120789; Mon, 9 Nov 2020 13:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604926841; bh=RtdrrOHxuxtK9Z64h9hB+apj90RlM8+bja2u1N6Vhok=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ftvWP+Etj9PnDaHYiBaAUpAnbxOfKSDz6Ei7yFLhHdFIyCPWWoEQOWYkrHkATFYf+ fV478l+wnqr4u8tPs6L8Eh2+vO3qf6v3tAA8pz2uWO3QyxVNiRKreKM6O+eCZ6dlNe VpzS7ib1HwWzWffvf8w3cmKjhpm+A7a0KjXy1b60= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tom Rix , Arnd Bergmann , Sam Ravnborg , Sasha Levin Subject: [PATCH 4.9 023/117] video: fbdev: pvr2fb: initialize variables Date: Mon, 9 Nov 2020 13:54:09 +0100 Message-Id: <20201109125026.754543907@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201109125025.630721781@linuxfoundation.org> References: <20201109125025.630721781@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix [ Upstream commit 8e1ba47c60bcd325fdd097cd76054639155e5d2e ] clang static analysis reports this repesentative error pvr2fb.c:1049:2: warning: 1st function call argument is an uninitialized value [core.CallAndMessage] if (*cable_arg) ^~~~~~~~~~~~~~~ Problem is that cable_arg depends on the input loop to set the cable_arg[0]. If it does not, then some random value from the stack is used. A similar problem exists for output_arg. So initialize cable_arg and output_arg. Signed-off-by: Tom Rix Acked-by: Arnd Bergmann Signed-off-by: Sam Ravnborg Link: https://patchwork.freedesktop.org/patch/msgid/20200720191845.20115-1-trix@redhat.com Signed-off-by: Sasha Levin --- drivers/video/fbdev/pvr2fb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c index a2564ab91e62d..27478ffeeacdc 100644 --- a/drivers/video/fbdev/pvr2fb.c +++ b/drivers/video/fbdev/pvr2fb.c @@ -1029,6 +1029,8 @@ static int __init pvr2fb_setup(char *options) if (!options || !*options) return 0; + cable_arg[0] = output_arg[0] = 0; + while ((this_opt = strsep(&options, ","))) { if (!*this_opt) continue; -- 2.27.0