From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70289C388F7 for ; Mon, 9 Nov 2020 16:13:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1801220789 for ; Mon, 9 Nov 2020 16:13:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HZkrn5bF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730092AbgKIQNs (ORCPT ); Mon, 9 Nov 2020 11:13:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727774AbgKIQNs (ORCPT ); Mon, 9 Nov 2020 11:13:48 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43B97C0613CF for ; Mon, 9 Nov 2020 08:13:48 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id k2so5900752wrx.2 for ; Mon, 09 Nov 2020 08:13:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=PAQxzNvuqtCZjWn4XGCR7pwV/vojuqMxwGF9fuE2BTE=; b=HZkrn5bF9w6Z5TD3p+k1YpNDcXlvukLRKhdwRqMP/+xoZb0teMrCQc+SLlEN+Fv08s AWjb7oR5/OsCmu8g7CIuGEdoTv7ahaCSR2VPqIQjwVPahtEF6279h4og1KtCzEz+x35s nhNk3kInxjd/T9sePgn3rQ+fvWJAhOpfyz+ef37xFeQ3M9evDupplT51B37Eg1dLqKhM Yp2T3iPGEGrtpKY8GiC1oxqSqtz8LL/KKxb7RPB+rao1o1S23NvGZ1r/nLp8WFpGt/JW BougQLu8YUMnoOi9C0miCoH1whg4D/9+kiemQ9yasW7VuL9QdPQt1/o9m6NRVoii2A2r f+cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=PAQxzNvuqtCZjWn4XGCR7pwV/vojuqMxwGF9fuE2BTE=; b=aMYzOTFDViJAs3t+aVPKp2Hv9g0yKWahoNEVHWEnfbWsb1lgH+/CzSodKUSNHG2ahP L2OuWuF/6PihKnIqMC44SJRBfD1REDAZ3s+ffCJGKReFjPLdszToKyKVF4dxjqw9+gB8 3xkH+9MNjjnrNUR0aGBySO5QxjIU3eZLD2oqXBPABPZ+qw+iPAXKBtqbXnLlt2K+Mrb1 M7SN2ZehYKiPFH/D/pFDrprLHD8eifU0HUW/dvI1PCCsTESCZ0UnRpvd/pYhxScSNlpX cjldyHi2syxTek9PohS2HBFJC58WHQV20u+wc/n/aOjos2JwNAuwNDS/Sjdtjdkle1V6 qz/g== X-Gm-Message-State: AOAM530J4MUK3SqBT6DiScDyh/s+S0wSvFoEfqk6zvAGtAIEgVbXsPDu UsHN8dMOxv4QHawBe7h69QvPtQ== X-Google-Smtp-Source: ABdhPJzrTBdOQZWQKKC4cWvmWMBZZiowJs0Fb5tDz96/JoW9fF+o8i8iZiROszQGLFpp91znLB3R1g== X-Received: by 2002:adf:8bce:: with SMTP id w14mr18342271wra.242.1604938426974; Mon, 09 Nov 2020 08:13:46 -0800 (PST) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id g17sm13965748wrw.37.2020.11.09.08.13.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 08:13:46 -0800 (PST) Date: Mon, 9 Nov 2020 16:13:44 +0000 From: Lee Jones To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: David Airlie , David Francis , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Message-ID: <20201109161344.GY2063125@dell> References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-15-lee.jones@linaro.org> <20201109151937.GF6112@intel.com> <20201109161258.GX2063125@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201109161258.GX2063125@dell> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 09 Nov 2020, Lee Jones wrote: > On Mon, 09 Nov 2020, Ville Syrjälä wrote: > > > On Thu, Nov 05, 2020 at 02:45:12PM +0000, Lee Jones wrote: > > > The stack is too full. > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function ‘sideband_msg_req_encode_decode’: > > > drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:161:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > > > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Cc: Lyude Paul > > > Cc: David Francis > > > Cc: dri-devel@lists.freedesktop.org > > > Signed-off-by: Lee Jones > > > --- > > > .../drm/selftests/test-drm_dp_mst_helper.c | 29 ++++++++++++------- > > > 1 file changed, 18 insertions(+), 11 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > > > index 1d696ec001cff..0a539456f6864 100644 > > > --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > > > +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > > > @@ -120,44 +120,51 @@ sideband_msg_req_equal(const struct drm_dp_sideband_msg_req_body *in, > > > static bool > > > sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) > > > { > > > - struct drm_dp_sideband_msg_req_body out = {0}; > > > + struct drm_dp_sideband_msg_req_body *out; > > > > How big is it? And why is it that big? > > It's a struct of a union of structs. > > And it's all allocated on the stack. Bad news! FYI, I have a v2 of this patch. Just waiting to send it. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6578DC2D0A3 for ; Mon, 9 Nov 2020 16:13:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F22572074F for ; Mon, 9 Nov 2020 16:13:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HZkrn5bF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F22572074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EBBC89AB6; Mon, 9 Nov 2020 16:13:49 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4ECF389AB3 for ; Mon, 9 Nov 2020 16:13:48 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id l1so4878091wrb.9 for ; Mon, 09 Nov 2020 08:13:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=PAQxzNvuqtCZjWn4XGCR7pwV/vojuqMxwGF9fuE2BTE=; b=HZkrn5bF9w6Z5TD3p+k1YpNDcXlvukLRKhdwRqMP/+xoZb0teMrCQc+SLlEN+Fv08s AWjb7oR5/OsCmu8g7CIuGEdoTv7ahaCSR2VPqIQjwVPahtEF6279h4og1KtCzEz+x35s nhNk3kInxjd/T9sePgn3rQ+fvWJAhOpfyz+ef37xFeQ3M9evDupplT51B37Eg1dLqKhM Yp2T3iPGEGrtpKY8GiC1oxqSqtz8LL/KKxb7RPB+rao1o1S23NvGZ1r/nLp8WFpGt/JW BougQLu8YUMnoOi9C0miCoH1whg4D/9+kiemQ9yasW7VuL9QdPQt1/o9m6NRVoii2A2r f+cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=PAQxzNvuqtCZjWn4XGCR7pwV/vojuqMxwGF9fuE2BTE=; b=sKzao8nFKTNVfBMJg1qF3Bid/5GxQ/hauI/Iz4iUqEBdZWYhrUXjMiCsdM9r9E9VW2 j2CHj0Tq11km2wtxmkvIleFODUmqGuBA6XMAolk9ghJdEjQUP7XTxZ3i7kAqNgnklr8o +6USoBGTf44X79+87MrYKPG5cdCGr+M/syk6hnQZSmQ0wMVJxcx017z1hNx/1kfK1qkb CIeoVBDeE1nJAoMoVDRQW3ocupDIpvIFDj6JSekelc8P1BeFS9y5KfbqHcgOXaxTVVOU 2X2ag9hp230vje/+n62ncWchi4n6TALUtzX6TCh2ovfeJ5fZqzStS54ZLNPZz/WMvXXQ AzjQ== X-Gm-Message-State: AOAM532p/VX9e0FiIuO/QI82wKTyszQ3mTsABOiC/zWl/SLNFb4Lhl8n 0nSxrPUGTMk4nLTpBxjz4Wc/9Q== X-Google-Smtp-Source: ABdhPJzrTBdOQZWQKKC4cWvmWMBZZiowJs0Fb5tDz96/JoW9fF+o8i8iZiROszQGLFpp91znLB3R1g== X-Received: by 2002:adf:8bce:: with SMTP id w14mr18342271wra.242.1604938426974; Mon, 09 Nov 2020 08:13:46 -0800 (PST) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id g17sm13965748wrw.37.2020.11.09.08.13.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 08:13:46 -0800 (PST) Date: Mon, 9 Nov 2020 16:13:44 +0000 From: Lee Jones To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Message-ID: <20201109161344.GY2063125@dell> References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-15-lee.jones@linaro.org> <20201109151937.GF6112@intel.com> <20201109161258.GX2063125@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201109161258.GX2063125@dell> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , David Francis , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCAwOSBOb3YgMjAyMCwgTGVlIEpvbmVzIHdyb3RlOgoKPiBPbiBNb24sIDA5IE5vdiAy MDIwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gCj4gPiBPbiBUaHUsIE5vdiAwNSwgMjAyMCBh dCAwMjo0NToxMlBNICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiA+IFRoZSBzdGFjayBpcyB0 b28gZnVsbC4KPiA+ID4gCj4gPiA+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWls ZCB3YXJuaW5nKHMpOgo+ID4gPiAKPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9zZWxmdGVzdHMvdGVz dC1kcm1fZHBfbXN0X2hlbHBlci5jOiBJbiBmdW5jdGlvbiDigJhzaWRlYmFuZF9tc2dfcmVxX2Vu Y29kZV9kZWNvZGXigJk6Cj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vc2VsZnRlc3RzL3Rlc3QtZHJt X2RwX21zdF9oZWxwZXIuYzoxNjE6MTogd2FybmluZzogdGhlIGZyYW1lIHNpemUgb2YgMTE3NiBi eXRlcyBpcyBsYXJnZXIgdGhhbiAxMDI0IGJ5dGVzIFstV2ZyYW1lLWxhcmdlci10aGFuPV0KPiA+ ID4gCj4gPiA+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gPiA+IENjOiBE YW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gPiA+IENjOiBMeXVkZSBQYXVsIDxseXVk ZUByZWRoYXQuY29tPgo+ID4gPiBDYzogRGF2aWQgRnJhbmNpcyA8RGF2aWQuRnJhbmNpc0BhbWQu Y29tPgo+ID4gPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiBTaWdu ZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+ID4gPiAtLS0KPiA+ ID4gIC4uLi9kcm0vc2VsZnRlc3RzL3Rlc3QtZHJtX2RwX21zdF9oZWxwZXIuYyAgICB8IDI5ICsr KysrKysrKysrKy0tLS0tLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCsp LCAxMSBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vc2VsZnRlc3RzL3Rlc3QtZHJtX2RwX21zdF9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9z ZWxmdGVzdHMvdGVzdC1kcm1fZHBfbXN0X2hlbHBlci5jCj4gPiA+IGluZGV4IDFkNjk2ZWMwMDFj ZmYuLjBhNTM5NDU2ZjY4NjQgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zZWxm dGVzdHMvdGVzdC1kcm1fZHBfbXN0X2hlbHBlci5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9zZWxmdGVzdHMvdGVzdC1kcm1fZHBfbXN0X2hlbHBlci5jCj4gPiA+IEBAIC0xMjAsNDQgKzEy MCw1MSBAQCBzaWRlYmFuZF9tc2dfcmVxX2VxdWFsKGNvbnN0IHN0cnVjdCBkcm1fZHBfc2lkZWJh bmRfbXNnX3JlcV9ib2R5ICppbiwKPiA+ID4gIHN0YXRpYyBib29sCj4gPiA+ICBzaWRlYmFuZF9t c2dfcmVxX2VuY29kZV9kZWNvZGUoc3RydWN0IGRybV9kcF9zaWRlYmFuZF9tc2dfcmVxX2JvZHkg KmluKQo+ID4gPiAgewo+ID4gPiAtCXN0cnVjdCBkcm1fZHBfc2lkZWJhbmRfbXNnX3JlcV9ib2R5 IG91dCA9IHswfTsKPiA+ID4gKwlzdHJ1Y3QgZHJtX2RwX3NpZGViYW5kX21zZ19yZXFfYm9keSAq b3V0Owo+ID4gCj4gPiBIb3cgYmlnIGlzIGl0PyBBbmQgd2h5IGlzIGl0IHRoYXQgYmlnPwo+IAo+ IEl0J3MgYSBzdHJ1Y3Qgb2YgYSB1bmlvbiBvZiBzdHJ1Y3RzLgo+IAo+IEFuZCBpdCdzIGFsbCBh bGxvY2F0ZWQgb24gdGhlIHN0YWNrLiAgQmFkIG5ld3MhCgpGWUksIEkgaGF2ZSBhIHYyIG9mIHRo aXMgcGF0Y2guICBKdXN0IHdhaXRpbmcgdG8gc2VuZCBpdC4KCi0tIApMZWUgSm9uZXMgW+adjueQ vOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5v cmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBG YWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=