From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39EFCC5517A for ; Mon, 9 Nov 2020 20:52:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07707206E3 for ; Mon, 9 Nov 2020 20:52:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730252AbgKIUwk (ORCPT ); Mon, 9 Nov 2020 15:52:40 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:54576 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbgKIUwj (ORCPT ); Mon, 9 Nov 2020 15:52:39 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 6C7A220037; Mon, 9 Nov 2020 21:52:37 +0100 (CET) Date: Mon, 9 Nov 2020 21:52:36 +0100 From: Sam Ravnborg To: Lee Jones Cc: Alex Deucher , David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH 17/19] drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param Message-ID: <20201109205236.GA1952447@ravnborg.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> <20201106214949.2042120-18-lee.jones@linaro.org> <20201109195557.GA1940813@ravnborg.org> <20201109201013.GC2063125@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201109201013.GC2063125@dell> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=8nJEP1OIZ-IA:10 a=KKAkSRfTAAAA:8 a=zd2uoN0lAAAA:8 a=e5mUnYsNAAAA:8 a=MD3Tup5W8YOSqjGhFEoA:9 a=wPNLvfGTeEIA:10 a=cvBusfyB2V15izCimMoJ:22 a=Vxmtnl_E_bksehYqCbjh:22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 09, 2020 at 08:10:13PM +0000, Lee Jones wrote: > On Mon, 09 Nov 2020, Sam Ravnborg wrote: > > > Hi Alex, > > On Mon, Nov 09, 2020 at 02:50:35PM -0500, Alex Deucher wrote: > > > On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > > > drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Function parameter or member 'dev' not described in 'radeon_info_ioctl' > > > > drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Excess function parameter 'rdev' description in 'radeon_info_ioctl' > > > > > > > > Cc: Alex Deucher > > > > Cc: "Christian König" > > > > Cc: David Airlie > > > > Cc: Daniel Vetter > > > > Cc: amd-gfx@lists.freedesktop.org > > > > Cc: dri-devel@lists.freedesktop.org > > > > Signed-off-by: Lee Jones > > > > --- > > > > drivers/gpu/drm/radeon/radeon_kms.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c > > > > index 0d8fbabffcead..21c206795c364 100644 > > > > --- a/drivers/gpu/drm/radeon/radeon_kms.c > > > > +++ b/drivers/gpu/drm/radeon/radeon_kms.c > > > > @@ -213,7 +213,7 @@ static void radeon_set_filp_rights(struct drm_device *dev, > > > > /** > > > > * radeon_info_ioctl - answer a device specific request. > > > > * > > > > - * @rdev: radeon device pointer > > > > + * @dev: radeon device pointer > > > > > > This should be: > > > + * @dev: drm device pointer > > > > good spot. I am continuing the work on radeon and will post a patchset > > that contains only radeon fixes with Lee's patches and a few more by me. > > I will fix the above. > > What do you mean by "continuing on"? > > How will you prevent your work from conflicting with my current effort? Quoting from previous mail in this thread: " > > How would you like me to move forward? > > Fix the thousand of warnings in other places :-) > I will take a look at radeon and post a new series based on your work > with all W=1 warnings fixed. I'll drop this patch and carry on ploughing through the rest of them. " Here I promised you to fix all warnings in the radeon driver. And despite this being more work than anticipated a promise is a promise. So therefore I started working on this. If you want to do the rest of the radeon driver you are welcome and I will gladly drop this again. Just let me know your preference. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1FA3C2D0A3 for ; Mon, 9 Nov 2020 20:52:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F67020731 for ; Mon, 9 Nov 2020 20:52:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F67020731 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AEB50894DD; Mon, 9 Nov 2020 20:52:41 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 090E7894DD; Mon, 9 Nov 2020 20:52:40 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 6C7A220037; Mon, 9 Nov 2020 21:52:37 +0100 (CET) Date: Mon, 9 Nov 2020 21:52:36 +0100 From: Sam Ravnborg To: Lee Jones Subject: Re: [PATCH 17/19] drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param Message-ID: <20201109205236.GA1952447@ravnborg.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> <20201106214949.2042120-18-lee.jones@linaro.org> <20201109195557.GA1940813@ravnborg.org> <20201109201013.GC2063125@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201109201013.GC2063125@dell> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=8nJEP1OIZ-IA:10 a=KKAkSRfTAAAA:8 a=zd2uoN0lAAAA:8 a=e5mUnYsNAAAA:8 a=MD3Tup5W8YOSqjGhFEoA:9 a=wPNLvfGTeEIA:10 a=cvBusfyB2V15izCimMoJ:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , amd-gfx list , Alex Deucher , Maling list - DRI developers , Christian =?iso-8859-1?Q?K=F6nig?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Nov 09, 2020 at 08:10:13PM +0000, Lee Jones wrote: > On Mon, 09 Nov 2020, Sam Ravnborg wrote: > = > > Hi Alex, > > On Mon, Nov 09, 2020 at 02:50:35PM -0500, Alex Deucher wrote: > > > On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > > > > > > > Fixes the following W=3D1 kernel build warning(s): > > > > > > > > drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Function paramet= er or member 'dev' not described in 'radeon_info_ioctl' > > > > drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Excess function = parameter 'rdev' description in 'radeon_info_ioctl' > > > > > > > > Cc: Alex Deucher > > > > Cc: "Christian K=F6nig" > > > > Cc: David Airlie > > > > Cc: Daniel Vetter > > > > Cc: amd-gfx@lists.freedesktop.org > > > > Cc: dri-devel@lists.freedesktop.org > > > > Signed-off-by: Lee Jones > > > > --- > > > > drivers/gpu/drm/radeon/radeon_kms.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/= radeon/radeon_kms.c > > > > index 0d8fbabffcead..21c206795c364 100644 > > > > --- a/drivers/gpu/drm/radeon/radeon_kms.c > > > > +++ b/drivers/gpu/drm/radeon/radeon_kms.c > > > > @@ -213,7 +213,7 @@ static void radeon_set_filp_rights(struct drm_d= evice *dev, > > > > /** > > > > * radeon_info_ioctl - answer a device specific request. > > > > * > > > > - * @rdev: radeon device pointer > > > > + * @dev: radeon device pointer > > > = > > > This should be: > > > + * @dev: drm device pointer > > = > > good spot. I am continuing the work on radeon and will post a patchset > > that contains only radeon fixes with Lee's patches and a few more by me. > > I will fix the above. > = > What do you mean by "continuing on"? > = > How will you prevent your work from conflicting with my current effort? Quoting from previous mail in this thread: " > > How would you like me to move forward? > > Fix the thousand of warnings in other places :-) > I will take a look at radeon and post a new series based on your work > with all W=3D1 warnings fixed. I'll drop this patch and carry on ploughing through the rest of them. " Here I promised you to fix all warnings in the radeon driver. And despite this being more work than anticipated a promise is a promise. So therefore I started working on this. If you want to do the rest of the radeon driver you are welcome and I will gladly drop this again. Just let me know your preference. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83BEBC5517A for ; Mon, 9 Nov 2020 20:52:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 154EC206E3 for ; Mon, 9 Nov 2020 20:52:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 154EC206E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D5F13894DE; Mon, 9 Nov 2020 20:52:41 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 090E7894DD; Mon, 9 Nov 2020 20:52:40 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 6C7A220037; Mon, 9 Nov 2020 21:52:37 +0100 (CET) Date: Mon, 9 Nov 2020 21:52:36 +0100 From: Sam Ravnborg To: Lee Jones Subject: Re: [PATCH 17/19] drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param Message-ID: <20201109205236.GA1952447@ravnborg.org> References: <20201106214949.2042120-1-lee.jones@linaro.org> <20201106214949.2042120-18-lee.jones@linaro.org> <20201109195557.GA1940813@ravnborg.org> <20201109201013.GC2063125@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201109201013.GC2063125@dell> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=8nJEP1OIZ-IA:10 a=KKAkSRfTAAAA:8 a=zd2uoN0lAAAA:8 a=e5mUnYsNAAAA:8 a=MD3Tup5W8YOSqjGhFEoA:9 a=wPNLvfGTeEIA:10 a=cvBusfyB2V15izCimMoJ:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , amd-gfx list , Alex Deucher , Maling list - DRI developers , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, Nov 09, 2020 at 08:10:13PM +0000, Lee Jones wrote: > On Mon, 09 Nov 2020, Sam Ravnborg wrote: > = > > Hi Alex, > > On Mon, Nov 09, 2020 at 02:50:35PM -0500, Alex Deucher wrote: > > > On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > > > > > > > Fixes the following W=3D1 kernel build warning(s): > > > > > > > > drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Function paramet= er or member 'dev' not described in 'radeon_info_ioctl' > > > > drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Excess function = parameter 'rdev' description in 'radeon_info_ioctl' > > > > > > > > Cc: Alex Deucher > > > > Cc: "Christian K=F6nig" > > > > Cc: David Airlie > > > > Cc: Daniel Vetter > > > > Cc: amd-gfx@lists.freedesktop.org > > > > Cc: dri-devel@lists.freedesktop.org > > > > Signed-off-by: Lee Jones > > > > --- > > > > drivers/gpu/drm/radeon/radeon_kms.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/= radeon/radeon_kms.c > > > > index 0d8fbabffcead..21c206795c364 100644 > > > > --- a/drivers/gpu/drm/radeon/radeon_kms.c > > > > +++ b/drivers/gpu/drm/radeon/radeon_kms.c > > > > @@ -213,7 +213,7 @@ static void radeon_set_filp_rights(struct drm_d= evice *dev, > > > > /** > > > > * radeon_info_ioctl - answer a device specific request. > > > > * > > > > - * @rdev: radeon device pointer > > > > + * @dev: radeon device pointer > > > = > > > This should be: > > > + * @dev: drm device pointer > > = > > good spot. I am continuing the work on radeon and will post a patchset > > that contains only radeon fixes with Lee's patches and a few more by me. > > I will fix the above. > = > What do you mean by "continuing on"? > = > How will you prevent your work from conflicting with my current effort? Quoting from previous mail in this thread: " > > How would you like me to move forward? > > Fix the thousand of warnings in other places :-) > I will take a look at radeon and post a new series based on your work > with all W=3D1 warnings fixed. I'll drop this patch and carry on ploughing through the rest of them. " Here I promised you to fix all warnings in the radeon driver. And despite this being more work than anticipated a promise is a promise. So therefore I started working on this. If you want to do the rest of the radeon driver you are welcome and I will gladly drop this again. Just let me know your preference. Sam _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx