All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel.vetter@ffwll.ch, chris@chris-wilson.co.uk,
	petri.latvala@intel.com
Cc: igt-dev@lists.freedesktop.org, Thomas Zimmermann <tzimmermann@suse.de>
Subject: [igt-dev] [PATCH v3 8/8] tests/fbdev: Add tests for read/writing with NULL-pointer buffers
Date: Tue, 10 Nov 2020 08:51:02 +0100	[thread overview]
Message-ID: <20201110075102.5033-9-tzimmermann@suse.de> (raw)
In-Reply-To: <20201110075102.5033-1-tzimmermann@suse.de>

Trying to read and write with a NULL-pointer buffer should fail and
report EFAULT.

v3:
	* put igt_describe() before igt_subtest() (Petri)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 tests/fbdev.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/fbdev.c b/tests/fbdev.c
index 8fd920be..814188b5 100644
--- a/tests/fbdev.c
+++ b/tests/fbdev.c
@@ -229,6 +229,17 @@ static void framebuffer_tests(int fd)
 		igt_require_f(ret == 0, "read at EOF, ret=%zd\n", ret);
 	}
 
+	igt_describe("Check framebuffer access with NULL");
+	igt_subtest("nullptr") {
+		ssize_t ret;
+
+		ret = pread(fd, NULL, fix_info.smem_len, 0);
+		igt_require_f((ret == -1) && (errno == EFAULT), "reading into NULL did not return EFAULT, ret=%zd\n", ret);
+
+		ret = pwrite(fd, NULL, fix_info.smem_len, 0);
+		igt_require_f((ret == -1) && (errno == EFAULT), "writing from NULL did not return EFAULT, ret=%zd\n", ret);
+	}
+
 	igt_fixture {
 		free(buf);
 		memset(map, 0, fix_info.smem_len); // don't leave garbage on the screen
-- 
2.29.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2020-11-10  7:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  7:50 [igt-dev] [PATCH v3 0/8] Test cases for fbdev Thomas Zimmermann
2020-11-10  7:50 ` [igt-dev] [PATCH v3 1/8] tests/fbdev: Move existing tests into separate subgroups Thomas Zimmermann
2020-11-10  7:50 ` [igt-dev] [PATCH v3 2/8] tests/fbdev: Map framebuffer in igt_fixture Thomas Zimmermann
2020-11-11  9:49   ` Petri Latvala
2020-11-11 10:21     ` Thomas Zimmermann
2020-11-11 10:36       ` Petri Latvala
2020-11-10  7:50 ` [igt-dev] [PATCH v3 3/8] tests/fbdev: Add tests for read operations on framebuffer Thomas Zimmermann
2020-11-11  9:54   ` Petri Latvala
2020-11-10  7:50 ` [igt-dev] [PATCH v3 4/8] tests/fbdev: Add tests for unaligned reads on framebuffer memory Thomas Zimmermann
2020-11-11  9:56   ` Petri Latvala
2020-11-10  7:50 ` [igt-dev] [PATCH v3 5/8] tests/fbdev: Add tests for write operations on framebuffer Thomas Zimmermann
2020-11-11 10:17   ` Petri Latvala
2020-11-10  7:51 ` [igt-dev] [PATCH v3 6/8] tests/fbdev: Add tests for unaligned writes on framebuffer memory Thomas Zimmermann
2020-11-11 10:18   ` Petri Latvala
2020-11-10  7:51 ` [igt-dev] [PATCH v3 7/8] tests/fbdev: Add tests for accessing framebuffer near EOF Thomas Zimmermann
2020-11-11 10:19   ` Petri Latvala
2020-11-10  7:51 ` Thomas Zimmermann [this message]
2020-11-11 10:20   ` [igt-dev] [PATCH v3 8/8] tests/fbdev: Add tests for read/writing with NULL-pointer buffers Petri Latvala
2020-11-10 15:45 ` [igt-dev] ✗ Fi.CI.BAT: failure for Test cases for fbdev Patchwork
2020-11-11  9:11   ` Thomas Zimmermann
2020-11-11 10:22     ` Petri Latvala
2020-11-11 10:59       ` [igt-dev] =?unknown-8bit?b?4pyX?= " Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201110075102.5033-9-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.