From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44733C388F7 for ; Tue, 10 Nov 2020 08:13:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE86B20870 for ; Tue, 10 Nov 2020 08:13:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727711AbgKJINk (ORCPT ); Tue, 10 Nov 2020 03:13:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726827AbgKJINk (ORCPT ); Tue, 10 Nov 2020 03:13:40 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FA22C0613CF for ; Tue, 10 Nov 2020 00:13:40 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcOmY-0000Xc-KA; Tue, 10 Nov 2020 09:13:38 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kcOmW-0000np-HD; Tue, 10 Nov 2020 09:13:36 +0100 Date: Tue, 10 Nov 2020 09:13:36 +0100 From: Michael Tretter To: Inki Dae Cc: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, kernel@pengutronix.de, Laurent.pinchart@ideasonboard.com, krzk@kernel.org, narmstrong@baylibre.com, b.zolnierkie@samsung.com, sylvester.nawrocki@gmail.com, a.hajda@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com Subject: Re: [PATCH v2 00/16] drm/exynos: Convert driver to drm bridge Message-ID: <20201110081336.GB13669@pengutronix.de> References: <20200911135413.3654800-1-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:49:50 up 264 days, 15:20, 76 users, load average: 0.13, 0.15, 0.15 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-samsung-soc@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Mon, 09 Nov 2020 12:15:39 +0900, Inki Dae wrote: > 20. 9. 11. 오후 10:53에 Michael Tretter 이(가) 쓴 글: > > This is v2 of the series to convert the Exynos MIPI DSI driver into a drm > > bridge and make it usable with other drivers. Although the driver is > > converted, it still supports the component framework API to stay compliant > > with the Exynos DRM driver. > > > > The Exynos MIPI DSI Phy is also found on the i.MX8M Mini. However, on the > > i.MX8M Mini, the bridge is driven by an LCDIF display controller instead of > > the Exynos Decon. The driver for the LCDIF does not use the component > > framework, but uses drm bridges. > > > > I don't have any Exynos SoC to actually test the series. I build a dummy to > > test the bridge with a component driver, to make sure that at least the > > initialization is working. Furthermore, tested the driver as a bridge with a > > few additional unfinished patches on the i.MX8M Mini EVK. However, somebody > > should verify that the driver is still working on Exynos hardware. > > > > I also changed the order of the patches to first make the driver more platform > > independent (patches 2 to 8), then convert to a drm bridge driver (patches 10 > > Just a fundamental question, A MIPI-DSI(Display Serial Interface) bus device > would be one of an encoder type of devices not bridge such as DSI to LVDS > and LVDS to DSI bridge devices, and also image enhancer and image compressor > in case of Exynos. I don't understand, why the MIPI-DSI bus device would be an encoder type and DSI to LVDS or MIPI-DSI to HDMI would be bridges. For example, the device tree documentation for the DSIM states that the DSIM receives RGB video as input and produces MIPI-DSI as output. Thus, the DSIM is basically a parallel RGB to MIPI-DSI bridge and the encoder is the LCD controller that encodes the video data as parallel RGB. On the i.MX8MM, the LCDIF is already the encoder. On Exynos, the series implements the encoder in the platform glue, but in the end the encoder can probably be moved to the DECON. > Why do you want to convert such MIPI-DSI driver to bridge type of driver? > Seems not sensible. The reason would be just to share MIPI-DSI phy driver > for Exynos with i.MX8M Mini? Yes, the reason is that the driver should be shared between Exynos and i.MX8MM. It is the same IP and I don't see a reason why we should introduce another driver for the same IP if the driver works for both SoCs. Michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6254BC55ABD for ; Tue, 10 Nov 2020 08:13:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D228320829 for ; Tue, 10 Nov 2020 08:13:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D228320829 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8AB77894C3; Tue, 10 Nov 2020 08:13:41 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A2A7894C3 for ; Tue, 10 Nov 2020 08:13:40 +0000 (UTC) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcOmY-0000Xc-KA; Tue, 10 Nov 2020 09:13:38 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kcOmW-0000np-HD; Tue, 10 Nov 2020 09:13:36 +0100 Date: Tue, 10 Nov 2020 09:13:36 +0100 From: Michael Tretter To: Inki Dae Subject: Re: [PATCH v2 00/16] drm/exynos: Convert driver to drm bridge Message-ID: <20201110081336.GB13669@pengutronix.de> References: <20200911135413.3654800-1-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:49:50 up 264 days, 15:20, 76 users, load average: 0.13, 0.15, 0.15 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com, narmstrong@baylibre.com, b.zolnierkie@samsung.com, sw0312.kim@samsung.com, krzk@kernel.org, a.hajda@samsung.com, dri-devel@lists.freedesktop.org, kernel@pengutronix.de, sylvester.nawrocki@gmail.com, Laurent.pinchart@ideasonboard.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCAwOSBOb3YgMjAyMCAxMjoxNTozOSArMDkwMCwgSW5raSBEYWUgd3JvdGU6Cj4gMjAu IDkuIDExLiDsmKTtm4QgMTA6NTPsl5AgTWljaGFlbCBUcmV0dGVyIOydtCjqsIApIOyTtCDquIA6 Cj4gPiBUaGlzIGlzIHYyIG9mIHRoZSBzZXJpZXMgdG8gY29udmVydCB0aGUgRXh5bm9zIE1JUEkg RFNJIGRyaXZlciBpbnRvIGEgZHJtCj4gPiBicmlkZ2UgYW5kIG1ha2UgaXQgdXNhYmxlIHdpdGgg b3RoZXIgZHJpdmVycy4gQWx0aG91Z2ggdGhlIGRyaXZlciBpcwo+ID4gY29udmVydGVkLCBpdCBz dGlsbCBzdXBwb3J0cyB0aGUgY29tcG9uZW50IGZyYW1ld29yayBBUEkgdG8gc3RheSBjb21wbGlh bnQKPiA+IHdpdGggdGhlIEV4eW5vcyBEUk0gZHJpdmVyLgo+ID4gCj4gPiBUaGUgRXh5bm9zIE1J UEkgRFNJIFBoeSBpcyBhbHNvIGZvdW5kIG9uIHRoZSBpLk1YOE0gTWluaS4gSG93ZXZlciwgb24g dGhlCj4gPiBpLk1YOE0gTWluaSwgdGhlIGJyaWRnZSBpcyBkcml2ZW4gYnkgYW4gTENESUYgZGlz cGxheSBjb250cm9sbGVyIGluc3RlYWQgb2YKPiA+IHRoZSBFeHlub3MgRGVjb24uIFRoZSBkcml2 ZXIgZm9yIHRoZSBMQ0RJRiBkb2VzIG5vdCB1c2UgdGhlIGNvbXBvbmVudAo+ID4gZnJhbWV3b3Jr LCBidXQgdXNlcyBkcm0gYnJpZGdlcy4KPiA+IAo+ID4gSSBkb24ndCBoYXZlIGFueSBFeHlub3Mg U29DIHRvIGFjdHVhbGx5IHRlc3QgdGhlIHNlcmllcy4gSSBidWlsZCBhIGR1bW15IHRvCj4gPiB0 ZXN0IHRoZSBicmlkZ2Ugd2l0aCBhIGNvbXBvbmVudCBkcml2ZXIsIHRvIG1ha2Ugc3VyZSB0aGF0 IGF0IGxlYXN0IHRoZQo+ID4gaW5pdGlhbGl6YXRpb24gaXMgd29ya2luZy4gRnVydGhlcm1vcmUs IHRlc3RlZCB0aGUgZHJpdmVyIGFzIGEgYnJpZGdlIHdpdGggYQo+ID4gZmV3IGFkZGl0aW9uYWwg dW5maW5pc2hlZCBwYXRjaGVzIG9uIHRoZSBpLk1YOE0gTWluaSBFVksuIEhvd2V2ZXIsIHNvbWVi b2R5Cj4gPiBzaG91bGQgdmVyaWZ5IHRoYXQgdGhlIGRyaXZlciBpcyBzdGlsbCB3b3JraW5nIG9u IEV4eW5vcyBoYXJkd2FyZS4KPiA+IAo+ID4gSSBhbHNvIGNoYW5nZWQgdGhlIG9yZGVyIG9mIHRo ZSBwYXRjaGVzIHRvIGZpcnN0IG1ha2UgdGhlIGRyaXZlciBtb3JlIHBsYXRmb3JtCj4gPiBpbmRl cGVuZGVudCAocGF0Y2hlcyAyIHRvIDgpLCB0aGVuIGNvbnZlcnQgdG8gYSBkcm0gYnJpZGdlIGRy aXZlciAocGF0Y2hlcyAxMAo+IAo+IEp1c3QgYSBmdW5kYW1lbnRhbCBxdWVzdGlvbiwgQSBNSVBJ LURTSShEaXNwbGF5IFNlcmlhbCBJbnRlcmZhY2UpIGJ1cyBkZXZpY2UKPiB3b3VsZCBiZSBvbmUg b2YgYW4gZW5jb2RlciB0eXBlIG9mIGRldmljZXMgbm90IGJyaWRnZSBzdWNoIGFzIERTSSB0byBM VkRTCj4gYW5kIExWRFMgdG8gRFNJIGJyaWRnZSBkZXZpY2VzLCBhbmQgYWxzbyBpbWFnZSBlbmhh bmNlciBhbmQgaW1hZ2UgY29tcHJlc3Nvcgo+IGluIGNhc2Ugb2YgRXh5bm9zLgoKSSBkb24ndCB1 bmRlcnN0YW5kLCB3aHkgdGhlIE1JUEktRFNJIGJ1cyBkZXZpY2Ugd291bGQgYmUgYW4gZW5jb2Rl ciB0eXBlIGFuZApEU0kgdG8gTFZEUyBvciBNSVBJLURTSSB0byBIRE1JIHdvdWxkIGJlIGJyaWRn ZXMuIEZvciBleGFtcGxlLCB0aGUgZGV2aWNlIHRyZWUKZG9jdW1lbnRhdGlvbiBmb3IgdGhlIERT SU0gc3RhdGVzIHRoYXQgdGhlIERTSU0gcmVjZWl2ZXMgUkdCIHZpZGVvIGFzIGlucHV0CmFuZCBw cm9kdWNlcyBNSVBJLURTSSBhcyBvdXRwdXQuIFRodXMsIHRoZSBEU0lNIGlzIGJhc2ljYWxseSBh IHBhcmFsbGVsIFJHQiB0bwpNSVBJLURTSSBicmlkZ2UgYW5kIHRoZSBlbmNvZGVyIGlzIHRoZSBM Q0QgY29udHJvbGxlciB0aGF0IGVuY29kZXMgdGhlIHZpZGVvCmRhdGEgYXMgcGFyYWxsZWwgUkdC LgoKT24gdGhlIGkuTVg4TU0sIHRoZSBMQ0RJRiBpcyBhbHJlYWR5IHRoZSBlbmNvZGVyLiBPbiBF eHlub3MsIHRoZSBzZXJpZXMKaW1wbGVtZW50cyB0aGUgZW5jb2RlciBpbiB0aGUgcGxhdGZvcm0g Z2x1ZSwgYnV0IGluIHRoZSBlbmQgdGhlIGVuY29kZXIgY2FuCnByb2JhYmx5IGJlIG1vdmVkIHRv IHRoZSBERUNPTi4KCj4gV2h5IGRvIHlvdSB3YW50IHRvIGNvbnZlcnQgc3VjaCBNSVBJLURTSSBk cml2ZXIgdG8gYnJpZGdlIHR5cGUgb2YgZHJpdmVyPwo+IFNlZW1zIG5vdCBzZW5zaWJsZS4gVGhl IHJlYXNvbiB3b3VsZCBiZSBqdXN0IHRvIHNoYXJlIE1JUEktRFNJIHBoeSBkcml2ZXIKPiBmb3Ig RXh5bm9zIHdpdGggaS5NWDhNIE1pbmk/CgpZZXMsIHRoZSByZWFzb24gaXMgdGhhdCB0aGUgZHJp dmVyIHNob3VsZCBiZSBzaGFyZWQgYmV0d2VlbiBFeHlub3MgYW5kCmkuTVg4TU0uIEl0IGlzIHRo ZSBzYW1lIElQIGFuZCBJIGRvbid0IHNlZSBhIHJlYXNvbiB3aHkgd2Ugc2hvdWxkIGludHJvZHVj ZQphbm90aGVyIGRyaXZlciBmb3IgdGhlIHNhbWUgSVAgaWYgdGhlIGRyaXZlciB3b3JrcyBmb3Ig Ym90aCBTb0NzLgoKTWljaGFlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK