From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7DDE68994D for ; Tue, 10 Nov 2020 08:35:10 +0000 (UTC) Date: Tue, 10 Nov 2020 10:35:06 +0200 From: Petri Latvala Message-ID: <20201110083506.GX7444@platvala-desk.ger.corp.intel.com> References: <20200504073707.268608-1-arkadiusz.hiler@intel.com> <160494136881.21258.1784453412780097986@build.alporthouse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <160494136881.21258.1784453412780097986@build.alporthouse.com> Subject: Re: [igt-dev] [PATCH i-g-t 1/3] lib: Support multiple filters List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org List-ID: On Mon, Nov 09, 2020 at 05:02:48PM +0000, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2020-05-04 08:37:05) > > This patch brings back support for multiple filters that was in the > > original series by Zbyszek. > > How is this filtering meant to work for tests that try to open two > different devices? Shouldn't the igt_device_filter_count() take into > account whether the filter even matches the desired device? > Should all of the filters include all possible devices? If you use filters, and you have two different devices you want to use, the test should use drm_open_driver_another() and have filters for two devices, semicolon-separated. See kms_prime for a good example of the usage. -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev