From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B71DC388F7 for ; Tue, 10 Nov 2020 08:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4C11206B6 for ; Tue, 10 Nov 2020 08:46:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728297AbgKJIqF (ORCPT ); Tue, 10 Nov 2020 03:46:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728119AbgKJIqF (ORCPT ); Tue, 10 Nov 2020 03:46:05 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCB2DC0613CF for ; Tue, 10 Nov 2020 00:46:04 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcPHv-000491-8s; Tue, 10 Nov 2020 09:46:03 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kcPHt-0002WC-Lt; Tue, 10 Nov 2020 09:46:01 +0100 Date: Tue, 10 Nov 2020 09:46:01 +0100 From: Michael Tretter To: Adam Ford Cc: dri-devel , linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com, Bartlomiej Zolnierkiewicz , Neil Armstrong , sw0312.kim@samsung.com, Krzysztof Kozlowski , a.hajda@samsung.com, Laurent Pinchart , Sascha Hauer , sylvester.nawrocki@gmail.com Subject: Re: [PATCH v2 01/16] drm/encoder: remove obsolete documentation of bridge Message-ID: <20201110084601.GD13669@pengutronix.de> References: <20200911135413.3654800-1-m.tretter@pengutronix.de> <20200911135413.3654800-2-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:28:50 up 264 days, 15:59, 89 users, load average: 0.12, 0.17, 0.18 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-samsung-soc@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Sat, 07 Nov 2020 09:07:19 -0600, Adam Ford wrote: > On Fri, Sep 11, 2020 at 8:54 AM Michael Tretter > wrote: > > > > In commit 05193dc38197 ("drm/bridge: Make the bridge chain a > > double-linked list") the bridge has been removed and replaced by a > > private field. Remove the leftover documentation of the removed field. > > > > Signed-off-by: Michael Tretter > > Reviewed-by: Laurent Pinchart > > What is the status of this series? I know of at least one other patch > series depending on this. Sorry for that. I lately didn't have time to work on the series. There are two big open TODOs: - How should this bridge react if there is no out bridge available, yet? This series implements a static approach by returning EPROBE_DEFER from bridge_attach if there isn't a next bridge, connector or display. Andrezej suggested a dynamic approach which allows to attach this bridge without a next bridge and dynamically add further bridges/panels. The latter approach didn't work with the mxsfb driver, but I didn't have time to look into this. - The component framework stuff that allows to use the bridge with the Exynos driver should not go into the bridge driver, but stay in the platform part. Michael > > adam > > > --- > > v2: none > > --- > > include/drm/drm_encoder.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/include/drm/drm_encoder.h b/include/drm/drm_encoder.h > > index a60f5f1555ac..5dfa5f7a80a7 100644 > > --- a/include/drm/drm_encoder.h > > +++ b/include/drm/drm_encoder.h > > @@ -89,7 +89,6 @@ struct drm_encoder_funcs { > > * @head: list management > > * @base: base KMS object > > * @name: human readable name, can be overwritten by the driver > > - * @bridge: bridge associated to the encoder > > * @funcs: control functions > > * @helper_private: mid-layer private data > > * > > -- > > 2.20.1 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8E8FC5517A for ; Tue, 10 Nov 2020 08:46:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DF09206B6 for ; Tue, 10 Nov 2020 08:46:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DF09206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 74024897E9; Tue, 10 Nov 2020 08:46:05 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA11F897E9 for ; Tue, 10 Nov 2020 08:46:04 +0000 (UTC) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcPHv-000491-8s; Tue, 10 Nov 2020 09:46:03 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kcPHt-0002WC-Lt; Tue, 10 Nov 2020 09:46:01 +0100 Date: Tue, 10 Nov 2020 09:46:01 +0100 From: Michael Tretter To: Adam Ford Subject: Re: [PATCH v2 01/16] drm/encoder: remove obsolete documentation of bridge Message-ID: <20201110084601.GD13669@pengutronix.de> References: <20200911135413.3654800-1-m.tretter@pengutronix.de> <20200911135413.3654800-2-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:28:50 up 264 days, 15:59, 89 users, load average: 0.12, 0.17, 0.18 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com, Neil Armstrong , Bartlomiej Zolnierkiewicz , sw0312.kim@samsung.com, dri-devel , a.hajda@samsung.com, Krzysztof Kozlowski , Sascha Hauer , sylvester.nawrocki@gmail.com, Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, 07 Nov 2020 09:07:19 -0600, Adam Ford wrote: > On Fri, Sep 11, 2020 at 8:54 AM Michael Tretter > wrote: > > > > In commit 05193dc38197 ("drm/bridge: Make the bridge chain a > > double-linked list") the bridge has been removed and replaced by a > > private field. Remove the leftover documentation of the removed field. > > > > Signed-off-by: Michael Tretter > > Reviewed-by: Laurent Pinchart > > What is the status of this series? I know of at least one other patch > series depending on this. Sorry for that. I lately didn't have time to work on the series. There are two big open TODOs: - How should this bridge react if there is no out bridge available, yet? This series implements a static approach by returning EPROBE_DEFER from bridge_attach if there isn't a next bridge, connector or display. Andrezej suggested a dynamic approach which allows to attach this bridge without a next bridge and dynamically add further bridges/panels. The latter approach didn't work with the mxsfb driver, but I didn't have time to look into this. - The component framework stuff that allows to use the bridge with the Exynos driver should not go into the bridge driver, but stay in the platform part. Michael > > adam > > > --- > > v2: none > > --- > > include/drm/drm_encoder.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/include/drm/drm_encoder.h b/include/drm/drm_encoder.h > > index a60f5f1555ac..5dfa5f7a80a7 100644 > > --- a/include/drm/drm_encoder.h > > +++ b/include/drm/drm_encoder.h > > @@ -89,7 +89,6 @@ struct drm_encoder_funcs { > > * @head: list management > > * @base: base KMS object > > * @name: human readable name, can be overwritten by the driver > > - * @bridge: bridge associated to the encoder > > * @funcs: control functions > > * @helper_private: mid-layer private data > > * > > -- > > 2.20.1 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel