From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1321206955511215532==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] of: property: fix returnvar.cocci warnings Date: Tue, 10 Nov 2020 17:45:30 +0800 Message-ID: <20201110094530.GA29367@22c2fd75c0d2> In-Reply-To: <202011101757.YlgqZxJL-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============1321206955511215532== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org In-Reply-To: <20201104232356.4038506-16-saravanak@google.com> References: <20201104232356.4038506-16-saravanak@google.com> TO: Saravana Kannan TO: "Rafael J. Wysocki" TO: Len Brown TO: "Greg Kroah-Hartman" TO: Ard Biesheuvel TO: Rob Herring TO: Frank Rowand TO: Marc Zyngier TO: Thomas Gleixner CC: Saravana Kannan CC: Tomi Valkeinen From: kernel test robot drivers/of/property.c:1331:5-8: Unneeded variable: "ret". Return "0" on lin= e 1343 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Saravana Kannan Reported-by: kernel test robot Signed-off-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/Saravana-Kannan/Refactor-f= w_devlink-to-significantly-improve-boot-time/20201105-072804 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.= git 3cea11cd5e3b00d91caf0b4730194039b45c5891 :::::: branch date: 5 days ago :::::: commit date: 5 days ago Please take the patch only if it's a positive warning. Thanks! property.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1328,7 +1328,6 @@ static int of_link_property(struct devic const struct supplier_bindings *s =3D of_supplier_bindings; unsigned int i =3D 0; bool matched =3D false; - int ret =3D 0; = /* Do not stop at first failed link, link all available suppliers. */ while (!matched && s->parse_prop) { @@ -1340,7 +1339,7 @@ static int of_link_property(struct devic } s++; } - return ret; + return 0; } = static int of_fwnode_add_links(struct fwnode_handle *fwnode, --===============1321206955511215532==--