All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Parav Pandit <parav@nvidia.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
	Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net] devlink: Avoid overwriting port attributes of registered port
Date: Tue, 10 Nov 2020 14:07:09 -0800	[thread overview]
Message-ID: <20201110140709.62cf1249@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201110185258.30576-1-parav@nvidia.com>

On Tue, 10 Nov 2020 20:52:58 +0200 Parav Pandit wrote:
> Cited commit in fixes tag overwrites the port attributes for the
> registered port.

Seems like you forgot the fixes tag you're referring to.

> Avoid such error by checking registered flag before setting attributes.
> 
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>


  reply	other threads:[~2020-11-10 22:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 18:52 [PATCH net] devlink: Avoid overwriting port attributes of registered port Parav Pandit
2020-11-10 22:07 ` Jakub Kicinski [this message]
2020-11-11  3:31   ` Parav Pandit
2020-11-11  3:47 ` [PATCH net RESEND] " Parav Pandit
2020-11-12 16:09   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201110140709.62cf1249@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=jiri@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=parav@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.