From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEDB0C5517A for ; Tue, 10 Nov 2020 16:06:02 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5A3B62076E for ; Tue, 10 Nov 2020 16:06:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A3B62076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A39CB66DB; Tue, 10 Nov 2020 17:04:39 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2C07E5AB9 for ; Tue, 10 Nov 2020 17:04:36 +0100 (CET) IronPort-SDR: 055mZ1EHoEqjm0nBQ1bJiF3o9FIKeYehxs2l6olaGGfs9OW7dHaNsgiV+IvGcqvyT3g882CHD0 Do9aUPTHVlkQ== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="169213254" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="169213254" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 08:04:32 -0800 IronPort-SDR: b3geq18xn8839FFrvRQajwCfjPlbOlTVZhYi+t8wSait/VBQpdbBlxUd/21IYm93JBsiRktimv HRaa6dB0NpIA== X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473476254" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.241.186]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Nov 2020 08:04:30 -0800 Date: Tue, 10 Nov 2020 16:04:27 +0000 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20201110160427.GK1641@bricha3-MOBL.ger.corp.intel.com> References: <20201110151219.4893-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110151219.4893-1-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH 00/10] Examples compilation fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 10, 2020 at 04:12:09PM +0100, David Marchand wrote: > I stepped right into Bruce trap [1] and tested all possible examples. > The result is this series. > > 1: https://patchwork.dpdk.org/patch/82361/ > > -- > David Marchand > > David Marchand (10): > examples/fips_validation: fix build with pkg-config > examples/ipsec-gw: fix build with pkg-config > examples/kni: fix build with pkg-config > examples/l2fwd-crypto: fix build with pkg-config > examples/l3fwd-graph: fix static build > examples/ntb: fix clean target > examples/vhost_blk: fix build with pkg-config > examples/rxtx_callbacks: fix build with pkg-config > devtools: compile all examples with pkg-config > examples: restore trace point > Thanks for the work David, this is great. I'll see about doing more cleanup on the skipped list, particularly how we install the examples in the "share" folder, but until then this is great progress. Series-acked-by: Bruce Richardson