From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6F2EC56201 for ; Wed, 11 Nov 2020 04:37:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A074221FB for ; Wed, 11 Nov 2020 04:37:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xlTOkurB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725860AbgKKEhI (ORCPT ); Tue, 10 Nov 2020 23:37:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgKKEhH (ORCPT ); Tue, 10 Nov 2020 23:37:07 -0500 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C737C0613D4 for ; Tue, 10 Nov 2020 20:37:07 -0800 (PST) Received: by mail-ot1-x341.google.com with SMTP id n15so977904otl.8 for ; Tue, 10 Nov 2020 20:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wtRRfw0GGRgIk6DDEU0mXolpp59u7naaEBZyd5qGF2U=; b=xlTOkurB5YeEXxXJYwdzWWnWGVdRKFL+/QSqpRjK7kqPhjPRjtAdgOuOy7y0ajwdbY q2pr8/fk7xycu/XtHoSYrXEwhaqH+VxSeRVmDpcVws/pU5YWRHVuUOomnOFtopHO8XAi crw9vKedvw7QXx7NqtN12QnjtxoVu/n7yv6oPg6R6Fr1vuEJNwdRLu4M5dE2rTyrwt91 uN0eAHLJb/HaSHheYhpZ3wP5WEx9Xh1o3yt7HoqYBtHKB9pIUJzP/BEdw7pWqi/5nbuc njil6Z6itA/BjYomU2YMYtcQlZorvkU2BvOeldM0Ru5KkZggzn97iOKTMx3Y5A8wZbCy BUaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wtRRfw0GGRgIk6DDEU0mXolpp59u7naaEBZyd5qGF2U=; b=fpnj+TcVXSd0AZQFa6MywKeKqgDlPaUs926256w/ltFQNjEljGaLED9rqp0PPyPUri 8NPfgKPze7AQd2xfnaAIQG5EY0uCGZUrnw5JD0klSqdm454N59c6NlsXyrnLjqxpFmaC 1nneJVswmhn7isSV+OoaE1MR5UWNM1g+lDfpt4OdFXSJVn/SaJQyr/l6lukTjoiNwDlM KG9crn5U4IgF03EboQOU4PPPQD4c7uXyTpfL/fWZbLaJlIjSzTxE6gaGVajn709H4pmn 8oGK6J+8Mxu61sdEB4dAsAjJnOVXs+2eWTcGfXYXHvJcSvK7rqQP0X0uwZapPdm/ZOo9 cdIQ== X-Gm-Message-State: AOAM530MIatbupzMoZ7eRThgIkfWXYG5bXYV9jfq0o6FxOVGhdH5Dojk zhVwcmuZdhH87svd69gcCGVpOw== X-Google-Smtp-Source: ABdhPJwiAIhYvzEwIJux++i3YzohINChUujNLTtyHYZqqNmnQb6ngqeDoBJonNmEpksoYLzQCmJSEw== X-Received: by 2002:a9d:17c5:: with SMTP id j63mr17519584otj.9.1605069426410; Tue, 10 Nov 2020 20:37:06 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id e63sm4819oib.48.2020.11.10.20.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 20:37:05 -0800 (PST) Date: Tue, 10 Nov 2020 22:37:03 -0600 From: Bjorn Andersson To: Georgi Djakov Cc: linux-pm@vger.kernel.org, mdtipton@codeaurora.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, akashast@codeaurora.org Subject: Re: [PATCH 2/3] interconnect: qcom: sdm845: Add the missing nodes for QUP Message-ID: <20201111043703.GA173948@builder.lan> References: <20201105135211.7160-1-georgi.djakov@linaro.org> <20201105135211.7160-2-georgi.djakov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201105135211.7160-2-georgi.djakov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 05 Nov 07:52 CST 2020, Georgi Djakov wrote: > The QUP nodes are currently defined just as entries in the topology, > but they are not referenced by any of the NoCs. Let's fix this and > "attach" them to their NoCs, so that the QUP drivers are able to use > them as path endpoints and scale their bandwidth. > > This is based on the information from the downstream msm-4.9 kernel. > > Signed-off-by: Georgi Djakov Reviewed-by: Bjorn Andersson Georgi, would you mind if I take the series through my tree, to avoid conflicts in sdm845.dtsi? Regards, Bjorn > --- > drivers/interconnect/qcom/sdm845.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c > index 5304aea3b058..366870150cbd 100644 > --- a/drivers/interconnect/qcom/sdm845.c > +++ b/drivers/interconnect/qcom/sdm845.c > @@ -177,6 +177,7 @@ DEFINE_QBCM(bcm_sn15, "SN15", false, &qnm_memnoc); > > static struct qcom_icc_bcm *aggre1_noc_bcms[] = { > &bcm_sn9, > + &bcm_qup0, > }; > > static struct qcom_icc_node *aggre1_noc_nodes[] = { > @@ -190,6 +191,7 @@ static struct qcom_icc_node *aggre1_noc_nodes[] = { > [SLAVE_A1NOC_SNOC] = &qns_a1noc_snoc, > [SLAVE_SERVICE_A1NOC] = &srvc_aggre1_noc, > [SLAVE_ANOC_PCIE_A1NOC_SNOC] = &qns_pcie_a1noc_snoc, > + [MASTER_QUP_1] = &qhm_qup1, > }; > > static const struct qcom_icc_desc sdm845_aggre1_noc = { > @@ -218,6 +220,7 @@ static struct qcom_icc_node *aggre2_noc_nodes[] = { > [SLAVE_A2NOC_SNOC] = &qns_a2noc_snoc, > [SLAVE_ANOC_PCIE_SNOC] = &qns_pcie_snoc, > [SLAVE_SERVICE_A2NOC] = &srvc_aggre2_noc, > + [MASTER_QUP_2] = &qhm_qup2, > }; > > static const struct qcom_icc_desc sdm845_aggre2_noc = {