From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC69C388F9 for ; Wed, 11 Nov 2020 05:20:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 225F720709 for ; Wed, 11 Nov 2020 05:20:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lRBauYDa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725895AbgKKFUm (ORCPT ); Wed, 11 Nov 2020 00:20:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725859AbgKKFUm (ORCPT ); Wed, 11 Nov 2020 00:20:42 -0500 Received: from mail-oo1-xc44.google.com (mail-oo1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EC50C0613D4 for ; Tue, 10 Nov 2020 21:20:42 -0800 (PST) Received: by mail-oo1-xc44.google.com with SMTP id g4so156670oom.9 for ; Tue, 10 Nov 2020 21:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+8JvIuVhwuPNGMkVQ4guxsEUL9YFtE5AZrTL23JMuJU=; b=lRBauYDaR4Ik4GXYuf38bavNI7EWI2gLFj8p1qDEuI2tZpRsYCOkIQ2q0Pl0xTnsew d1vfUbekQ5ganCOMx/LloZec9K58Poc0pSV3aOgPS2jq3C/pfEdjzruV1ZPV2KnVuiEI k+vVNdReFibS7Q24AkT9KD21JuW5te1S6lI0OLLvO6NjIIIIXzHReqVbWFEoxTqAl4fu wzgA8uvR74Ue1Rw4iBsm7CB9FnVBSacLgGTszR3mBVFGIt8oeTvkS1Cz2ZqhsSzb6LzA nVLKKwFfSNirps9FIDBOI8k+N3hRoYNF/idwgZy1+FdmuwjtdZ5syjZ1Y8LrET1+ve7J trzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+8JvIuVhwuPNGMkVQ4guxsEUL9YFtE5AZrTL23JMuJU=; b=jejS7VnEhYLFN1FK14X5v7ilslsrgylco0JgrtZKgEp2R/3mxY52RRXbb7kr9/Obgg bJxdJcVBsYZzH7oubXUFMhnIlTsLmD+RF7S/tWkMiZP13dTUFdQ7KCmcLXJGC1q5/8wX 1IuPpG7kCnpiibFz/5soETLGFmrBQ3pAH7104BDu8h+1OAR1jNGyn1pfpXoQK3pfM8Ds Qm2AlyrMeA+a53BIN8Da9tBPamwNvy26opiceMmdLCOZiUOkyLnI8gFzCvz23Yf2wlDp eA5nZbA+ivKzBVUpqLnm49ZbpFu2zizGPvQ3bVbRkPXSgu9/XAcY3ICvTYnHvADKsLrF 0UPA== X-Gm-Message-State: AOAM532M8eLEZlhX2DEZMQS2EWleZ+tFC+9tcbKdxHQWE4Za5GaUzqHW mtjEgXH8P+3s/sAWYphlrYfVSA== X-Google-Smtp-Source: ABdhPJzHvWdZyv3gQOh+mqqPrQU15IMjBhkr35b3v2Dgop+sJwQ0J9xwxHW1eXvWMkEB3YNl6F/jag== X-Received: by 2002:a4a:9607:: with SMTP id q7mr16079277ooi.79.1605072041371; Tue, 10 Nov 2020 21:20:41 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id k27sm319019ool.7.2020.11.10.21.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 21:20:40 -0800 (PST) Date: Tue, 10 Nov 2020 23:20:38 -0600 From: Bjorn Andersson To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Gross , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 19/25] soc: qcom: smp2p: Remove unused struct attribute provide another Message-ID: <20201111052038.GG173948@builder.lan> References: <20201103152838.1290217-1-lee.jones@linaro.org> <20201103152838.1290217-20-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201103152838.1290217-20-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 03 Nov 09:28 CST 2020, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/soc/qcom/smp2p.c:74: warning: Function parameter or member 'flags' not described in 'smp2p_smem_item' > drivers/soc/qcom/smp2p.c:149: warning: Function parameter or member 'out' not described in 'qcom_smp2p' > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/soc/qcom/smp2p.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > index a9709aae54abb..43df63419c327 100644 > --- a/drivers/soc/qcom/smp2p.c > +++ b/drivers/soc/qcom/smp2p.c > @@ -52,7 +52,6 @@ > * @remote_pid: processor id of receiving end > * @total_entries: number of entries - always SMP2P_MAX_ENTRY > * @valid_entries: number of allocated entries > - * @flags: > * @entries: individual communication entries > * @name: name of the entry > * @value: content of the entry > @@ -65,7 +64,6 @@ struct smp2p_smem_item { > u16 remote_pid; > u16 total_entries; > u16 valid_entries; > - u32 flags; This struct describes the data shared between processors in the SoC and as such these 32 bits are significant. I believe we have an incoming patch that adds handling of some flag, so let's document it properly at that time. I've applied the second half of the patch for now. Regards, Bjorn > > struct { > u8 name[SMP2P_MAX_ENTRY_NAME]; > @@ -112,6 +110,7 @@ struct smp2p_entry { > * struct qcom_smp2p - device driver context > * @dev: device driver handle > * @in: pointer to the inbound smem item > + * @out: pointer to the outbound smem item > * @smem_items: ids of the two smem items > * @valid_entries: already scanned inbound entries > * @local_pid: processor id of the inbound edge > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C73C388F9 for ; Wed, 11 Nov 2020 05:21:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDC2B20709 for ; Wed, 11 Nov 2020 05:21:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h3QjkM5L"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lRBauYDa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDC2B20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vyRblRR54sfxtA6YsmZDHdUVJxv0DLR2wrN3D02qkuA=; b=h3QjkM5Lrpw6Y9kiGTfBF3znI MT/es+NbTiw7T/VoQPpHVqQlD7iOMlnMrVfgj6l9tYiePNybYOqrT2lshUU6RjXibgrDAdOxFNn0v 86kEeX22hTfGrOz0NYxy5VNjKI8iud7L+Whg3bMiU2fVjxOKsVUMPigmwmDqH8un7ZYJG0bZeJ669 CQjsCjWsF+lxxHBU/cAVTy+ElGU5ZVrZiLJR9mqk16YSBtHlWAyYmwNuzaM1TH4b7V1dJHvmeIj8k a1dcMgzIcmZ7A4SAn/YqPM18tFEF5YYdJA241DZhnZrmRCXqc1MI70uDHrXP3up1UcDMx13oXPy+9 UYZSc5W0A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kciYp-0004iM-GV; Wed, 11 Nov 2020 05:20:47 +0000 Received: from mail-oo1-xc44.google.com ([2607:f8b0:4864:20::c44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kciYl-0004hS-GV for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 05:20:45 +0000 Received: by mail-oo1-xc44.google.com with SMTP id t10so161388oon.4 for ; Tue, 10 Nov 2020 21:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+8JvIuVhwuPNGMkVQ4guxsEUL9YFtE5AZrTL23JMuJU=; b=lRBauYDaR4Ik4GXYuf38bavNI7EWI2gLFj8p1qDEuI2tZpRsYCOkIQ2q0Pl0xTnsew d1vfUbekQ5ganCOMx/LloZec9K58Poc0pSV3aOgPS2jq3C/pfEdjzruV1ZPV2KnVuiEI k+vVNdReFibS7Q24AkT9KD21JuW5te1S6lI0OLLvO6NjIIIIXzHReqVbWFEoxTqAl4fu wzgA8uvR74Ue1Rw4iBsm7CB9FnVBSacLgGTszR3mBVFGIt8oeTvkS1Cz2ZqhsSzb6LzA nVLKKwFfSNirps9FIDBOI8k+N3hRoYNF/idwgZy1+FdmuwjtdZ5syjZ1Y8LrET1+ve7J trzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+8JvIuVhwuPNGMkVQ4guxsEUL9YFtE5AZrTL23JMuJU=; b=t2fAY+WJvEZxh0Eu6Pt/549VD+/jLNK4tSz4kQubHoRfW3YAiffzY15QWv4laxiah+ tp6eorJh2r4oNOB4PIHEgsYaea/u8RFuEOZbaLtwP5ew++8GDQdDOipzn1dtMWlr/rbS 42/wz/E3cJDYH0vXvG//AXhWfyiPFtXOPo0/q65MIRkV8byzZXIGzYa3C2pio2uRwBDu LggvO17FoVwoqWKY+nrkKtO584JibPrVmvoGXq0jnSR/hHUKBVZiCyYqF/hpa+jETPVO jikv2ZIJpx6nekLaYduUCDbo9myZA3zEvRSu4KCGRBH/OjmaHAV+9KYHQ4OQB/GZnntE dscQ== X-Gm-Message-State: AOAM531k9Wi/ZnBJqyq2dpZxQtHMqP/MuwbGsH5MCcUd/9fA21lxBvlY HJuFWppPOdXh7E20UrgNne6vAA== X-Google-Smtp-Source: ABdhPJzHvWdZyv3gQOh+mqqPrQU15IMjBhkr35b3v2Dgop+sJwQ0J9xwxHW1eXvWMkEB3YNl6F/jag== X-Received: by 2002:a4a:9607:: with SMTP id q7mr16079277ooi.79.1605072041371; Tue, 10 Nov 2020 21:20:41 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id k27sm319019ool.7.2020.11.10.21.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 21:20:40 -0800 (PST) Date: Tue, 10 Nov 2020 23:20:38 -0600 From: Bjorn Andersson To: Lee Jones Subject: Re: [PATCH 19/25] soc: qcom: smp2p: Remove unused struct attribute provide another Message-ID: <20201111052038.GG173948@builder.lan> References: <20201103152838.1290217-1-lee.jones@linaro.org> <20201103152838.1290217-20-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201103152838.1290217-20-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_002043_885305_2694C47D X-CRM114-Status: GOOD ( 19.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, Andy Gross , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 03 Nov 09:28 CST 2020, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/soc/qcom/smp2p.c:74: warning: Function parameter or member 'flags' not described in 'smp2p_smem_item' > drivers/soc/qcom/smp2p.c:149: warning: Function parameter or member 'out' not described in 'qcom_smp2p' > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/soc/qcom/smp2p.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > index a9709aae54abb..43df63419c327 100644 > --- a/drivers/soc/qcom/smp2p.c > +++ b/drivers/soc/qcom/smp2p.c > @@ -52,7 +52,6 @@ > * @remote_pid: processor id of receiving end > * @total_entries: number of entries - always SMP2P_MAX_ENTRY > * @valid_entries: number of allocated entries > - * @flags: > * @entries: individual communication entries > * @name: name of the entry > * @value: content of the entry > @@ -65,7 +64,6 @@ struct smp2p_smem_item { > u16 remote_pid; > u16 total_entries; > u16 valid_entries; > - u32 flags; This struct describes the data shared between processors in the SoC and as such these 32 bits are significant. I believe we have an incoming patch that adds handling of some flag, so let's document it properly at that time. I've applied the second half of the patch for now. Regards, Bjorn > > struct { > u8 name[SMP2P_MAX_ENTRY_NAME]; > @@ -112,6 +110,7 @@ struct smp2p_entry { > * struct qcom_smp2p - device driver context > * @dev: device driver handle > * @in: pointer to the inbound smem item > + * @out: pointer to the outbound smem item > * @smem_items: ids of the two smem items > * @valid_entries: already scanned inbound entries > * @local_pid: processor id of the inbound edge > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel