All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Dan Murphy <dmurphy@ti.com>,
	linux-leds@vger.kernel.org, Sakari Ailus <sakari.ailus@iki.fi>,
	newbytee@protonmail.com, Stephan Gerhold <stephan@gerhold.net>
Subject: Re: [PATCH 2/2 v3] leds: rt8515: Add Richtek RT8515 LED driver
Date: Wed, 11 Nov 2020 08:59:59 +0100	[thread overview]
Message-ID: <20201111075958.GA16683@amd> (raw)
In-Reply-To: <20201111011417.2275501-2-linus.walleij@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

Hi!

> This adds a driver for the Richtek RT8515 dual channel
> torch/flash white LED driver.
> 
> This LED driver is found in some mobile phones from
> Samsung such as the GT-S7710 and GT-I8190.

Cc: phone-devel@vger.

>  drivers/leds/Kconfig       |  11 ++
>  drivers/leds/Makefile      |   1 +
>  drivers/leds/leds-rt8515.c | 303 +++++++++++++++++++++++++++++++++++++

Let's put this into drivers/leds/flash. You may need to create it.

> +// SPDX-License-Identifier: GPL-2.0-only

GPL-2+ would be nicer if you can.

> +struct rt8515 {
> +	struct led_classdev_flash fled;
> +	struct v4l2_flash *v4l2_flash;
> +	struct mutex lock;
> +	struct regulator *reg;
> +	struct gpio_desc *ent;
> +	struct gpio_desc *enf;

-> enable_torch or at least en_torch / en_flash?

Otherwise it looks good.

Best regards,
							Pavel

-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2020-11-11  8:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  1:14 [PATCH 1/2 v3] dt-bindings: leds: Add DT binding for Richtek RT8515 Linus Walleij
2020-11-11  1:14 ` [PATCH 2/2 v3] leds: rt8515: Add Richtek RT8515 LED driver Linus Walleij
2020-11-11  7:59   ` Pavel Machek [this message]
2020-11-11 11:38   ` Sakari Ailus
2020-11-11 16:34     ` Linus Walleij
2020-11-11 16:55       ` Sakari Ailus
2020-11-11 22:07         ` Linus Walleij
2020-11-12 10:24           ` Sakari Ailus
2020-11-25 19:35           ` Pavel Machek
2020-11-11 11:04 ` [PATCH 1/2 v3] dt-bindings: leds: Add DT binding for Richtek RT8515 Sakari Ailus
2020-11-11 13:44   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201111075958.GA16683@amd \
    --to=pavel@ucw.cz \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=newbytee@protonmail.com \
    --cc=sakari.ailus@iki.fi \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.