All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
	Wang Qing <wangqing@vivo.com>,
	"David S. Miller" <davem@davemloft.net>,
	Samuel Zou <zou_wei@huawei.com>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR
Date: Wed, 11 Nov 2020 08:00:27 -0800	[thread overview]
Message-ID: <20201111080027.7830f756@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201111135558.GB4928@hoboy.vegasvil.org>

On Wed, 11 Nov 2020 05:55:58 -0800 Richard Cochran wrote:
> On Wed, Nov 11, 2020 at 03:24:33PM +0200, Grygorii Strashko wrote:
> > 
> > Following Richard's comments v1 of the patch has to be applied [1].
> > I've also added my Reviewed-by there.
> > 
> > [1] https://lore.kernel.org/patchwork/patch/1334067/  
> 
> +1
> 
> Jakub, can you please take the original v1 of this patch?

I don't think v1 builds cleanly folks (not 100% sure, cpts is not
compiled on x86):

		ret = cpts->ptp_clock ? cpts->ptp_clock : (-ENODEV);

ptp_clock is a pointer, ret is an integer, right?

Grygorii, would you mind sending a correct patch in so Wang Qing can
see how it's done? I've been asking for a fixes tag multiple times
already :(

  reply	other threads:[~2020-11-11 16:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  9:24 [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR Wang Qing
2020-11-11 12:32 ` Richard Cochran
2020-11-11 13:24   ` Grygorii Strashko
2020-11-11 13:55     ` Richard Cochran
2020-11-11 16:00       ` Jakub Kicinski [this message]
2020-11-12  1:15         ` 王擎
2020-11-12  1:32           ` Jakub Kicinski
2020-11-12  2:48             ` 王擎
2020-11-12  4:23               ` Jakub Kicinski
2020-11-12  8:25           ` Arnd Bergmann
2020-11-12 10:05             ` Grygorii Strashko
2020-11-12 18:14               ` Richard Cochran
2020-11-12 18:19             ` Richard Cochran
2020-11-12 21:21               ` Arnd Bergmann
2020-11-12 23:27                 ` Richard Cochran
2020-11-13 16:21                   ` Arnd Bergmann
2020-11-14 15:14                     ` Richard Cochran
2020-11-14 21:16                       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201111080027.7830f756@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=grygorii.strashko@ti.com \
    --cc=ivan.khoronzhuk@linaro.org \
    --cc=kurt@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=wangqing@vivo.com \
    --cc=zou_wei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.