From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 00660C388F9
	for <linux-kernel@archiver.kernel.org>; Wed, 11 Nov 2020 16:00:37 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 824EA2074B
	for <linux-kernel@archiver.kernel.org>; Wed, 11 Nov 2020 16:00:36 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WQWostec"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727589AbgKKQAf (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 11 Nov 2020 11:00:35 -0500
Received: from mail.kernel.org ([198.145.29.99]:46610 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726274AbgKKQAa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Nov 2020 11:00:30 -0500
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id CEF8820709;
        Wed, 11 Nov 2020 16:00:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1605110429;
        bh=Dv9BJlsfpFVl0Xexy5UTw33fgnjDZpEORoMIQwG5VrQ=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=WQWostecFHGQH3YBVlqic8fIdISsfyNjbN6bue3q4tBnspH7fWstqk+t7gLRcU+Y2
         YuRZ4uHLKndAM5qSykd+DXjRwXRLR6KrDKLkDDA8j55EANVJzCk7Oc6Ydvf43jjWNA
         1f8ZBm8YAhtMusSpZsc9clZE1ZwjoUpfVlKjNeJw=
Date:   Wed, 11 Nov 2020 08:00:27 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Richard Cochran <richardcochran@gmail.com>
Cc:     Grygorii Strashko <grygorii.strashko@ti.com>,
        Wang Qing <wangqing@vivo.com>,
        "David S. Miller" <davem@davemloft.net>,
        Samuel Zou <zou_wei@huawei.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock
 is ERROR
Message-ID: <20201111080027.7830f756@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201111135558.GB4928@hoboy.vegasvil.org>
References: <1605086686-5140-1-git-send-email-wangqing@vivo.com>
        <20201111123224.GB29159@hoboy.vegasvil.org>
        <cd2aa8a1-183c-fb15-0a74-07852afb0cb8@ti.com>
        <20201111135558.GB4928@hoboy.vegasvil.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 11 Nov 2020 05:55:58 -0800 Richard Cochran wrote:
> On Wed, Nov 11, 2020 at 03:24:33PM +0200, Grygorii Strashko wrote:
> > 
> > Following Richard's comments v1 of the patch has to be applied [1].
> > I've also added my Reviewed-by there.
> > 
> > [1] https://lore.kernel.org/patchwork/patch/1334067/  
> 
> +1
> 
> Jakub, can you please take the original v1 of this patch?

I don't think v1 builds cleanly folks (not 100% sure, cpts is not
compiled on x86):

		ret = cpts->ptp_clock ? cpts->ptp_clock : (-ENODEV);

ptp_clock is a pointer, ret is an integer, right?

Grygorii, would you mind sending a correct patch in so Wang Qing can
see how it's done? I've been asking for a fixes tag multiple times
already :(