* [PATCH] f2fs-tools: skipped to end on error syntax error
@ 2020-11-11 9:40 ` Robin Hsu
0 siblings, 0 replies; 3+ messages in thread
From: Robin Hsu @ 2020-11-11 9:40 UTC (permalink / raw)
To: linux-f2fs-devel, jaegeuk, chao; +Cc: linux-kernel, Robin Hsu
From: Robin Hsu <robinhsu@google.com>
When error were found, we won't need to do any initialization but
just quit.
Signed-off-by: Robin Hsu <robinhsu@google.com>
---
fsck/main.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/fsck/main.c b/fsck/main.c
index 32559f1..e70048b 100644
--- a/fsck/main.c
+++ b/fsck/main.c
@@ -597,20 +597,22 @@ void f2fs_parse_options(int argc, char *argv[])
}
}
- add_default_options();
+ if (err == NOERROR) {
+ add_default_options();
- if (optind >= argc) {
- MSG(0, "\tError: Device not specified\n");
- error_out(prog);
- }
+ if (optind >= argc) {
+ MSG(0, "\tError: Device not specified\n");
+ error_out(prog);
+ }
- c.devices[0].path = strdup(argv[optind]);
- if (argc > (optind + 1)) {
- c.dbg_lv = 0;
- err = EUNKNOWN_ARG;
+ c.devices[0].path = strdup(argv[optind]);
+ if (argc > (optind + 1)) {
+ c.dbg_lv = 0;
+ err = EUNKNOWN_ARG;
+ }
+ if (err == NOERROR)
+ return;
}
- if (err == NOERROR)
- return;
/* print out error */
switch (err) {
--
2.29.2.222.g5d2a92d10f8-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [f2fs-dev] [PATCH] f2fs-tools: skipped to end on error syntax error
@ 2020-11-11 9:40 ` Robin Hsu
0 siblings, 0 replies; 3+ messages in thread
From: Robin Hsu @ 2020-11-11 9:40 UTC (permalink / raw)
To: linux-f2fs-devel, jaegeuk, chao; +Cc: linux-kernel
From: Robin Hsu <robinhsu@google.com>
When error were found, we won't need to do any initialization but
just quit.
Signed-off-by: Robin Hsu <robinhsu@google.com>
---
fsck/main.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/fsck/main.c b/fsck/main.c
index 32559f1..e70048b 100644
--- a/fsck/main.c
+++ b/fsck/main.c
@@ -597,20 +597,22 @@ void f2fs_parse_options(int argc, char *argv[])
}
}
- add_default_options();
+ if (err == NOERROR) {
+ add_default_options();
- if (optind >= argc) {
- MSG(0, "\tError: Device not specified\n");
- error_out(prog);
- }
+ if (optind >= argc) {
+ MSG(0, "\tError: Device not specified\n");
+ error_out(prog);
+ }
- c.devices[0].path = strdup(argv[optind]);
- if (argc > (optind + 1)) {
- c.dbg_lv = 0;
- err = EUNKNOWN_ARG;
+ c.devices[0].path = strdup(argv[optind]);
+ if (argc > (optind + 1)) {
+ c.dbg_lv = 0;
+ err = EUNKNOWN_ARG;
+ }
+ if (err == NOERROR)
+ return;
}
- if (err == NOERROR)
- return;
/* print out error */
switch (err) {
--
2.29.2.222.g5d2a92d10f8-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] f2fs-tools: skipped to end on error syntax error
@ 2020-11-10 8:10 Robin Hsu
0 siblings, 0 replies; 3+ messages in thread
From: Robin Hsu @ 2020-11-10 8:10 UTC (permalink / raw)
To: linux-f2fs-devel, jaegeuk, chao; +Cc: linux-kernel, Robin Hsu
When error were found, we won't need to do any initialization but
just quit.
Signed-off-by: Robin Hsu <robinhsu@google.com>
---
fsck/main.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/fsck/main.c b/fsck/main.c
index 32559f1..e70048b 100644
--- a/fsck/main.c
+++ b/fsck/main.c
@@ -597,20 +597,22 @@ void f2fs_parse_options(int argc, char *argv[])
}
}
- add_default_options();
+ if (err == NOERROR) {
+ add_default_options();
- if (optind >= argc) {
- MSG(0, "\tError: Device not specified\n");
- error_out(prog);
- }
+ if (optind >= argc) {
+ MSG(0, "\tError: Device not specified\n");
+ error_out(prog);
+ }
- c.devices[0].path = strdup(argv[optind]);
- if (argc > (optind + 1)) {
- c.dbg_lv = 0;
- err = EUNKNOWN_ARG;
+ c.devices[0].path = strdup(argv[optind]);
+ if (argc > (optind + 1)) {
+ c.dbg_lv = 0;
+ err = EUNKNOWN_ARG;
+ }
+ if (err == NOERROR)
+ return;
}
- if (err == NOERROR)
- return;
/* print out error */
switch (err) {
--
2.29.2.222.g5d2a92d10f8-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-11 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11 9:40 [PATCH] f2fs-tools: skipped to end on error syntax error Robin Hsu
2020-11-11 9:40 ` [f2fs-dev] " Robin Hsu
-- strict thread matches above, loose matches on Subject: below --
2020-11-10 8:10 Robin Hsu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.