From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 2/3] vhost-user-blk-server: depend on CONFIG_VHOST_USER
Date: Wed, 11 Nov 2020 14:16:36 +0000 [thread overview]
Message-ID: <20201111141636.GA1398106@stefanha-x1.localdomain> (raw)
In-Reply-To: <f04f74e4-ab6c-6c06-d4a9-cfa578bb16e0@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
On Wed, Nov 11, 2020 at 10:25:22AM +0100, Philippe Mathieu-Daudé wrote:
> On 11/10/20 6:11 PM, Stefan Hajnoczi wrote:
> > I interpreted CONFIG_VHOST_USER as controlling only QEMU's vhost-user
> > device frontends. However, virtiofsd and contrib/ vhost-user device
> > backends are also controlled by CONFIG_VHOST_USER. Make the
> > vhost-user-blk server depend on CONFIG_VHOST_USER for consistency.
>
> Possible follow up cleanup is to rename variable including
> "frontend/backend".
Yes, vhost-user-blk-server and related names don't follow vhost-user
terminology.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-11 14:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 17:11 [PATCH 0/3] vhost-user: ./configure improvements for 5.2 Stefan Hajnoczi
2020-11-10 17:11 ` [PATCH 1/3] meson: move vhost_user_blk_server to meson.build Stefan Hajnoczi
2020-11-11 9:41 ` Philippe Mathieu-Daudé
2020-11-11 11:44 ` Philippe Mathieu-Daudé
2020-11-11 11:54 ` Philippe Mathieu-Daudé
2020-11-12 10:58 ` Stefan Hajnoczi
2020-11-10 17:11 ` [PATCH 2/3] vhost-user-blk-server: depend on CONFIG_VHOST_USER Stefan Hajnoczi
2020-11-11 9:25 ` Philippe Mathieu-Daudé
2020-11-11 14:16 ` Stefan Hajnoczi [this message]
2020-11-10 17:11 ` [PATCH 3/3] configure: mark vhost-user Linux-only Stefan Hajnoczi
2020-11-10 17:44 ` Thomas Huth
2020-11-11 9:23 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111141636.GA1398106@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.