From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BCB6C388F9 for ; Wed, 11 Nov 2020 16:42:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E6EF2072C for ; Wed, 11 Nov 2020 16:42:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="iZzMR3JK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727392AbgKKQmM (ORCPT ); Wed, 11 Nov 2020 11:42:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727132AbgKKQmM (ORCPT ); Wed, 11 Nov 2020 11:42:12 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7350EC0613D1 for ; Wed, 11 Nov 2020 08:42:11 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id h62so2924367wme.3 for ; Wed, 11 Nov 2020 08:42:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NA9CfSTIvFjKTTcCo0GBZExn6gG0rmPxEPFJJSh1HC0=; b=iZzMR3JKsn93UQVuTMqTVw5jkQ1FGXVEQsHhGkoysIut9rmfaPAa8DVtehRc7lGzfe aNPv9TKKFxCOHIJ/CU2qJQ3JIqcbOSthY9sia/hj0eY+JW7EOcadtLWbr/32Z1WTuyNc 4UTo5D+p+doIy5vHjS1uS9SsI4cUsE0lfDpUgaLPMFvbB8ZxFy0p2s0DQUBxSWG3ShxC cotGgQaeyl0G9VaccrjlJvtBXneLiqdOWB8EQfLWlh02FHwknCDZpNYdPJfBJFq0uQGO 9AHI7KIRSFoz4MxXnpYSKgolrCtrhdflo+46YRBtHH8uFiAS/ZZz9ibPQAb1J/L9glnw x6hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NA9CfSTIvFjKTTcCo0GBZExn6gG0rmPxEPFJJSh1HC0=; b=qxBJS8LTyHJr9YS+c7zBTX/qOVFIXDTGKlG3oBxqLsxLTZXhxoVp+bGnxY9mckh8c8 Tz1WXzyX+Hv+o2/XbLqCtQURfqwAR8RRQrXfTXuoyWkgrON8PAS6EpMO5xNntDR/n6tD 3KYTsywBjUMed4WLh6OWtopy4GPLe2jH70CtmB2DD+BayoKqXXZ77Mxb8dOZRtwWwX3R bQ/9T+kReicdRpaAVKFSZBT+5FJzlk8oV0+D046sTIRAoHBUd8vM9c4fJs+jPDqXhfde UsYsdf2O0UvFTUv3RRtGsijiWVBmXz/l3PUEd5/7/3vBrRU5zGH9gegOQnQc6ZInJ48V cdOw== X-Gm-Message-State: AOAM532RdNrBQzouDaA0sKdbFAucMOU+mxCFFYC61jSUKC3XOeoaWUTM FbngCAcQxfK6eENgK2e++JwgdQ== X-Google-Smtp-Source: ABdhPJzfOwchmgvUgHIEbEtU/j17AwAW695XbMtbpMUR0Zd+jCJBV5jjIXbQ8MplaBj3uPb3toGRyQ== X-Received: by 2002:a1c:6a11:: with SMTP id f17mr4945240wmc.24.1605112929933; Wed, 11 Nov 2020 08:42:09 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) by smtp.gmail.com with ESMTPSA id z19sm3076154wmk.12.2020.11.11.08.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 08:42:09 -0800 (PST) Date: Wed, 11 Nov 2020 17:42:03 +0100 From: Marco Elver To: Andrey Konovalov Cc: Dmitry Vyukov , Alexander Potapenko , Catalin Marinas , Will Deacon , Vincenzo Frascino , Evgenii Stepanov , Andrey Ryabinin , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 06/20] kasan: remove __kasan_unpoison_stack Message-ID: <20201111164203.GH517454@elver.google.com> References: <462c375f39ba8c4c105b3a9bf3b5db17f3720159.1605046662.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <462c375f39ba8c4c105b3a9bf3b5db17f3720159.1605046662.git.andreyknvl@google.com> User-Agent: Mutt/1.14.6 (2020-07-11) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 11:20PM +0100, Andrey Konovalov wrote: > There's no need for __kasan_unpoison_stack() helper, as it's only > currently used in a single place. Removing it also removes unneeded > arithmetic. > > No functional changes. > > Signed-off-by: Andrey Konovalov > Reviewed-by: Dmitry Vyukov > Link: https://linux-review.googlesource.com/id/Ie5ba549d445292fe629b4a96735e4034957bcc50 > --- > mm/kasan/common.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) Reviewed-by: Marco Elver Thanks for spotting this simplification. > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index a3e67d49b893..9008fc6b0810 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -59,18 +59,12 @@ void kasan_disable_current(void) > #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ > > #if CONFIG_KASAN_STACK > -static void __kasan_unpoison_stack(struct task_struct *task, const void *sp) > -{ > - void *base = task_stack_page(task); > - size_t size = sp - base; > - > - kasan_unpoison_memory(base, size); > -} > - > /* Unpoison the entire stack for a task. */ > void kasan_unpoison_task_stack(struct task_struct *task) > { > - __kasan_unpoison_stack(task, task_stack_page(task) + THREAD_SIZE); > + void *base = task_stack_page(task); > + > + kasan_unpoison_memory(base, THREAD_SIZE); > } > > /* Unpoison the stack for the current task beyond a watermark sp value. */ > -- > 2.29.2.222.g5d2a92d10f8-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E304C388F9 for ; Wed, 11 Nov 2020 16:43:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A285B2072C for ; Wed, 11 Nov 2020 16:43:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yQzyPDsH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="iZzMR3JK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A285B2072C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7m0wtWSYizM4QDnRScQiRh4EYR63tpCth+GeRNvjtnQ=; b=yQzyPDsHgQiMp8Dm0TrWnroQz dBQqXYLuV9G7G2KiGnFji7sPEnYe8MUbwjm0ARgsuM95BVLEJZDEqTTiSTEVf/mvFfUG8/LstYkso QInFeq1Ym29rSIZJI+Yg2eJahZPQiwqbJArDbNSklOuDoFy/jbEHKI9/1E39F8J69PWIWkyX9JWW1 62kDDxX0y8krtwjZ8AyDkPC8ZICxmCzkcw8SwcTvkTgMBJRRECLQcckR/z9c5QyFwuuNDfVvbcBLN XQxO5Jr1Bc8++Pr82Ccjh/bD8y5TD7r9toZxIQGx9ro+lHJHiWYtdy7VemtbKghLKMVC6vkU0YOl1 SKb6lsKyw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kctCI-0007ci-Va; Wed, 11 Nov 2020 16:42:15 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kctCF-0007bl-Pe for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 16:42:12 +0000 Received: by mail-wm1-x344.google.com with SMTP id a65so2939490wme.1 for ; Wed, 11 Nov 2020 08:42:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NA9CfSTIvFjKTTcCo0GBZExn6gG0rmPxEPFJJSh1HC0=; b=iZzMR3JKsn93UQVuTMqTVw5jkQ1FGXVEQsHhGkoysIut9rmfaPAa8DVtehRc7lGzfe aNPv9TKKFxCOHIJ/CU2qJQ3JIqcbOSthY9sia/hj0eY+JW7EOcadtLWbr/32Z1WTuyNc 4UTo5D+p+doIy5vHjS1uS9SsI4cUsE0lfDpUgaLPMFvbB8ZxFy0p2s0DQUBxSWG3ShxC cotGgQaeyl0G9VaccrjlJvtBXneLiqdOWB8EQfLWlh02FHwknCDZpNYdPJfBJFq0uQGO 9AHI7KIRSFoz4MxXnpYSKgolrCtrhdflo+46YRBtHH8uFiAS/ZZz9ibPQAb1J/L9glnw x6hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NA9CfSTIvFjKTTcCo0GBZExn6gG0rmPxEPFJJSh1HC0=; b=L0p5H3osAgUliN+F4wpGD7aRyHpIRbdiY9jJNKYwWds68r4xj6ZWMv8q6JvNYy6D5X QyHE4CRXLZqWV7WQaKsN/69dfZGGTAONskIlFpE5dP+EM/yyusYN9dYUkbRym1PPabu0 GqOrrXrJQ8jAg7Pk3pa/99JCHDR9Eo+Hq73emvrzgl9VNDQF6qBzBjBlXC7oSf5VY1h/ 9H+r5FX2Hf/jwTQzU2yT6zYN7v1k9NIp9GiyQ7LLg5W9Qi7cgO6sqsbaqrhrkq8Wi9VH bKufa4ZeIg++ObWYvSGJS6Y7qJcU9I6zX/+VsWZaqXxSIWDFkzrwmnoj16D8BVnWZdw9 MRNQ== X-Gm-Message-State: AOAM531wnAAwsAtLa2jNiXJTmhVdtURwT/j5M45GKF3PH40NWhUMhJc3 sJyToL+0n+44AAmFJfEwH4WyvA== X-Google-Smtp-Source: ABdhPJzfOwchmgvUgHIEbEtU/j17AwAW695XbMtbpMUR0Zd+jCJBV5jjIXbQ8MplaBj3uPb3toGRyQ== X-Received: by 2002:a1c:6a11:: with SMTP id f17mr4945240wmc.24.1605112929933; Wed, 11 Nov 2020 08:42:09 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) by smtp.gmail.com with ESMTPSA id z19sm3076154wmk.12.2020.11.11.08.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 08:42:09 -0800 (PST) Date: Wed, 11 Nov 2020 17:42:03 +0100 From: Marco Elver To: Andrey Konovalov Subject: Re: [PATCH v2 06/20] kasan: remove __kasan_unpoison_stack Message-ID: <20201111164203.GH517454@elver.google.com> References: <462c375f39ba8c4c105b3a9bf3b5db17f3720159.1605046662.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <462c375f39ba8c4c105b3a9bf3b5db17f3720159.1605046662.git.andreyknvl@google.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_114211_876287_AD006932 X-CRM114-Status: GOOD ( 19.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Branislav Rankov , Catalin Marinas , Kevin Brodsky , Will Deacon , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 10, 2020 at 11:20PM +0100, Andrey Konovalov wrote: > There's no need for __kasan_unpoison_stack() helper, as it's only > currently used in a single place. Removing it also removes unneeded > arithmetic. > > No functional changes. > > Signed-off-by: Andrey Konovalov > Reviewed-by: Dmitry Vyukov > Link: https://linux-review.googlesource.com/id/Ie5ba549d445292fe629b4a96735e4034957bcc50 > --- > mm/kasan/common.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) Reviewed-by: Marco Elver Thanks for spotting this simplification. > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index a3e67d49b893..9008fc6b0810 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -59,18 +59,12 @@ void kasan_disable_current(void) > #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ > > #if CONFIG_KASAN_STACK > -static void __kasan_unpoison_stack(struct task_struct *task, const void *sp) > -{ > - void *base = task_stack_page(task); > - size_t size = sp - base; > - > - kasan_unpoison_memory(base, size); > -} > - > /* Unpoison the entire stack for a task. */ > void kasan_unpoison_task_stack(struct task_struct *task) > { > - __kasan_unpoison_stack(task, task_stack_page(task) + THREAD_SIZE); > + void *base = task_stack_page(task); > + > + kasan_unpoison_memory(base, THREAD_SIZE); > } > > /* Unpoison the stack for the current task beyond a watermark sp value. */ > -- > 2.29.2.222.g5d2a92d10f8-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel