From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35C0CC388F9 for ; Wed, 11 Nov 2020 16:49:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16A2C2072C for ; Wed, 11 Nov 2020 16:49:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="K2BhgEmh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16A2C2072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EA8186E086; Wed, 11 Nov 2020 16:48:59 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 562266E086 for ; Wed, 11 Nov 2020 16:48:58 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id b6so3187672wrt.4 for ; Wed, 11 Nov 2020 08:48:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HB2l8TV0D9ugazGegWCjwMY9NcRR8f0Gu6GVTxWgxzo=; b=K2BhgEmh3TeEgPp3w9x/VuQ99DxO87eTOlvGMSjfnN0TO6Dw88gYYCFyNs/YEC9d+F KTqEQ+0ItdPY1Y7g5E3QEKHtYBb45xWmoSinjsbG57I3hOKneEN5Iw404oYZdt66NLHz FjToYyVexb8ILovVJiLPypIRTVMcFcJnVS7+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HB2l8TV0D9ugazGegWCjwMY9NcRR8f0Gu6GVTxWgxzo=; b=YEk5sDElkliIVEoMryqeaQTuRHhu2NdOUh0PC+FA5SGjsZXniynuOPOw3qyL25gYv7 GL/rq1QWVufcYDx84W6dZkV8cp8zkT5QmifbsJ0+LqCO3mQ2izWZe2bxJEbLqWPmkayB TIJy4GYBP1inTr4NKZdszNmv9Ppat2zWWhaDMYzSG3M66ivJG+XtaQjkXTfRuNgL5nDN BBnuljgkDQUIRIzaOz3I/KexUJHoIY5dThhtS7U0MeLoMoXxHAXvyOSJ5H7Ghu88vh9w ZwWdSLuOebw6VltvatUuzlTVV8qJloZ/Ot/v730sdnVRtCqiGSCZhyu9qTjbSNgqaOvN zjcA== X-Gm-Message-State: AOAM530LURrz6gs6qqMVPyB6F0g6P6PC+Hw2Oxf3Xzs8PBimkktZ+CUJ z9oRiq45HzL2G9eb9Fzy85pzGBwwM72v/Q== X-Google-Smtp-Source: ABdhPJxVgcGYCimPNfOA+aOvpKKRT15G8+D/gUQSB/ayu3AFaigkP59zPIjO3027W4TuAqaPGt3Oyw== X-Received: by 2002:a5d:474f:: with SMTP id o15mr29850916wrs.377.1605113337013; Wed, 11 Nov 2020 08:48:57 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j127sm3503128wma.31.2020.11.11.08.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 08:48:56 -0800 (PST) Date: Wed, 11 Nov 2020 17:48:53 +0100 From: Daniel Vetter To: Simon Ser Subject: Re: [PATCH v2 2/2] drm: add debug logs for drm_mode_atomic_ioctl errors Message-ID: <20201111164853.GQ401619@phenom.ffwll.local> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Thomas Zimmermann , Sam Ravnborg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Nov 11, 2020 at 09:07:39AM +0000, Simon Ser wrote: > Be nice to user-space and log what happened when returning EINVAL in > drm_mode_atomic_ioctl. > > v2: > > - Migrate to drm_dbg_atomic (Sam) > - Add debug log for arg->reserved (Ville) > - Drop redundant "atomic" word in log messages (Ville) > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: Sam Ravnborg > Cc: Ville Syrjala Submission bikeshed: Patch 1&2 aren't threaded. I thought git send-email gets that right by default nowadays ... Anyway, on both patches: Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_atomic_uapi.c | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c > index efab3d518891..9df7f2a170e3 100644 > --- a/drivers/gpu/drm/drm_atomic_uapi.c > +++ b/drivers/gpu/drm/drm_atomic_uapi.c > @@ -1330,22 +1330,35 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, > * though this may be a bit overkill, since legacy userspace > * wouldn't know how to call this ioctl) > */ > - if (!file_priv->atomic) > + if (!file_priv->atomic) { > + drm_dbg_atomic(dev, > + "commit failed: atomic cap not enabled\n"); > return -EINVAL; > + } > > - if (arg->flags & ~DRM_MODE_ATOMIC_FLAGS) > + if (arg->flags & ~DRM_MODE_ATOMIC_FLAGS) { > + drm_dbg_atomic(dev, "commit failed: invalid flag\n"); > return -EINVAL; > + } > > - if (arg->reserved) > + if (arg->reserved) { > + drm_dbg_atomic(dev, "commit failed: reserved field set\n"); > return -EINVAL; > + } > > - if (arg->flags & DRM_MODE_PAGE_FLIP_ASYNC) > + if (arg->flags & DRM_MODE_PAGE_FLIP_ASYNC) { > + drm_dbg_atomic(dev, > + "commit failed: invalid flag DRM_MODE_PAGE_FLIP_ASYNC\n"); > return -EINVAL; > + } > > /* can't test and expect an event at the same time. */ > if ((arg->flags & DRM_MODE_ATOMIC_TEST_ONLY) && > - (arg->flags & DRM_MODE_PAGE_FLIP_EVENT)) > + (arg->flags & DRM_MODE_PAGE_FLIP_EVENT)) { > + drm_dbg_atomic(dev, > + "commit failed: page-flip event requested with test-only commit\n"); > return -EINVAL; > + } > > state = drm_atomic_state_alloc(dev); > if (!state) > -- > 2.29.2 > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel