Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Andre Przywara <Andre.Przywara@arm.com>,
	"leo.yan@linaro.org" <leo.yan@linaro.org>,
	James Clark <James.Clark@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <Mark.Rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Al Grant <Al.Grant@arm.com>, Wei Li <liwei391@huawei.com>,
	John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer
Date: Wed, 11 Nov 2020 15:08:38 -0300	[thread overview]
Message-ID: <20201111180838.GF380127@kernel.org> (raw)
In-Reply-To: <20201111180248.GE380127@kernel.org>

Em Wed, Nov 11, 2020 at 03:02:48PM -0300, Arnaldo Carvalho de Melo escreveu:
> > I'll keep the series up to that point and will run my build tests, then
> > push it publicly to acme/perf/core and you can go from there, ok?

> > I've changed the BIT() to BIT_ULL() as Andre suggested and I'm testing
> > it again.

> To make it clear, this is what I have locally:

> 0a04244cabc5560c (HEAD -> perf/core) perf arm-spe: Fix packet length handling
> b65577baf4829092 perf arm-spe: Refactor arm_spe_get_events()
> b2ded2e2e2764e50 perf arm-spe: Refactor payload size calculation
> 903b659436b70692 perf arm-spe: Fix a typo in comment
> c185f1cde46653cd perf arm-spe: Include bitops.h for BIT() macro
> 40714c58630aaaf1 perf mem: Support ARM SPE events
> c825f7885178f994 perf c2c: Support AUX trace
> 13e5df1e3f1ba1a9 perf mem: Support AUX trace
> 014a771c7867fda5 perf auxtrace: Add itrace option '-M' for memory events
> 436cce00710a3f23 perf mem: Only initialize memory event for recording
> 8b8173b45a7a9709 perf c2c: Support memory event PERF_MEM_EVENTS__LOAD_STORE
> 4ba2452cd88f39da perf mem: Support new memory event PERF_MEM_EVENTS__LOAD_STORE
> eaf6aaeec5fa301c perf mem: Introduce weak function perf_mem_events__ptr()
> f9f16dfbe76e63ba perf mem: Search event name with more flexible path
> 644bf4b0f7acde64 (tag: perf-tools-tests-v5.11-2020-11-04, acme/perf/core) perf jevents: Add test for arch std events

So with the above it works with at least these:

[perfbuilder@five ~]$ dm android-ndk:r15c-arm ubuntu:18.04-x-arm
   1    22.37 android-ndk:r15c-arm          : Ok   arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
   2    28.52 ubuntu:18.04-x-arm            : Ok   arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) 7.5.0
[perfbuilder@five ~]$

previously it was failing in all 32-bit build test containers:

[perfbuilder@five linux-perf-tools-build]$ grep FAIL dm.log/summary 
 android-ndk:r12b-arm: FAIL
 android-ndk:r15c-arm: FAIL
 fedora:24-x-ARC-uClibc: FAIL
 fedora:30-x-ARC-uClibc: FAIL
 ubuntu:16.04-x-arm: FAIL
 ubuntu:16.04-x-powerpc: FAIL
 ubuntu:18.04-x-arm: FAIL
 ubuntu:18.04-x-m68k: FAIL
 ubuntu:18.04-x-powerpc: FAIL
 ubuntu:18.04-x-sh4: FAIL
 ubuntu:19.10-x-hppa: FAIL
[perfbuilder@five linux-perf-tools-build]$

I'll redo the full set of tests and push perf/core publicly.

- Arnaldo