From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 445FAC56202 for ; Wed, 11 Nov 2020 21:29:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E36E52151B for ; Wed, 11 Nov 2020 21:29:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726146AbgKKV3B (ORCPT ); Wed, 11 Nov 2020 16:29:01 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:34192 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbgKKV3A (ORCPT ); Wed, 11 Nov 2020 16:29:00 -0500 Received: by mail-ot1-f67.google.com with SMTP id j14so3577125ots.1; Wed, 11 Nov 2020 13:29:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GTqvmPN8FeL5Camvlbygkl55K/SzqW8sO9N4V5KBE+A=; b=Qb0QJbOAQOgk8AW7SsdwVYWVV3SQ6r53/gNTHKQ+5dnurBxn7R+Ffyx5zXwUwfWQ57 IgGjPMSd/1FEvNbv6QYnFSMrn7bCwEkthi73f83Xijr9UoaYQGXbNo4X9rjf/oonZRvg 6lL8/ASnggkSsQC2pOz8TZ60OPmxP1jZDfgsdAWyI8NoVDij7FBvi6C7zJXwZUzexjoK ZyRqYVV6bWnUPDMzr6So9q7dm/iY/vBY1qmL5V2YIt1B0AHAEXUqJUGr6RzSbTrpn8kD ZgQVmX1Xiu5KROPorUX8AzOzmO1cv2dhIhncFGr+OspWBfCjZYsNXtRSXnJH3pSoNWpl iRJA== X-Gm-Message-State: AOAM530EvHCH2gSFax3zRSlNdGkLK0W+Bsx4nfw+CSpycQzS/9+p25z6 Qx8Ud52TMiugQfqWQoy57w== X-Google-Smtp-Source: ABdhPJzmEghly3TxVwLcQf55ECIcDH9bmjqKX2JH5w1pCq+Kyel1xEtqU9aIPOXaypf0bgXBiMsJ2Q== X-Received: by 2002:a05:6830:1dd8:: with SMTP id a24mr18387165otj.163.1605130139745; Wed, 11 Nov 2020 13:28:59 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id v144sm666366oia.21.2020.11.11.13.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 13:28:58 -0800 (PST) Received: (nullmailer pid 2067102 invoked by uid 1000); Wed, 11 Nov 2020 21:28:57 -0000 Date: Wed, 11 Nov 2020 15:28:57 -0600 From: Rob Herring To: Kishon Vijay Abraham I Cc: Tero Kristo , Nishanth Menon , Roger Quadros , Lee Jones , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/7] dt-bindings: mfd: ti,j721e-system-controller.yaml: Document "syscon" Message-ID: <20201111212857.GA2059063@bogus> References: <20201109170409.4498-1-kishon@ti.com> <20201109170409.4498-2-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201109170409.4498-2-kishon@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 09, 2020 at 10:34:03PM +0530, Kishon Vijay Abraham I wrote: > Add binding documentation for "syscon" which should be a subnode of > the system controller (scm-conf). > > Signed-off-by: Kishon Vijay Abraham I > --- > .../mfd/ti,j721e-system-controller.yaml | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > index 19fcf59fd2fe..0b115b707ab2 100644 > --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > @@ -50,6 +50,38 @@ patternProperties: > specified in > Documentation/devicetree/bindings/mux/reg-mux.txt > > + "^syscon@[0-9a-f]+$": > + type: object > + description: | Don't need '|' if there's no formatting. > + This is the system controller configuration required to configure PCIe > + mode, lane width and speed. > + > + properties: > + compatible: > + items: > + - enum: > + - ti,j721e-system-controller > + - const: syscon > + - const: simple-mfd Humm, then what are this node's sub-nodes? And the same compatible as the parent? > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > + ranges: true > + > + required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + - ranges > + > required: > - compatible > - reg > @@ -72,5 +104,13 @@ examples: > compatible = "mmio-mux"; > reg = <0x00004080 0x50>; > }; > + > + pcie1_ctrl: syscon@4074 { > + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; > + reg = <0x00004074 0x4>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x4074 0x4074 0x4>; Must be packing a bunch of functions into 4 byte region! > + }; > }; > ... > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D2D0C388F9 for ; Wed, 11 Nov 2020 21:31:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95FB620825 for ; Wed, 11 Nov 2020 21:31:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K6ON/wIn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95FB620825 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6gXejohdwcAnxRGRmTLOxhiE+xiC4xsKvLoFDhgr39U=; b=K6ON/wInU6w6avG6NkhZNqR6U 4x75BqJHmB3VYzYvij0qzhySESEXXFobTnQrOz8pJkR577pgEUtu7MhdopSxeM46OWSjGSKLFb9js qFApYuCkb/wgPAA3mZ71Olj1t+1Ne4545qCp935eR0tQCrraz/2Mzz1iLUYuCHQ6dsXXLcBbbRrRS yHzzKNY/N9PIDHSPziK9Q0+iHKvFKgOJvCoXxHcEehyTG5aIglZiOmv2VRUfK/ZnVe4COlk5xrdVZ i9AGigQeshXw85Bz0widaIz1o97kns3d8l9x8y4EXD0Cr2oM1wEMBYHybyBOUoRuXlFW80Cbtbuqy AYfGv5N5g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcxfv-0001Aj-3i; Wed, 11 Nov 2020 21:29:07 +0000 Received: from mail-ot1-f66.google.com ([209.85.210.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcxfs-00019z-Od for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 21:29:05 +0000 Received: by mail-ot1-f66.google.com with SMTP id 30so3531918otx.9 for ; Wed, 11 Nov 2020 13:29:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GTqvmPN8FeL5Camvlbygkl55K/SzqW8sO9N4V5KBE+A=; b=FkeM9e3RYtWH0yB1RievyzWktFuHjAjtG/jEtgjup+yiK281R2nAFRZ4Yg8CaGuTEc LxMVm/eA6dKS7VQ9LHlUpC1KCfJVYflPrwrqVV70YcntnSWhG1AU1oq4OGcMKnluv8s9 khCNMMbVYD2HWAV4tm8xTmIamhJY85kYzHyY285BylWT9lNz5N0ULgj0k9kqRlRr3MEe 6/0tGsXh0Yf5Mde59EarTnJMDokzruJT5mi+cA/ZdO3XL555N62+8Tb9azf/F7W0Rk3I riH+nG4/G/rO8FW6UmuZqqMMPMogXtSeNEHQzdAd1z1U/gv4HeX5EgkwWIJoFNH98c4a QJFg== X-Gm-Message-State: AOAM531iuCZiOcnKg6aZrwFbxPF5uOpAQH7mU5KoONd2mbZmoFglTG1e fAYp/kjw4u1KSHym93ZyKQ== X-Google-Smtp-Source: ABdhPJzmEghly3TxVwLcQf55ECIcDH9bmjqKX2JH5w1pCq+Kyel1xEtqU9aIPOXaypf0bgXBiMsJ2Q== X-Received: by 2002:a05:6830:1dd8:: with SMTP id a24mr18387165otj.163.1605130139745; Wed, 11 Nov 2020 13:28:59 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id v144sm666366oia.21.2020.11.11.13.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 13:28:58 -0800 (PST) Received: (nullmailer pid 2067102 invoked by uid 1000); Wed, 11 Nov 2020 21:28:57 -0000 Date: Wed, 11 Nov 2020 15:28:57 -0600 From: Rob Herring To: Kishon Vijay Abraham I Subject: Re: [PATCH v2 1/7] dt-bindings: mfd: ti,j721e-system-controller.yaml: Document "syscon" Message-ID: <20201111212857.GA2059063@bogus> References: <20201109170409.4498-1-kishon@ti.com> <20201109170409.4498-2-kishon@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201109170409.4498-2-kishon@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_162904_890874_9006972A X-CRM114-Status: GOOD ( 19.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Tero Kristo , Bjorn Helgaas , Lee Jones , linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 09, 2020 at 10:34:03PM +0530, Kishon Vijay Abraham I wrote: > Add binding documentation for "syscon" which should be a subnode of > the system controller (scm-conf). > > Signed-off-by: Kishon Vijay Abraham I > --- > .../mfd/ti,j721e-system-controller.yaml | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > index 19fcf59fd2fe..0b115b707ab2 100644 > --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > @@ -50,6 +50,38 @@ patternProperties: > specified in > Documentation/devicetree/bindings/mux/reg-mux.txt > > + "^syscon@[0-9a-f]+$": > + type: object > + description: | Don't need '|' if there's no formatting. > + This is the system controller configuration required to configure PCIe > + mode, lane width and speed. > + > + properties: > + compatible: > + items: > + - enum: > + - ti,j721e-system-controller > + - const: syscon > + - const: simple-mfd Humm, then what are this node's sub-nodes? And the same compatible as the parent? > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > + ranges: true > + > + required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + - ranges > + > required: > - compatible > - reg > @@ -72,5 +104,13 @@ examples: > compatible = "mmio-mux"; > reg = <0x00004080 0x50>; > }; > + > + pcie1_ctrl: syscon@4074 { > + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; > + reg = <0x00004074 0x4>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x4074 0x4074 0x4>; Must be packing a bunch of functions into 4 byte region! > + }; > }; > ... > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel