From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5BE4C2D0A3 for ; Thu, 12 Nov 2020 09:26:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5907E221FF for ; Thu, 12 Nov 2020 09:26:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727291AbgKLJ0F (ORCPT ); Thu, 12 Nov 2020 04:26:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:36566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbgKLJ0F (ORCPT ); Thu, 12 Nov 2020 04:26:05 -0500 Received: from gaia (unknown [2.26.170.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 180BF221FE; Thu, 12 Nov 2020 09:26:00 +0000 (UTC) Date: Thu, 12 Nov 2020 09:25:58 +0000 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Will Deacon , linux-kernel@vger.kernel.org, Mark Rutland , Steve Capper , Mark Brown , Marc Zyngier , gshan@redhat.com, Robin Murphy , Steven Price , David Hildenbrand Subject: Re: [PATCH] arm64: mm: account for hotplug memory when randomizing the linear region Message-ID: <20201112092558.GC29613@gaia> References: <20201014081857.3288-1-ardb@kernel.org> <160503561804.1015659.16599672230432576934.b4-ty@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anshuman, On Wed, Nov 11, 2020 at 09:18:56AM +0530, Anshuman Khandual wrote: > On 11/11/20 12:44 AM, Catalin Marinas wrote: > > On Wed, 14 Oct 2020 10:18:57 +0200, Ard Biesheuvel wrote: > >> As a hardening measure, we currently randomize the placement of > >> physical memory inside the linear region when KASLR is in effect. > >> Since the random offset at which to place the available physical > >> memory inside the linear region is chosen early at boot, it is > >> based on the memblock description of memory, which does not cover > >> hotplug memory. The consequence of this is that the randomization > >> offset may be chosen such that any hotplugged memory located above > >> memblock_end_of_DRAM() that appears later is pushed off the end of > >> the linear region, where it cannot be accessed. > >> > >> [...] > > > > Applied to arm64 (for-next/mem-hotplug), thanks! > > > > [1/1] arm64: mm: account for hotplug memory when randomizing the linear region > > https://git.kernel.org/arm64/c/97d6786e0669 > > Got delayed and never made here in time, sorry about that. Nonetheless, > I have got something working with respect to the generic mechanism that > David Hildenbrand had asked for earlier. > > https://patchwork.kernel.org/project/linux-arm-kernel/patch/1600332402-30123-1-git-send-email-anshuman.khandual@arm.com/ There was a lot of discussion around this patch but I haven't seen any new version posted. > I am wondering if we could instead consider merging the above patch with > a small change that Ard had pointed out earlier [1], I will send out a > revision if required. If your patch fixes the randomisation issue that Ard addressed, I'm happy to replace that with your patch. But please post a new version and get some acks in place from the parties involved in the discussion. Thanks. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 661FBC2D0A3 for ; Thu, 12 Nov 2020 09:27:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9F6C221FE for ; Thu, 12 Nov 2020 09:27:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0cBgyZ9R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9F6C221FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X6TOErbRNAaO4DAHlJ845w9Wki1sZ87wM/f3An/7S+Y=; b=0cBgyZ9RudwppxhvePwhmP8nm e0MtJ47PbBDocqp2cWemZ5Q77yhVjdLDOaio5ChlWttELaeQUI3yxJNf1Qcupt4rmSfm1X3v4j68A 3/ufkYFY2GVYG0cKezd+oWLIodDWeDzDGGvXpmM+kbevb5KaetC3fCLputvChLN8WQuoHc28ctaIA LWfZi1Tl30Bo8TzCdVf/4unflLgNb7ZNPK4ThE7zq/auRf+cAyrTf3Dvlx0NLQdaEW13DAkns2jH1 XXzvSaSUPOgUr7FWGyM/E8mYOI40DI7doLnWRQxu5gt4txJD730k54dd3ILLvdi+p00PEnVw81b4u ea/bQdyVg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd8ro-0003G6-4G; Thu, 12 Nov 2020 09:26:08 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd8rk-0003FZ-FD for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 09:26:06 +0000 Received: from gaia (unknown [2.26.170.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 180BF221FE; Thu, 12 Nov 2020 09:26:00 +0000 (UTC) Date: Thu, 12 Nov 2020 09:25:58 +0000 From: Catalin Marinas To: Anshuman Khandual Subject: Re: [PATCH] arm64: mm: account for hotplug memory when randomizing the linear region Message-ID: <20201112092558.GC29613@gaia> References: <20201014081857.3288-1-ardb@kernel.org> <160503561804.1015659.16599672230432576934.b4-ty@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_042604_659283_D1856361 X-CRM114-Status: GOOD ( 24.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , gshan@redhat.com, Steve Capper , Marc Zyngier , David Hildenbrand , linux-kernel@vger.kernel.org, Steven Price , Mark Brown , Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Anshuman, On Wed, Nov 11, 2020 at 09:18:56AM +0530, Anshuman Khandual wrote: > On 11/11/20 12:44 AM, Catalin Marinas wrote: > > On Wed, 14 Oct 2020 10:18:57 +0200, Ard Biesheuvel wrote: > >> As a hardening measure, we currently randomize the placement of > >> physical memory inside the linear region when KASLR is in effect. > >> Since the random offset at which to place the available physical > >> memory inside the linear region is chosen early at boot, it is > >> based on the memblock description of memory, which does not cover > >> hotplug memory. The consequence of this is that the randomization > >> offset may be chosen such that any hotplugged memory located above > >> memblock_end_of_DRAM() that appears later is pushed off the end of > >> the linear region, where it cannot be accessed. > >> > >> [...] > > > > Applied to arm64 (for-next/mem-hotplug), thanks! > > > > [1/1] arm64: mm: account for hotplug memory when randomizing the linear region > > https://git.kernel.org/arm64/c/97d6786e0669 > > Got delayed and never made here in time, sorry about that. Nonetheless, > I have got something working with respect to the generic mechanism that > David Hildenbrand had asked for earlier. > > https://patchwork.kernel.org/project/linux-arm-kernel/patch/1600332402-30123-1-git-send-email-anshuman.khandual@arm.com/ There was a lot of discussion around this patch but I haven't seen any new version posted. > I am wondering if we could instead consider merging the above patch with > a small change that Ard had pointed out earlier [1], I will send out a > revision if required. If your patch fixes the randomisation issue that Ard addressed, I'm happy to replace that with your patch. But please post a new version and get some acks in place from the parties involved in the discussion. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel