From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1379BC2D0A3 for ; Thu, 12 Nov 2020 10:31:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A97E922210 for ; Thu, 12 Nov 2020 10:31:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727904AbgKLKbH (ORCPT ); Thu, 12 Nov 2020 05:31:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:49930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726107AbgKLKbH (ORCPT ); Thu, 12 Nov 2020 05:31:07 -0500 Received: from gaia (unknown [2.26.170.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 10BF622203; Thu, 12 Nov 2020 10:31:03 +0000 (UTC) Date: Thu, 12 Nov 2020 10:31:01 +0000 From: Catalin Marinas To: Andrey Konovalov Cc: Dmitry Vyukov , Alexander Potapenko , Marco Elver , Will Deacon , Vincenzo Frascino , Evgenii Stepanov , Andrey Ryabinin , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/20] kasan: allow VMAP_STACK for HW_TAGS mode Message-ID: <20201112103100.GJ29613@gaia> References: <3443e106c40799e5dc3981dec2011379f3cbbb0c.1605046662.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3443e106c40799e5dc3981dec2011379f3cbbb0c.1605046662.git.andreyknvl@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 11:20:09PM +0100, Andrey Konovalov wrote: > Even though hardware tag-based mode currently doesn't support checking > vmalloc allocations, it doesn't use shadow memory and works with > VMAP_STACK as is. Change VMAP_STACK definition accordingly. > > Signed-off-by: Andrey Konovalov > Link: https://linux-review.googlesource.com/id/I3552cbc12321dec82cd7372676e9372a2eb452ac > --- > arch/Kconfig | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 56b6ccc0e32d..7e7d14fae568 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -914,16 +914,16 @@ config VMAP_STACK > default y > bool "Use a virtually-mapped stack" > depends on HAVE_ARCH_VMAP_STACK > - depends on !KASAN || KASAN_VMALLOC > + depends on !KASAN || KASAN_HW_TAGS || KASAN_VMALLOC >From the arm64 perspective: Acked-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9333C55ABD for ; Thu, 12 Nov 2020 10:32:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5746222203 for ; Thu, 12 Nov 2020 10:32:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UNIzJIvL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5746222203 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0U1vxmBarCVbXn/LheghDdq56k16MqkFt+UpWjiavwQ=; b=UNIzJIvLtzjwJqipGKIG1xtFo 7czqjWN5OGPpnC6db0dwHf6wp9Y3SjCjr7TbbHkYLQp7kBQR3N55cZGDMmBzV9oREnipWh7tC78xd zRstjIH4rgQGYIseFXXzDb883w+64ztxbx61ozlkQo4E2XYkheWTBB9Bk/UGVDqY3Wn+3UmP/bMo8 BIz+LYeGWbmjl4aQQgA82bVV4SA2akGZF98afmGGehz+qI315hKK+CijXx26QzkgT0OOlrwpr72/f Hk3TOputaHcE2jU3YeBYLXfNrsclaLo9cRFDb1vugV/ub/11Np0rstjiw3M2PZcXOUXER+tLgJeuW 1IIomWExw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd9sm-00031D-8A; Thu, 12 Nov 2020 10:31:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd9sh-0002zW-Pd for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 10:31:10 +0000 Received: from gaia (unknown [2.26.170.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 10BF622203; Thu, 12 Nov 2020 10:31:03 +0000 (UTC) Date: Thu, 12 Nov 2020 10:31:01 +0000 From: Catalin Marinas To: Andrey Konovalov Subject: Re: [PATCH v2 05/20] kasan: allow VMAP_STACK for HW_TAGS mode Message-ID: <20201112103100.GJ29613@gaia> References: <3443e106c40799e5dc3981dec2011379f3cbbb0c.1605046662.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3443e106c40799e5dc3981dec2011379f3cbbb0c.1605046662.git.andreyknvl@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_053108_201426_DE49E00E X-CRM114-Status: GOOD ( 15.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 10, 2020 at 11:20:09PM +0100, Andrey Konovalov wrote: > Even though hardware tag-based mode currently doesn't support checking > vmalloc allocations, it doesn't use shadow memory and works with > VMAP_STACK as is. Change VMAP_STACK definition accordingly. > > Signed-off-by: Andrey Konovalov > Link: https://linux-review.googlesource.com/id/I3552cbc12321dec82cd7372676e9372a2eb452ac > --- > arch/Kconfig | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 56b6ccc0e32d..7e7d14fae568 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -914,16 +914,16 @@ config VMAP_STACK > default y > bool "Use a virtually-mapped stack" > depends on HAVE_ARCH_VMAP_STACK > - depends on !KASAN || KASAN_VMALLOC > + depends on !KASAN || KASAN_HW_TAGS || KASAN_VMALLOC >From the arm64 perspective: Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel