From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D77C2D0A3 for ; Thu, 12 Nov 2020 11:50:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39D89216FD for ; Thu, 12 Nov 2020 11:50:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728204AbgKLLuW (ORCPT ); Thu, 12 Nov 2020 06:50:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728226AbgKLLtU (ORCPT ); Thu, 12 Nov 2020 06:49:20 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CB5AC0613D4 for ; Thu, 12 Nov 2020 03:48:57 -0800 (PST) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdB5w-0006Lf-Ft; Thu, 12 Nov 2020 12:48:52 +0100 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1kdB5v-0001Wn-VL; Thu, 12 Nov 2020 12:48:51 +0100 Date: Thu, 12 Nov 2020 12:48:51 +0100 From: Oleksij Rempel To: Dmitry Torokhov Cc: Alexandru Ardelean , David Jander , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v2] Input: touchscreen: ads7846.c: Fix race that causes missing releases Message-ID: <20201112114851.mlhhxxjonhx5n4sz@pengutronix.de> References: <20201027105416.18773-1-o.rempel@pengutronix.de> <20201111190740.GY1003057@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201111190740.GY1003057@dtor-ws> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 12:48:21 up 363 days, 3:06, 30 users, load average: 0.03, 0.07, 0.01 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2020 at 11:07:40AM -0800, Dmitry Torokhov wrote: > Hi Oleksij, > > On Tue, Oct 27, 2020 at 11:54:16AM +0100, Oleksij Rempel wrote: > > From: David Jander > > > > If touchscreen is released while busy reading HWMON device, the release > > can be missed. The IRQ thread is not started because no touch is active > > and BTN_TOUCH release event is never sent. > > > > Fixes: f5a28a7d4858f94a ("Input: ads7846 - avoid pen up/down when reading hwmon") > > Co-Developed-by: David Jander > > Since the patch is nominally attributed to David (via the From: tag) > I'll be changing Co-developed-by tag to your name, OK? OK. > > > Signed-off-by: David Jander > > Signed-off-by: Oleksij Rempel Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |