From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CAA0C2D0E4 for ; Thu, 12 Nov 2020 18:20:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0102321D91 for ; Thu, 12 Nov 2020 18:20:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726540AbgKLSUC (ORCPT ); Thu, 12 Nov 2020 13:20:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:54396 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbgKLSUB (ORCPT ); Thu, 12 Nov 2020 13:20:01 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EF613AFF8; Thu, 12 Nov 2020 18:19:59 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 182D0DA6E1; Thu, 12 Nov 2020 19:18:16 +0100 (CET) Date: Thu, 12 Nov 2020 19:18:16 +0100 From: David Sterba To: Josef Bacik Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 0/8] Locking cleanups and lockdep fix Message-ID: <20201112181816.GV6756@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Josef Bacik , linux-btrfs@vger.kernel.org, kernel-team@fb.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Nov 06, 2020 at 04:27:28PM -0500, Josef Bacik wrote: > Hello, > > Filipe reported a lockdep splat that he hit on btrfs/187, but honestly could be > hit anywhere we do readdir on a sufficiently large fs. Fixing this is fairly > straightforward, but enabled me to do a lot of extra cleanups, especially now > that my other locking fixes have been merged. The first two patches are to > address the lockdep problem. The followup patches are cleaning out the > recursive locking support, which we no longer require. I would have separated > this work, but btrfs_next_old_leaf was a heavy user of this, so it would be > annoying to take separately, hence putting it all together. Thanks, > > Josef > > Josef Bacik (8): > btrfs: cleanup the locking in btrfs_next_old_leaf > btrfs: unlock to current level in btrfs_next_old_leaf > btrfs: kill path->recurse > btrfs: remove the recursion handling code in locking.c > btrfs: remove __btrfs_read_lock_root_node > btrfs: use btrfs_tree_read_lock in btrfs_search_slot > btrfs: remove the recurse parameter from __btrfs_tree_read_lock > btrfs: remove ->recursed from extent_buffer Added to misc-next, with some minor updates in changelogs. Seems that this should remove all leftovers after the locking switch.