From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95C63C2D0E4 for ; Thu, 12 Nov 2020 21:50:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2811921D91 for ; Thu, 12 Nov 2020 21:50:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U390PW+S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727314AbgKLVui (ORCPT ); Thu, 12 Nov 2020 16:50:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727175AbgKLVuh (ORCPT ); Thu, 12 Nov 2020 16:50:37 -0500 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4540AC0613D4 for ; Thu, 12 Nov 2020 13:50:37 -0800 (PST) Received: by mail-qk1-x744.google.com with SMTP id q5so6966545qkc.12 for ; Thu, 12 Nov 2020 13:50:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z3CD5S2CALksgVm8ns6TDId0Or2oDJ7UUxweYeXuETU=; b=U390PW+SMYc2n3VhGqRdsw6ONn1j5/PFCvEM+sQVMn87P/jOlwMimILpr8rOajdlyi 8ZHLfqbRDeyFh6wvw+1TeVFDhfH2xbTfvCtZLSIIR5MnX//LoWO3SShkhTCUoBDKAXhN 0v2Jdppw/64njlOh9pBLHiIpRQEWmT7nsTQlJ7trrTh43WqRbpWjJZOAxQbv51b6G8nw sDMGA3HWPsVEMphn7HzKe25+RJfep7tnTQehFspm0Jv44wIP9rPdq/Zd7Ua+lIiYFPbt 6NQNtxAHfbzZ2imANyZP1v3HOmKbb9OQfImCYvoi4V12Wd8TziesokuvAn5GbLw4pm2g c7yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=z3CD5S2CALksgVm8ns6TDId0Or2oDJ7UUxweYeXuETU=; b=IzErNDyWUCWxLmGIEOHKpjqr7mNjRVmN/l3fOHNUvnz2RT4oJrLYX4L4jUSkhgDWtH p8XFLBGDWdR/VhG0aNSQzJs5rQt+VSyuHzq6QRC7fyp0yOSyJjQpD3CgwXDcIizk6bF9 iThoqBfcJIb3ePEIFmAK7D3Ip7ox4W2WFOdO39qtyMJ1X4B2X7qLPJGUAvLeG/37AKdE W608B+HSlZ5gN/6oi5RXYWzefy6cdZSAJhJSV3HGNmmYP08cGdUU/rEbL0bGITHKy/Md Y5+c1xIWus6mcB88Ct/rY1cUUvy+CkR0Q+Nf5GVfns9g3NDFmNueynS8G24YOu4W9E8H /kCQ== X-Gm-Message-State: AOAM533aDXEGRqBQUzRqKMxG4rqjmXkfP92IJqXbvnTlj4C81PT7mQtJ Vp0g8b/Gg5gR9c0bGVCVHfI= X-Google-Smtp-Source: ABdhPJzndxGbL4rY+Uq8CS5dGOM9/e02yEyMIYyApn15onZ5PbPo/rpJ/ocftWBNZi52TI1ukQ4VNQ== X-Received: by 2002:a37:8c43:: with SMTP id o64mr2049159qkd.176.1605217836431; Thu, 12 Nov 2020 13:50:36 -0800 (PST) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id c79sm5529081qke.69.2020.11.12.13.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 13:50:35 -0800 (PST) Sender: Arvind Sankar From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Thu, 12 Nov 2020 16:50:33 -0500 To: Adrian Ratiu Cc: Nick Desaulniers , Nathan Chancellor , Arnd Bergmann , Linux ARM , clang-built-linux , Russell King , LKML , Collabora Kernel ML , Ard Biesheuvel Subject: Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization Message-ID: <20201112215033.GA438824@rani.riverdale.lan> References: <20201106051436.2384842-1-adrian.ratiu@collabora.com> <20201106051436.2384842-3-adrian.ratiu@collabora.com> <20201106101419.GB3811063@ubuntu-m3-large-x86> <87wnyyvh56.fsf@collabora.com> <871rh2i9xg.fsf@iwork.i-did-not-set--mail-host-address--so-tickle-me> <87sg9ghil5.fsf@collabora.com> <87lff8gesg.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87lff8gesg.fsf@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2020 at 04:15:59PM +0200, Adrian Ratiu wrote: > On Tue, 10 Nov 2020, Nick Desaulniers > wrote: > > > > Yes, though additionally Arvind points out that this code is > > kind of curious if there was overlap; maybe the parameters > > should just be restrict-qualified. > > > > For now I think I'll just re-send the GCC changes and leave the > Clang optimization as is, until we better understand what's > happening and what's the best way to enable it. > Note that the __restrict__ keywords also help GCC -- it saves it from having to emit the non-vectorized version and switch between the two at runtime. If we can verify it's safe, it's a good thing to add all around. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C50C2D0E4 for ; Thu, 12 Nov 2020 21:51:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF87A216C4 for ; Thu, 12 Nov 2020 21:51:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kpSYZiHf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U390PW+S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF87A216C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alum.mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d6V61AFL55Gt8T3zQCFz2vUil8UA8UvaxamM89MaF1A=; b=kpSYZiHfNgqK7GmOAzmzpR0w3 RRz8eO+LPw/KX10APQMIa4hA6GcPtSlVE+sj19lrfcYMVzLSvRNL5jApg053qIqvp0ShLP6N8PYCM FCZ5imVTMpcrn9O/8OVTCIBZs4ss71LRZdaGUG0KC935ZChtg5yN1z8UxF1smmfrQHfs4ZcbDxrIz 63xZwACLOQijaS188s9hLCCKJcY1aisPqYAYoVFOpOpBpx08Z+H9Hq0wwZT0G0tgPlcndS24R785x OvtFLfZjY8nsdINsma0VK5atYcPV3Ybb6B8UfmBCHGeGYxoW4iXaouB4R3LTR3l3YSJZqwFcNp2wJ iG8ofcZTQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdKUP-0006hi-HA; Thu, 12 Nov 2020 21:50:45 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdKUJ-0006gp-FX for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 21:50:41 +0000 Received: by mail-qk1-x741.google.com with SMTP id n132so7015317qke.1 for ; Thu, 12 Nov 2020 13:50:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z3CD5S2CALksgVm8ns6TDId0Or2oDJ7UUxweYeXuETU=; b=U390PW+SMYc2n3VhGqRdsw6ONn1j5/PFCvEM+sQVMn87P/jOlwMimILpr8rOajdlyi 8ZHLfqbRDeyFh6wvw+1TeVFDhfH2xbTfvCtZLSIIR5MnX//LoWO3SShkhTCUoBDKAXhN 0v2Jdppw/64njlOh9pBLHiIpRQEWmT7nsTQlJ7trrTh43WqRbpWjJZOAxQbv51b6G8nw sDMGA3HWPsVEMphn7HzKe25+RJfep7tnTQehFspm0Jv44wIP9rPdq/Zd7Ua+lIiYFPbt 6NQNtxAHfbzZ2imANyZP1v3HOmKbb9OQfImCYvoi4V12Wd8TziesokuvAn5GbLw4pm2g c7yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=z3CD5S2CALksgVm8ns6TDId0Or2oDJ7UUxweYeXuETU=; b=Hrhgn74s+f9YyYTlnqLF097sBUplNZt5fslgQqbhbh8NiiC8D0CH6N2KIlUpPXdEII Yh4/kyn7+pC+6oiNkq1XtNe1PAsedKzaYwezZGrPBBLeYeePNVZEcCVSPuEvNd1slfSk HrnJD/kc4S1Jrzdd7inolhcRVXjwVXz0Ir69wVWaDT6pYIMnf/j1d3WNoWQRjtPU0sMm BefdmW0WELnOpktFIbXdSia0mzXxc8CgrxVmDwXkicCJfi1LfyTpYCefEtgItO1Wuow/ ZdKxfpUsHs3D8UCtctBXf5lO1/yk4XBs9ZUbybnQYa840urLttyhajZzIgeK6UEoEJzS Y1Xw== X-Gm-Message-State: AOAM531DhyswqG4R9gEdE+85BxguiXftWWdfDTJ0nIXpb+Gmtc2iwezP akUni3LoBqP1W89rSDYW+y4= X-Google-Smtp-Source: ABdhPJzndxGbL4rY+Uq8CS5dGOM9/e02yEyMIYyApn15onZ5PbPo/rpJ/ocftWBNZi52TI1ukQ4VNQ== X-Received: by 2002:a37:8c43:: with SMTP id o64mr2049159qkd.176.1605217836431; Thu, 12 Nov 2020 13:50:36 -0800 (PST) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id c79sm5529081qke.69.2020.11.12.13.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 13:50:35 -0800 (PST) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Thu, 12 Nov 2020 16:50:33 -0500 To: Adrian Ratiu Subject: Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization Message-ID: <20201112215033.GA438824@rani.riverdale.lan> References: <20201106051436.2384842-1-adrian.ratiu@collabora.com> <20201106051436.2384842-3-adrian.ratiu@collabora.com> <20201106101419.GB3811063@ubuntu-m3-large-x86> <87wnyyvh56.fsf@collabora.com> <871rh2i9xg.fsf@iwork.i-did-not-set--mail-host-address--so-tickle-me> <87sg9ghil5.fsf@collabora.com> <87lff8gesg.fsf@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87lff8gesg.fsf@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_165039_532556_A4B7B6FF X-CRM114-Status: GOOD ( 15.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Nick Desaulniers , Russell King , LKML , clang-built-linux , Nathan Chancellor , Collabora Kernel ML , Ard Biesheuvel , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 11, 2020 at 04:15:59PM +0200, Adrian Ratiu wrote: > On Tue, 10 Nov 2020, Nick Desaulniers > wrote: > > > > Yes, though additionally Arvind points out that this code is > > kind of curious if there was overlap; maybe the parameters > > should just be restrict-qualified. > > > > For now I think I'll just re-send the GCC changes and leave the > Clang optimization as is, until we better understand what's > happening and what's the best way to enable it. > Note that the __restrict__ keywords also help GCC -- it saves it from having to emit the non-vectorized version and switch between the two at runtime. If we can verify it's safe, it's a good thing to add all around. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel