All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net v2] net: phy: mscc: remove non-MACSec compatible phy
@ 2020-11-13  9:11 Steen Hegelund
  2020-11-13  9:27 ` Antoine Tenart
  0 siblings, 1 reply; 3+ messages in thread
From: Steen Hegelund @ 2020-11-13  9:11 UTC (permalink / raw)
  To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
	Jakub Kicinski, Antoine Tenart, Bryan Whitehead
  Cc: Steen Hegelund, Microchip UNG Driver List, John Haechten,
	Netdev List, Linux Kernel List

Selecting VSC8575 as a MACSec PHY was not correct

The relevant datasheet can be found here:
  - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575

History:
v1 -> v2:
   - Corrected the sha in the "Fixes:" tag

Fixes: 1bbe0ecc2a1a ("net: phy: mscc: macsec initialization")
Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
---
 drivers/net/phy/mscc/mscc_macsec.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/phy/mscc/mscc_macsec.c b/drivers/net/phy/mscc/mscc_macsec.c
index 1d4c012194e9..72292bf6c51c 100644
--- a/drivers/net/phy/mscc/mscc_macsec.c
+++ b/drivers/net/phy/mscc/mscc_macsec.c
@@ -981,7 +981,6 @@ int vsc8584_macsec_init(struct phy_device *phydev)

 	switch (phydev->phy_id & phydev->drv->phy_id_mask) {
 	case PHY_ID_VSC856X:
-	case PHY_ID_VSC8575:
 	case PHY_ID_VSC8582:
 	case PHY_ID_VSC8584:
 		INIT_LIST_HEAD(&vsc8531->macsec_flows);
--
2.29.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net v2] net: phy: mscc: remove non-MACSec compatible phy
  2020-11-13  9:11 [PATCH net v2] net: phy: mscc: remove non-MACSec compatible phy Steen Hegelund
@ 2020-11-13  9:27 ` Antoine Tenart
  2020-11-14  0:17   ` Jakub Kicinski
  0 siblings, 1 reply; 3+ messages in thread
From: Antoine Tenart @ 2020-11-13  9:27 UTC (permalink / raw)
  To: David S. Miller, Andrew Lunn, Bryan Whitehead, Heiner Kallweit,
	Jakub Kicinski, Russell King, Steen Hegelund
  Cc: Microchip UNG Driver List, John Haechten, Netdev List, Linux Kernel List

Quoting Steen Hegelund (2020-11-13 10:11:16)
> Selecting VSC8575 as a MACSec PHY was not correct
>
> The relevant datasheet can be found here:
>   - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575
>
> History:
> v1 -> v2:
>    - Corrected the sha in the "Fixes:" tag
>
> Fixes: 1bbe0ecc2a1a ("net: phy: mscc: macsec initialization")
> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>

Reviewed-by: Antoine Tenart <atenart@kernel.org>

Small comment: you can put the commit history after the --- so it
doesn't end-up in the commit log (except when it's relevant, which isn't
the case here). I don't think that's a blocker though.

Thanks Steen!
Antoine

> ---
>  drivers/net/phy/mscc/mscc_macsec.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/phy/mscc/mscc_macsec.c b/drivers/net/phy/mscc/mscc_macsec.c
> index 1d4c012194e9..72292bf6c51c 100644
> --- a/drivers/net/phy/mscc/mscc_macsec.c
> +++ b/drivers/net/phy/mscc/mscc_macsec.c
> @@ -981,7 +981,6 @@ int vsc8584_macsec_init(struct phy_device *phydev)
>
>         switch (phydev->phy_id & phydev->drv->phy_id_mask) {
>         case PHY_ID_VSC856X:
> -       case PHY_ID_VSC8575:
>         case PHY_ID_VSC8582:
>         case PHY_ID_VSC8584:
>                 INIT_LIST_HEAD(&vsc8531->macsec_flows);
> --
> 2.29.2
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net v2] net: phy: mscc: remove non-MACSec compatible phy
  2020-11-13  9:27 ` Antoine Tenart
@ 2020-11-14  0:17   ` Jakub Kicinski
  0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-11-14  0:17 UTC (permalink / raw)
  To: Antoine Tenart
  Cc: David S. Miller, Andrew Lunn, Bryan Whitehead, Heiner Kallweit,
	Russell King, Steen Hegelund, Microchip UNG Driver List,
	John Haechten, Netdev List, Linux Kernel List

On Fri, 13 Nov 2020 09:27:30 +0000 Antoine Tenart wrote:
> Quoting Steen Hegelund (2020-11-13 10:11:16)
> > Selecting VSC8575 as a MACSec PHY was not correct
> >
> > The relevant datasheet can be found here:
> >   - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575
> >
> > History:
> > v1 -> v2:
> >    - Corrected the sha in the "Fixes:" tag
> >
> > Fixes: 1bbe0ecc2a1a ("net: phy: mscc: macsec initialization")
> > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>  
> 
> Reviewed-by: Antoine Tenart <atenart@kernel.org>

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-14  0:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13  9:11 [PATCH net v2] net: phy: mscc: remove non-MACSec compatible phy Steen Hegelund
2020-11-13  9:27 ` Antoine Tenart
2020-11-14  0:17   ` Jakub Kicinski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.