* [PATCH] ipv6: remove unused function ipv6_skb_idev()
@ 2020-11-13 13:50 ` Lukas Bulwahn
0 siblings, 0 replies; 6+ messages in thread
From: Lukas Bulwahn @ 2020-11-13 13:50 UTC (permalink / raw)
To: David S . Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI,
Jakub Kicinski, netdev
Cc: Arnd Bergmann, Tom Rix, Nathan Chancellor, Nick Desaulniers,
clang-built-linux, kernel-janitors, linux-kernel, Lukas Bulwahn
Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the
ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since
then, ipv6_skb_idev() is unused and make CC=clang W=1 warns:
net/ipv6/exthdrs.c:909:33:
warning: unused function 'ipv6_skb_idev' [-Wunused-function]
So, remove this unused function and a -Wunused-function warning.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Alexey, Hideaki-san, please ack.
David, Jakub, please pick this minor non-urgent clean-up patch.
net/ipv6/exthdrs.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
index 374105e4394f..584d1b06eb90 100644
--- a/net/ipv6/exthdrs.c
+++ b/net/ipv6/exthdrs.c
@@ -906,10 +906,6 @@ void ipv6_exthdrs_exit(void)
/*
* Note: we cannot rely on skb_dst(skb) before we assign it in ip6_route_input().
*/
-static inline struct inet6_dev *ipv6_skb_idev(struct sk_buff *skb)
-{
- return skb_dst(skb) ? ip6_dst_idev(skb_dst(skb)) : __in6_dev_get(skb->dev);
-}
static inline struct net *ipv6_skb_net(struct sk_buff *skb)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ipv6: remove unused function ipv6_skb_idev()
@ 2020-11-13 13:50 ` Lukas Bulwahn
0 siblings, 0 replies; 6+ messages in thread
From: Lukas Bulwahn @ 2020-11-13 13:50 UTC (permalink / raw)
To: David S . Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI,
Jakub Kicinski, netdev
Cc: Arnd Bergmann, Tom Rix, Nathan Chancellor, Nick Desaulniers,
clang-built-linux, kernel-janitors, linux-kernel, Lukas Bulwahn
Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the
ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since
then, ipv6_skb_idev() is unused and make CC=clang W=1 warns:
net/ipv6/exthdrs.c:909:33:
warning: unused function 'ipv6_skb_idev' [-Wunused-function]
So, remove this unused function and a -Wunused-function warning.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Alexey, Hideaki-san, please ack.
David, Jakub, please pick this minor non-urgent clean-up patch.
net/ipv6/exthdrs.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
index 374105e4394f..584d1b06eb90 100644
--- a/net/ipv6/exthdrs.c
+++ b/net/ipv6/exthdrs.c
@@ -906,10 +906,6 @@ void ipv6_exthdrs_exit(void)
/*
* Note: we cannot rely on skb_dst(skb) before we assign it in ip6_route_input().
*/
-static inline struct inet6_dev *ipv6_skb_idev(struct sk_buff *skb)
-{
- return skb_dst(skb) ? ip6_dst_idev(skb_dst(skb)) : __in6_dev_get(skb->dev);
-}
static inline struct net *ipv6_skb_net(struct sk_buff *skb)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ipv6: remove unused function ipv6_skb_idev()
2020-11-13 13:50 ` Lukas Bulwahn
@ 2020-11-13 18:36 ` Nathan Chancellor
-1 siblings, 0 replies; 6+ messages in thread
From: Nathan Chancellor @ 2020-11-13 18:36 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: David S . Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI,
Jakub Kicinski, netdev, Arnd Bergmann, Tom Rix, Nick Desaulniers,
clang-built-linux, kernel-janitors, linux-kernel
On Fri, Nov 13, 2020 at 02:50:12PM +0100, Lukas Bulwahn wrote:
> Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the
> ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since
> then, ipv6_skb_idev() is unused and make CC=clang W=1 warns:
>
> net/ipv6/exthdrs.c:909:33:
> warning: unused function 'ipv6_skb_idev' [-Wunused-function]
>
> So, remove this unused function and a -Wunused-function warning.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> Alexey, Hideaki-san, please ack.
>
> David, Jakub, please pick this minor non-urgent clean-up patch.
>
> net/ipv6/exthdrs.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
> index 374105e4394f..584d1b06eb90 100644
> --- a/net/ipv6/exthdrs.c
> +++ b/net/ipv6/exthdrs.c
> @@ -906,10 +906,6 @@ void ipv6_exthdrs_exit(void)
> /*
> * Note: we cannot rely on skb_dst(skb) before we assign it in ip6_route_input().
> */
> -static inline struct inet6_dev *ipv6_skb_idev(struct sk_buff *skb)
> -{
> - return skb_dst(skb) ? ip6_dst_idev(skb_dst(skb)) : __in6_dev_get(skb->dev);
> -}
>
> static inline struct net *ipv6_skb_net(struct sk_buff *skb)
> {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ipv6: remove unused function ipv6_skb_idev()
@ 2020-11-13 18:36 ` Nathan Chancellor
0 siblings, 0 replies; 6+ messages in thread
From: Nathan Chancellor @ 2020-11-13 18:36 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: David S . Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI,
Jakub Kicinski, netdev, Arnd Bergmann, Tom Rix, Nick Desaulniers,
clang-built-linux, kernel-janitors, linux-kernel
On Fri, Nov 13, 2020 at 02:50:12PM +0100, Lukas Bulwahn wrote:
> Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the
> ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since
> then, ipv6_skb_idev() is unused and make CC=clang W=1 warns:
>
> net/ipv6/exthdrs.c:909:33:
> warning: unused function 'ipv6_skb_idev' [-Wunused-function]
>
> So, remove this unused function and a -Wunused-function warning.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> Alexey, Hideaki-san, please ack.
>
> David, Jakub, please pick this minor non-urgent clean-up patch.
>
> net/ipv6/exthdrs.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
> index 374105e4394f..584d1b06eb90 100644
> --- a/net/ipv6/exthdrs.c
> +++ b/net/ipv6/exthdrs.c
> @@ -906,10 +906,6 @@ void ipv6_exthdrs_exit(void)
> /*
> * Note: we cannot rely on skb_dst(skb) before we assign it in ip6_route_input().
> */
> -static inline struct inet6_dev *ipv6_skb_idev(struct sk_buff *skb)
> -{
> - return skb_dst(skb) ? ip6_dst_idev(skb_dst(skb)) : __in6_dev_get(skb->dev);
> -}
>
> static inline struct net *ipv6_skb_net(struct sk_buff *skb)
> {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ipv6: remove unused function ipv6_skb_idev()
2020-11-13 18:36 ` Nathan Chancellor
@ 2020-11-14 20:03 ` Jakub Kicinski
-1 siblings, 0 replies; 6+ messages in thread
From: Jakub Kicinski @ 2020-11-14 20:03 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Lukas Bulwahn, David S . Miller, Alexey Kuznetsov,
Hideaki YOSHIFUJI, netdev, Arnd Bergmann, Tom Rix,
Nick Desaulniers, clang-built-linux, kernel-janitors,
linux-kernel
On Fri, 13 Nov 2020 11:36:49 -0700 Nathan Chancellor wrote:
> On Fri, Nov 13, 2020 at 02:50:12PM +0100, Lukas Bulwahn wrote:
> > Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the
> > ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since
> > then, ipv6_skb_idev() is unused and make CC=clang W=1 warns:
> >
> > net/ipv6/exthdrs.c:909:33:
> > warning: unused function 'ipv6_skb_idev' [-Wunused-function]
> >
> > So, remove this unused function and a -Wunused-function warning.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>
> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ipv6: remove unused function ipv6_skb_idev()
@ 2020-11-14 20:03 ` Jakub Kicinski
0 siblings, 0 replies; 6+ messages in thread
From: Jakub Kicinski @ 2020-11-14 20:03 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Lukas Bulwahn, David S . Miller, Alexey Kuznetsov,
Hideaki YOSHIFUJI, netdev, Arnd Bergmann, Tom Rix,
Nick Desaulniers, clang-built-linux, kernel-janitors,
linux-kernel
On Fri, 13 Nov 2020 11:36:49 -0700 Nathan Chancellor wrote:
> On Fri, Nov 13, 2020 at 02:50:12PM +0100, Lukas Bulwahn wrote:
> > Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the
> > ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since
> > then, ipv6_skb_idev() is unused and make CC=clang W=1 warns:
> >
> > net/ipv6/exthdrs.c:909:33:
> > warning: unused function 'ipv6_skb_idev' [-Wunused-function]
> >
> > So, remove this unused function and a -Wunused-function warning.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>
> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-14 20:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 13:50 [PATCH] ipv6: remove unused function ipv6_skb_idev() Lukas Bulwahn
2020-11-13 13:50 ` Lukas Bulwahn
2020-11-13 18:36 ` Nathan Chancellor
2020-11-13 18:36 ` Nathan Chancellor
2020-11-14 20:03 ` Jakub Kicinski
2020-11-14 20:03 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.