From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57413C61DD8 for ; Fri, 13 Nov 2020 17:55:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0442122201 for ; Fri, 13 Nov 2020 17:55:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FE1+mMH0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726205AbgKMRzU (ORCPT ); Fri, 13 Nov 2020 12:55:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725959AbgKMRzT (ORCPT ); Fri, 13 Nov 2020 12:55:19 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3937C0613D1 for ; Fri, 13 Nov 2020 09:55:17 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id o15so10868137wru.6 for ; Fri, 13 Nov 2020 09:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/+PMzrqEXwIpHSYqiZIonnkK0eqVZnv5ws8C/JpM2Ro=; b=FE1+mMH0UYMQRcQQs7KpXFA4j/4+C7+LWdthCcraI4GjvHoVSq5egSXJ6dIWT52Tb/ VZbrsdVzeK7nkCczjAWhm1H4Rs3HIouuOPKj119ajegykHfj7CUteydCStxrj5x0hlnH XBDM6HOeJ8jwSjZEujY/i83583kf7woW21nDuLJmd6Epr58dbZeqVHYAkTmaAMgrJ/RM eBW4eIJ91niVQFmmNXKF7hfKI9w+QGuPppUGZ1Yr7Atxmji3ZgrN0xT7N1i1zsqbi6FY mQEzwScKiSGV5hZDxk0wTMrdRZg9UyCKaj0ThbUezV0lN9IMsEX9k9DCpqaAQlpiY3Vr 13ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/+PMzrqEXwIpHSYqiZIonnkK0eqVZnv5ws8C/JpM2Ro=; b=c3Oyg7PvFT2/XV8tmFKfJVV1cNx0D9xsc/2BQIY0l3suLxAviVsbL+1poaKEb8AQDi ILOtzXyFZL1VcbKgVnt/2/XwNDI1/w7VsKPQaRN+cEWhvMxOa2hfqLzXZwQ1N4+HzbSi FJ3H8yJnvXOdxu6L2OKCITR+114Jiilso0HaKPZdsYrJhzL2dn0dbF+SrQW+yzDLt2TU 8jhnl2cRAr8GBhOgp8WO1tYe/uzrcjVV8IJXgdBuSMKr913mM3PpGKYeLqsz7tNkekL8 94vQCCr3wTcgWTZEWyfKpdH0Oo55EfbtDtAGjLc4n/U8bMIIydct61WGDerpuO/F4xJh UPSQ== X-Gm-Message-State: AOAM533Xdpp4cBCy+JKy+wYJg313H/DUAXvjH95VkCHL44kdGRJwPw5a Va1knnBkZF75jkAN48GWS0K7CQ== X-Google-Smtp-Source: ABdhPJy2CWSCtgMYhxtWZD2Bm08bwkJMMl3ksYfanoTA+WX4VeGO+SoCLrnlO7CMn2PoetaesDufLw== X-Received: by 2002:adf:e607:: with SMTP id p7mr4796819wrm.93.1605290115315; Fri, 13 Nov 2020 09:55:15 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) by smtp.gmail.com with ESMTPSA id c185sm11477158wma.44.2020.11.13.09.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 09:55:14 -0800 (PST) Date: Fri, 13 Nov 2020 18:55:08 +0100 From: Marco Elver To: Andrey Konovalov Cc: Dmitry Vyukov , Alexander Potapenko , Catalin Marinas , Will Deacon , Vincenzo Frascino , Evgenii Stepanov , Andrey Ryabinin , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 11/20] kasan: add and integrate kasan boot parameters Message-ID: <20201113175508.GB3175464@elver.google.com> References: <20201113175254.GA3175464@elver.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201113175254.GA3175464@elver.google.com> User-Agent: Mutt/1.14.6 (2020-07-11) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 13, 2020 at 06:52PM +0100, Marco Elver wrote: > On Tue, Nov 10, 2020 at 11:20PM +0100, 'Andrey Konovalov' via kasan-dev wrote: > [...] > > +/* kasan.mode=off/prod/full */ > > +static int __init early_kasan_mode(char *arg) > > +{ > > + if (!arg) > > + return -EINVAL; > > + > > + if (!strcmp(arg, "off")) > > + kasan_arg_mode = KASAN_ARG_MODE_OFF; > > + else if (!strcmp(arg, "prod")) > > + kasan_arg_mode = KASAN_ARG_MODE_PROD; > > + else if (!strcmp(arg, "full")) > > + kasan_arg_mode = KASAN_ARG_MODE_FULL; > > + else > > + return -EINVAL; > > + > > + return 0; > > +} > > +early_param("kasan.mode", early_kasan_mode); > > + > > +/* kasan.stack=off/on */ > > +static int __init early_kasan_flag_stacktrace(char *arg) > > +{ > > + if (!arg) > > + return -EINVAL; > > + > > + if (!strcmp(arg, "off")) > > + kasan_arg_stacktrace = KASAN_ARG_STACKTRACE_OFF; > > + else if (!strcmp(arg, "on")) > > + kasan_arg_stacktrace = KASAN_ARG_STACKTRACE_ON; > > + else > > + return -EINVAL; > > + > > + return 0; > > +} > > +early_param("kasan.stacktrace", early_kasan_flag_stacktrace); > > + > > +/* kasan.fault=report/panic */ > > +static int __init early_kasan_fault(char *arg) > > +{ > > + if (!arg) > > + return -EINVAL; > > + > > + if (!strcmp(arg, "report")) > > + kasan_arg_fault = KASAN_ARG_FAULT_REPORT; > > + else if (!strcmp(arg, "panic")) > > + kasan_arg_fault = KASAN_ARG_FAULT_PANIC; > > + else > > + return -EINVAL; > > + > > + return 0; > > +} > [...] > > The above could be simplified, see suggestion below. > > Thanks, > -- Marco > > ------ >8 ------ > > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > index c91f2c06ecb5..71fc481ad21d 100644 > --- a/mm/kasan/hw_tags.c > +++ b/mm/kasan/hw_tags.c > @@ -64,10 +64,8 @@ static int __init early_kasan_mode(char *arg) > kasan_arg_mode = KASAN_ARG_MODE_PROD; > else if (!strcmp(arg, "full")) > kasan_arg_mode = KASAN_ARG_MODE_FULL; > - else > - return -EINVAL; > > - return 0; > + return -EINVAL; Ah that clearly doesn't work. Hmm, never mind this suggestion, sorry. Thanks, -- Marco From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C92DAC388F7 for ; Fri, 13 Nov 2020 17:55:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F77720791 for ; Fri, 13 Nov 2020 17:55:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Jeqd7Xzi"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="FE1+mMH0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F77720791 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ECRyvAcZdU0soQLuKEhDmMqKpOf7Hp/PG0w32y+ZRto=; b=Jeqd7XziB5+/ALB66TxO7HDV9 P5FJ2SYVgXDgyxbKveKrWYdbXDpdkNQLCE1/5ph7qzOUrmviJVNZO+65qdFCKPl4er8HEmPtbDgM7 fEA/JUtZtzEtDHgDGpocMIYvqNVSfuw3no/1sPwB8XrS4f9tRYtnAE6iZEVmcUUwtkVoN3Ug0XKSE fpOrQ37v2GKbsuTpPm/2TlZREbABuAft03Cue6FmxaZ9A87qxil7ScOsCaQTpyoBKHXqO51dN4W0c spac5t73rcrNRcz8kHrtgMaiL+TcRea6QtYbFjq8nGzgPAPs7EQ4vaD3dOwAbKwJBDnjQkW4mqJA6 VTikuzamw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kddI6-0007tB-Fk; Fri, 13 Nov 2020 17:55:18 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kddI4-0007sl-Jr for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2020 17:55:17 +0000 Received: by mail-wr1-x442.google.com with SMTP id p1so10842355wrf.12 for ; Fri, 13 Nov 2020 09:55:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/+PMzrqEXwIpHSYqiZIonnkK0eqVZnv5ws8C/JpM2Ro=; b=FE1+mMH0UYMQRcQQs7KpXFA4j/4+C7+LWdthCcraI4GjvHoVSq5egSXJ6dIWT52Tb/ VZbrsdVzeK7nkCczjAWhm1H4Rs3HIouuOPKj119ajegykHfj7CUteydCStxrj5x0hlnH XBDM6HOeJ8jwSjZEujY/i83583kf7woW21nDuLJmd6Epr58dbZeqVHYAkTmaAMgrJ/RM eBW4eIJ91niVQFmmNXKF7hfKI9w+QGuPppUGZ1Yr7Atxmji3ZgrN0xT7N1i1zsqbi6FY mQEzwScKiSGV5hZDxk0wTMrdRZg9UyCKaj0ThbUezV0lN9IMsEX9k9DCpqaAQlpiY3Vr 13ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/+PMzrqEXwIpHSYqiZIonnkK0eqVZnv5ws8C/JpM2Ro=; b=sP6CxrhgQUkn7nEWQz7TwZBg9Tgte8vUfbHen4btYyvfPsCaaLOmAJ7ODXUvy63JfF yeDbxyq6vuU3LtSfK+OmJRWx7gwALuK9kqNrUFTxENSVzZutgO3WiU15YWPJdj6sdIU/ cRhWkqqwaZAsYkJIwPujMgdD433QV9CtV6I3enilHWJOieNjMZHmSCXCRI0Xly/IU0dO s8ytfGZTUIfFtaqAZeXaO26Ir7HwYX2NqcqNyaWSR2lglngvdLGD9rvk6Akcw7rw2t1/ ZrW5no6sIymHNJF030+3rAXVLfsZgzl87Ja0TuDDv2S3XwEpKc1HMJr2YkiHIwfNBWKK jxBA== X-Gm-Message-State: AOAM5301fUX4pHoi2UnZcG1A/tHWPKCmbbLWntEbhEsoRJ2JMNkzy4Kr xbUFAXAf/4a/DIsVlNE2Ynd4zA== X-Google-Smtp-Source: ABdhPJy2CWSCtgMYhxtWZD2Bm08bwkJMMl3ksYfanoTA+WX4VeGO+SoCLrnlO7CMn2PoetaesDufLw== X-Received: by 2002:adf:e607:: with SMTP id p7mr4796819wrm.93.1605290115315; Fri, 13 Nov 2020 09:55:15 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) by smtp.gmail.com with ESMTPSA id c185sm11477158wma.44.2020.11.13.09.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 09:55:14 -0800 (PST) Date: Fri, 13 Nov 2020 18:55:08 +0100 From: Marco Elver To: Andrey Konovalov Subject: Re: [PATCH v2 11/20] kasan: add and integrate kasan boot parameters Message-ID: <20201113175508.GB3175464@elver.google.com> References: <20201113175254.GA3175464@elver.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201113175254.GA3175464@elver.google.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_125516_709793_B5BBE1EC X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Branislav Rankov , Catalin Marinas , Kevin Brodsky , Will Deacon , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 13, 2020 at 06:52PM +0100, Marco Elver wrote: > On Tue, Nov 10, 2020 at 11:20PM +0100, 'Andrey Konovalov' via kasan-dev wrote: > [...] > > +/* kasan.mode=off/prod/full */ > > +static int __init early_kasan_mode(char *arg) > > +{ > > + if (!arg) > > + return -EINVAL; > > + > > + if (!strcmp(arg, "off")) > > + kasan_arg_mode = KASAN_ARG_MODE_OFF; > > + else if (!strcmp(arg, "prod")) > > + kasan_arg_mode = KASAN_ARG_MODE_PROD; > > + else if (!strcmp(arg, "full")) > > + kasan_arg_mode = KASAN_ARG_MODE_FULL; > > + else > > + return -EINVAL; > > + > > + return 0; > > +} > > +early_param("kasan.mode", early_kasan_mode); > > + > > +/* kasan.stack=off/on */ > > +static int __init early_kasan_flag_stacktrace(char *arg) > > +{ > > + if (!arg) > > + return -EINVAL; > > + > > + if (!strcmp(arg, "off")) > > + kasan_arg_stacktrace = KASAN_ARG_STACKTRACE_OFF; > > + else if (!strcmp(arg, "on")) > > + kasan_arg_stacktrace = KASAN_ARG_STACKTRACE_ON; > > + else > > + return -EINVAL; > > + > > + return 0; > > +} > > +early_param("kasan.stacktrace", early_kasan_flag_stacktrace); > > + > > +/* kasan.fault=report/panic */ > > +static int __init early_kasan_fault(char *arg) > > +{ > > + if (!arg) > > + return -EINVAL; > > + > > + if (!strcmp(arg, "report")) > > + kasan_arg_fault = KASAN_ARG_FAULT_REPORT; > > + else if (!strcmp(arg, "panic")) > > + kasan_arg_fault = KASAN_ARG_FAULT_PANIC; > > + else > > + return -EINVAL; > > + > > + return 0; > > +} > [...] > > The above could be simplified, see suggestion below. > > Thanks, > -- Marco > > ------ >8 ------ > > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > index c91f2c06ecb5..71fc481ad21d 100644 > --- a/mm/kasan/hw_tags.c > +++ b/mm/kasan/hw_tags.c > @@ -64,10 +64,8 @@ static int __init early_kasan_mode(char *arg) > kasan_arg_mode = KASAN_ARG_MODE_PROD; > else if (!strcmp(arg, "full")) > kasan_arg_mode = KASAN_ARG_MODE_FULL; > - else > - return -EINVAL; > > - return 0; > + return -EINVAL; Ah that clearly doesn't work. Hmm, never mind this suggestion, sorry. Thanks, -- Marco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel