All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [PATCH 0/3] quorum: Require WRITE perm with rewrite-corrupted
Date: Fri, 13 Nov 2020 22:17:15 +0100	[thread overview]
Message-ID: <20201113211718.261671-1-mreitz@redhat.com> (raw)

Hi,

While reviewing Berto’s block-status/write-zeroes series for quorum, I
wondered how quorum’s permission code handles rewrite-corrupted.  It
turns out it doesn’t, and so qemu with a read-only rewrite-corrupted
quorum node simply crashes once there is a mismatch that leads to a
rewrite.

It looks to me like this bug has existed for quite some time, so I don’t
think this series must go into 5.2.  OTOH, it’s a simple bug fix, so I
suppose it might as well.


Max Reitz (3):
  quorum: Require WRITE perm with rewrite-corrupted
  iotests/081: Filter image format after testdir
  iotests/081: Test rewrite-corrupted without WRITE

 block/quorum.c             |  5 ++++
 tests/qemu-iotests/081     | 61 ++++++++++++++++++++++++++++++++++++--
 tests/qemu-iotests/081.out | 27 +++++++++++++++++
 3 files changed, 90 insertions(+), 3 deletions(-)

-- 
2.28.0



             reply	other threads:[~2020-11-13 21:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 21:17 Max Reitz [this message]
2020-11-13 21:17 ` [PATCH 1/3] quorum: Require WRITE perm with rewrite-corrupted Max Reitz
2020-11-16 12:22   ` Alberto Garcia
2020-11-13 21:17 ` [PATCH 2/3] iotests/081: Filter image format after testdir Max Reitz
2020-11-13 21:17 ` [PATCH 3/3] iotests/081: Test rewrite-corrupted without WRITE Max Reitz
2020-11-17 11:38 ` [PATCH 0/3] quorum: Require WRITE perm with rewrite-corrupted Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113211718.261671-1-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.