From: GitHub pull_request - opened <github@alsa-project.org>
To: alsa-devel@alsa-project.org
Subject: [PATCH 00/16] alsa-gobject: timer: enhancement for error reporting
Date: Sat, 14 Nov 2020 03:00:08 +0100 (CET) [thread overview]
Message-ID: <20201114020008.11FF1F8020C@alsa1.perex.cz> (raw)
In-Reply-To: <1605319200597511053-webhooks-bot@alsa-project.org>
alsa-project/alsa-gobject pull request #49 was opened from takaswie:
The patchset is a part of work about #47.
Current implementation uses library-wide error domain to report error. this
is partly against rule of GError usage. Furthermore, the error delivers
information just about errno and hard to know the cause of error.
This patchset enhances error reporting. The library-wide error domain is
obsoleted. A new error domain is added just for ALSATimer.UserInstance.
The error domain delivers information about the cause of error.
```
Takashi Sakamoto (16):
timer: user_instance: fix function comment
timer: skip check of return value from g_malloc()
timer: check whether method argument for GError is available
timer: add checks for method arguments
timer: instance-params: add checks for method arguments
timer: user_instance: just return when character device is not opened
timer: add GLib enumeration to report type of error for ALSATimer.UserInstance
timer: user_instance: add GQuark to report error for ALSATimer.UserInstance
timer: user_instance: report error due to ioctl failure
timer: user_instance: report error due to open system call
timer: user_instance: report error for timer instance not found
timer: user_instance: report error for unattached timer instance
timer: user_instance: report error for timer already attached
timer: query: use GFileError to report error
timer: query: code refactoring to unify open function
timer: obsolete library-wide GQuark for error reporting
src/timer/alsatimer-enum-types.h | 18 ++++
src/timer/alsatimer.map | 5 +
src/timer/instance-params.c | 20 ++--
src/timer/instance-status.c | 3 +-
src/timer/privates.h | 6 --
src/timer/query.c | 127 ++++++++++++------------
src/timer/user-instance.c | 165 +++++++++++++++++++++++--------
src/timer/user-instance.h | 4 +
tests/alsatimer-enums | 8 ++
9 files changed, 231 insertions(+), 125 deletions(-)
```
Request URL : https://github.com/alsa-project/alsa-gobject/pull/49
Patch URL : https://github.com/alsa-project/alsa-gobject/pull/49.patch
Repository URL: https://github.com/alsa-project/alsa-gobject
parent reply other threads:[~2020-11-14 2:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1605319200597511053-webhooks-bot@alsa-project.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201114020008.11FF1F8020C@alsa1.perex.cz \
--to=github@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.