All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Andreas Roeseler <andreas.a.roeseler@gmail.com>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru,
	yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 3/3] ICMPv6: define probe message types
Date: Sat, 14 Nov 2020 09:46:50 -0800	[thread overview]
Message-ID: <20201114094650.2666c2a4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <03d35bcb7aa843ede4fb3bc224b7eba85c12d522.1605323689.git.andreas.a.roeseler@gmail.com>

On Fri, 13 Nov 2020 19:24:17 -0800 Andreas Roeseler wrote:
> The types of ICMPV6 Extended Echo Request and ICMPV6 Extended Echo Reply
> are defined in sections 2 and 3 of RFC8335.
> 
> Signed-off-by: Andreas Roeseler <andreas.a.roeseler@gmail.com>

> diff --git a/include/linux/icmpv6.h b/include/linux/icmpv6.h
> index ba45e6bc076..c6186774584 100644
> --- a/include/linux/icmpv6.h
> +++ b/include/linux/icmpv6.h
> @@ -137,6 +137,12 @@ static inline struct icmp6hdr *icmp6_hdr(const struct sk_buff *skb)
>  #define ICMPV6_UNK_NEXTHDR		1
>  #define ICMPV6_UNK_OPTION		2
>  
> +/*
> + *	Codes for EXT_ECHO (Probe)
> + */
> +#define ICMPV6_EXT_ECHO_REQUEST		160
> +#define ICMPV6_EXT_ECHO_REPLY		161
> +
>  /*
>   *	constants for (set|get)sockopt
>   */

Hm, quite strange. The context we're seeing here was removed 8 years
ago by:

commit 607ca46e97a1b6594b29647d98a32d545c24bdff
Author: David Howells <dhowells@redhat.com>
Date:   Sat Oct 13 10:46:48 2012 +0100

    UAPI: (Scripted) Disintegrate include/linux

Are you sure you are on the right tree?

      reply	other threads:[~2020-11-14 17:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-14  3:23 [PATCH v2 net-next 0/3] Add support for sending RFC8335 PROBE Andreas Roeseler
2020-11-14  3:24 ` [PATCH v2 net-next 1/3] net: add support for sending probe messages Andreas Roeseler
2020-11-14  3:24 ` [PATCH v2 net-next 2/3] icmp: define probe message types Andreas Roeseler
2020-11-14  3:24 ` [PATCH v2 net-next 3/3] ICMPv6: " Andreas Roeseler
2020-11-14 17:46   ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201114094650.2666c2a4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=andreas.a.roeseler@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.