From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F6AC5519F for ; Sat, 14 Nov 2020 10:01:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9E402224B for ; Sat, 14 Nov 2020 10:01:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726598AbgKNKA5 (ORCPT ); Sat, 14 Nov 2020 05:00:57 -0500 Received: from verein.lst.de ([213.95.11.211]:49892 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726481AbgKNKA5 (ORCPT ); Sat, 14 Nov 2020 05:00:57 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 6BE3C67373; Sat, 14 Nov 2020 11:00:54 +0100 (CET) Date: Sat, 14 Nov 2020 11:00:53 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hughd@google.com, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 04/16] mm: Add FGP_ENTRY Message-ID: <20201114100053.GE19102@lst.de> References: <20201112212641.27837-1-willy@infradead.org> <20201112212641.27837-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112212641.27837-5-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 09:26:29PM +0000, Matthew Wilcox (Oracle) wrote: > The functionality of find_lock_entry() and find_get_entry() can be > provided by pagecache_get_pages(), s/pagecache_get_pages/pagecache_get_page/ > which lets us delete find_lock_entry() > and make find_get_entry() static. I think this should mention that find_get_entry is now only used by pagecache_get_page. That answers the obvious questions of why we could not switch all callers of find_get_entry to pagecache_get_page. Otherwise looks good: Reviewed-by: Christoph Hellwig