From: Jakub Kicinski <kuba@kernel.org>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: Xin Long <lucien.xin@gmail.com>,
network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net,
Neil Horman <nhorman@tuxdriver.com>,
Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCHv2 net] sctp: change to hold/put transport for proto_unreach_timer
Date: Sat, 14 Nov 2020 11:58:28 -0800 [thread overview]
Message-ID: <20201114115828.6000db41@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201114134023.GC3556@localhost.localdomain>
On Sat, 14 Nov 2020 10:40:23 -0300 Marcelo Ricardo Leitner wrote:
> On Sat, Nov 14, 2020 at 01:22:53PM +0800, Xin Long wrote:
> > A call trace was found in Hangbin's Codenomicon testing with debug kernel:
> >
> ...
> >
> > So fix it by holding/putting transport instead for proto_unreach_timer
> > in transport, just like other timers in transport.
> >
> > v1->v2:
> > - Also use sctp_transport_put() for the "out_unlock:" path in
> > sctp_generate_proto_unreach_event(), as Marcelo noticed.
> >
> > Fixes: 50b5d6ad6382 ("sctp: Fix a race between ICMP protocol unreachable and connect()")
> > Reported-by: Hangbin Liu <liuhangbin@gmail.com>
> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Applied, thanks!
prev parent reply other threads:[~2020-11-14 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 5:22 [PATCHv2 net] sctp: change to hold/put transport for proto_unreach_timer Xin Long
2020-11-14 13:40 ` Marcelo Ricardo Leitner
2020-11-14 19:58 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201114115828.6000db41@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.