From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17B71C63697 for ; Sat, 14 Nov 2020 20:09:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2235223B0 for ; Sat, 14 Nov 2020 20:09:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fJ8Tip6u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726306AbgKNUJa (ORCPT ); Sat, 14 Nov 2020 15:09:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:59520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726265AbgKNUJ3 (ORCPT ); Sat, 14 Nov 2020 15:09:29 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (c-67-180-217-166.hsd1.ca.comcast.net [67.180.217.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB72A222EA; Sat, 14 Nov 2020 20:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605384568; bh=zKMvbDCZHKRWvy5cjeZ6p0aHm0PizayGBh+ZITU30AY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fJ8Tip6uDozSb3pvq6/ji29M73k4E7+8eUiJEy8DOIAUyxhBxriAyEKYD7WeDzsTh Y/C5HgRcT7/1W7fiYacC3XlaJCiFlfJ5lvhtSo2ogktRUefwWLMR6r+eCH0XBAzBJ8 TrNNIFX2KdpcYf78GYlHSJQRNIw6RB8zlu0PjE18= Date: Sat, 14 Nov 2020 12:09:26 -0800 From: Jakub Kicinski To: James Morris Cc: Paul Moore , netdev@vger.kernel.org, Dan Carpenter , linux-security-module@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH] netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist() Message-ID: <20201114120922.07ec38a4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <160530304068.15651.18355773009751195447.stgit@sifl> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 14 Nov 2020 18:03:56 +1100 (AEDT) James Morris wrote: > > Static checking revealed that a previous fix to > > netlbl_unlabel_staticlist() leaves a stack variable uninitialized, > > this patches fixes that. > > > > Fixes: 866358ec331f ("netlabel: fix our progress tracking in netlbl_unlabel_staticlist()") > > Reported-by: Dan Carpenter > > Signed-off-by: Paul Moore > > Reviewed-by: James Morris Applied, thanks!