All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 05/27] drm/i915/pxp: Enable ioctl action to set the ring3 context
Date: Sat, 14 Nov 2020 19:03:47 +0800	[thread overview]
Message-ID: <202011141845.duOXPJht-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 6266 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201114014537.25495-5-sean.z.huang@intel.com>
References: <20201114014537.25495-5-sean.z.huang@intel.com>
TO: Sean Z Huang <sean.z.huang@intel.com>
TO: Intel-gfx(a)lists.freedesktop.org
CC: "Huang, Sean Z" <sean.z.huang@intel.com>

Hi Sean,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20201113]
[also build test WARNING on v5.10-rc3]
[cannot apply to drm-intel/for-linux-next char-misc/char-misc-testing v5.10-rc3 v5.10-rc2 v5.10-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sean-Z-Huang/drm-i915-pxp-Introduce-Intel-PXP-component/20201114-094926
base:    92edc4aef86780a8ad01b092c6d6630bb3cb423d
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
config: i386-randconfig-c001-20201113 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/gpu/drm/i915/pxp/intel_pxp.c:21:17-20: ERROR: i915 is NULL but dereferenced.

vim +21 drivers/gpu/drm/i915/pxp/intel_pxp.c

a9c9ffc6ce4f8b0 Huang, Sean Z 2020-11-13  10  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  11  int i915_pxp_ops_ioctl(struct drm_device *dev, void *data, struct drm_file *drmfile)
1d109ada10e82c3 Huang, Sean Z 2020-11-13  12  {
1d109ada10e82c3 Huang, Sean Z 2020-11-13  13  	int ret;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  14  	struct pxp_info pxp_info = {0};
1d109ada10e82c3 Huang, Sean Z 2020-11-13  15  	struct drm_i915_pxp_ops *pxp_ops = data;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  16  	struct drm_i915_private *i915 = to_i915(dev);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  17  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  18  	drm_dbg(&i915->drm, ">>> %s\n", __func__);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  19  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  20  	if (!i915 || !drmfile || !pxp_ops || pxp_ops->pxp_info_size != sizeof(pxp_info)) {
1d109ada10e82c3 Huang, Sean Z 2020-11-13 @21  		drm_dbg(&i915->drm, "Failed to %s, invalid params\n", __func__);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  22  		ret = -EINVAL;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  23  		goto end;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  24  	}
1d109ada10e82c3 Huang, Sean Z 2020-11-13  25  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  26  	if (copy_from_user(&pxp_info, (void __user *)pxp_ops->pxp_info_ptr, sizeof(pxp_info)) != 0) {
1d109ada10e82c3 Huang, Sean Z 2020-11-13  27  		ret = -EFAULT;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  28  		goto end;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  29  	}
1d109ada10e82c3 Huang, Sean Z 2020-11-13  30  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  31  	drm_dbg(&i915->drm, "i915 pxp ioctl call with action=[%d]\n", pxp_info.action);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  32  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  33  	mutex_lock(&i915->pxp.r0ctx->ctx_mutex);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  34  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  35  	if (i915->pxp.r0ctx->global_state_in_suspend) {
1d109ada10e82c3 Huang, Sean Z 2020-11-13  36  		drm_dbg(&i915->drm, "Return failure due to state in suspend\n");
1d109ada10e82c3 Huang, Sean Z 2020-11-13  37  		pxp_info.sm_status = PXP_SM_STATUS_SESSION_NOT_AVAILABLE;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  38  		ret = 0;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  39  		goto end;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  40  	}
1d109ada10e82c3 Huang, Sean Z 2020-11-13  41  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  42  	if (i915->pxp.r0ctx->global_state_attacked) {
1d109ada10e82c3 Huang, Sean Z 2020-11-13  43  		drm_dbg(&i915->drm, "Retry required due to state attacked\n");
1d109ada10e82c3 Huang, Sean Z 2020-11-13  44  		pxp_info.sm_status = PXP_SM_STATUS_RETRY_REQUIRED;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  45  		ret = 0;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  46  		goto end;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  47  	}
1d109ada10e82c3 Huang, Sean Z 2020-11-13  48  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  49  	switch (pxp_info.action) {
1d109ada10e82c3 Huang, Sean Z 2020-11-13  50  	case PXP_ACTION_SET_R3_CONTEXT:
1d109ada10e82c3 Huang, Sean Z 2020-11-13  51  	{
1d109ada10e82c3 Huang, Sean Z 2020-11-13  52  		ret = intel_pxp_set_r3ctx(i915, pxp_info.set_r3ctx);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  53  		break;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  54  	}
1d109ada10e82c3 Huang, Sean Z 2020-11-13  55  	default:
1d109ada10e82c3 Huang, Sean Z 2020-11-13  56  		drm_dbg(&i915->drm, "Failed to %s due to bad params\n", __func__);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  57  		ret = -EINVAL;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  58  		goto end;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  59  	}
1d109ada10e82c3 Huang, Sean Z 2020-11-13  60  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  61  end:
1d109ada10e82c3 Huang, Sean Z 2020-11-13  62  	mutex_unlock(&i915->pxp.r0ctx->ctx_mutex);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  63  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  64  	if (ret == 0)
1d109ada10e82c3 Huang, Sean Z 2020-11-13  65  		if (copy_to_user((void __user *)pxp_ops->pxp_info_ptr, &pxp_info, sizeof(pxp_info)) != 0)
1d109ada10e82c3 Huang, Sean Z 2020-11-13  66  			ret = -EFAULT;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  67  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  68  	if (ret)
1d109ada10e82c3 Huang, Sean Z 2020-11-13  69  		dev_err(&dev->pdev->dev, "pid=%d, ret = %d\n", task_pid_nr(current), ret);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  70  
1d109ada10e82c3 Huang, Sean Z 2020-11-13  71  	drm_dbg(&i915->drm, "<<< %s\n", __func__);
1d109ada10e82c3 Huang, Sean Z 2020-11-13  72  	return ret;
1d109ada10e82c3 Huang, Sean Z 2020-11-13  73  }
1d109ada10e82c3 Huang, Sean Z 2020-11-13  74  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36612 bytes --]

             reply	other threads:[~2020-11-14 11:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-14 11:03 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-11-15 21:07 [Intel-gfx] [PATCH 01/27] drm/i915/pxp: Introduce Intel PXP component Huang, Sean Z
2020-11-15 21:07 ` [Intel-gfx] [PATCH 05/27] drm/i915/pxp: Enable ioctl action to set the ring3 context Huang, Sean Z
2020-11-16 10:22   ` Joonas Lahtinen
2020-11-16 10:53     ` Chris Wilson
2020-11-15 20:23 [Intel-gfx] [PATCH 01/27] drm/i915/pxp: Introduce Intel PXP component Huang, Sean Z
2020-11-15 20:23 ` [Intel-gfx] [PATCH 05/27] drm/i915/pxp: Enable ioctl action to set the ring3 context Huang, Sean Z
2020-11-15  7:34 kernel test robot
2020-11-14  1:45 [Intel-gfx] [PATCH 01/27] drm/i915/pxp: Introduce Intel PXP component Sean Z Huang
2020-11-14  1:45 ` [Intel-gfx] [PATCH 05/27] drm/i915/pxp: Enable ioctl action to set the ring3 context Sean Z Huang
2020-11-14  4:23   ` kernel test robot
2020-11-14  4:23     ` kernel test robot
2020-11-16  9:46   ` Dan Carpenter
2020-11-16  9:46     ` Dan Carpenter
2020-11-16  9:46     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202011141845.duOXPJht-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.